| Message ID | 20220816105528.3222763-1-abel.vesa@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | misc: fastrpc: Use USER_PD define in fastrpc_get_info_from_dsp | expand |
On Tue, Aug 16, 2022 at 01:55:28PM +0300, Abel Vesa wrote: > There are defines for each type of protection domain now. > Use the USER_PD instead of magic value in fastrpc_get_info_from_dsp. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Amol Maheshwari <amahesh@qti.qualcomm.com> This looks like it got the only remaining magic value assignment. Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > --- > drivers/misc/fastrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 93ebd174d848..8895ca593911 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1515,7 +1515,7 @@ static int fastrpc_get_info_from_dsp(struct fastrpc_user *fl, uint32_t *dsp_attr > args[1].ptr = (u64)(uintptr_t)&dsp_attr_buf[1]; > args[1].length = dsp_attr_buf_len; > args[1].fd = -1; > - fl->pd = 1; > + fl->pd = USER_PD; > > return fastrpc_internal_invoke(fl, true, FASTRPC_DSP_UTILITIES_HANDLE, > FASTRPC_SCALARS(0, 1, 1), args); > -- > 2.34.1 >
On 16/08/2022 11:55, Abel Vesa wrote: > There are defines for each type of protection domain now. > Use the USER_PD instead of magic value in fastrpc_get_info_from_dsp. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Amol Maheshwari <amahesh@qti.qualcomm.com> > --- LGTM Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --srini > drivers/misc/fastrpc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c > index 93ebd174d848..8895ca593911 100644 > --- a/drivers/misc/fastrpc.c > +++ b/drivers/misc/fastrpc.c > @@ -1515,7 +1515,7 @@ static int fastrpc_get_info_from_dsp(struct fastrpc_user *fl, uint32_t *dsp_attr > args[1].ptr = (u64)(uintptr_t)&dsp_attr_buf[1]; > args[1].length = dsp_attr_buf_len; > args[1].fd = -1; > - fl->pd = 1; > + fl->pd = USER_PD; > > return fastrpc_internal_invoke(fl, true, FASTRPC_DSP_UTILITIES_HANDLE, > FASTRPC_SCALARS(0, 1, 1), args);
diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 93ebd174d848..8895ca593911 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1515,7 +1515,7 @@ static int fastrpc_get_info_from_dsp(struct fastrpc_user *fl, uint32_t *dsp_attr args[1].ptr = (u64)(uintptr_t)&dsp_attr_buf[1]; args[1].length = dsp_attr_buf_len; args[1].fd = -1; - fl->pd = 1; + fl->pd = USER_PD; return fastrpc_internal_invoke(fl, true, FASTRPC_DSP_UTILITIES_HANDLE, FASTRPC_SCALARS(0, 1, 1), args);
There are defines for each type of protection domain now. Use the USER_PD instead of magic value in fastrpc_get_info_from_dsp. Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Amol Maheshwari <amahesh@qti.qualcomm.com> --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)