Message ID | 199cc377eb38606bfa4b33942f0ed688080cf535.1657636714.git.bertrand.marquis@arm.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | automation: Remove build-* from gitignore | expand |
On 12.07.2022 16:41, Bertrand Marquis wrote: > ...because there are some scripts in automation corresponding to the > entry (build-test.sh and build-each-commit.sh) > > Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com> While it seems odd to have this simple a patch sit un-acked for this long, it looks like I'm not the only one uncomfortable ack-ing it without knowing why the entry was there. Old .hgignore history only tells me that at some point build* was changed to build-*. This recent mail from Andrew (https://lists.xen.org/archives/html/xen-devel/2022-08/msg01043.html) matches my vague recollection of build-* being used as sub-trees for building stuff when out-of-tree builds are possible, yet people also don't want to build in an entirely separate tree. Hence as a compromise between keeping the status quo and deleting the entry, could we go with changing it to build-*/ ? Jan > --- a/.gitignore > +++ b/.gitignore > @@ -44,7 +44,6 @@ config.cache > config/Toplevel.mk > config/Paths.mk > > -build-* > dist/* > docs/tmp.* > docs/html/
Hi Jan, > On 18 Aug 2022, at 15:30, Jan Beulich <jbeulich@suse.com> wrote: > > On 12.07.2022 16:41, Bertrand Marquis wrote: >> ...because there are some scripts in automation corresponding to the >> entry (build-test.sh and build-each-commit.sh) >> >> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com> > > While it seems odd to have this simple a patch sit un-acked for this long, > it looks like I'm not the only one uncomfortable ack-ing it without knowing > why the entry was there. Old .hgignore history only tells me that at some > point build* was changed to build-*. This recent mail from Andrew > (https://lists.xen.org/archives/html/xen-devel/2022-08/msg01043.html) > matches my vague recollection of build-* being used as sub-trees for > building stuff when out-of-tree builds are possible, yet people also don't > want to build in an entirely separate tree. Thanks for reacting on this, I should have pinged in fact. > > Hence as a compromise between keeping the status quo and deleting the > entry, could we go with changing it to build-*/ ? I must admit that not knowing why it was there I could not suggest how to fix. This would work for the current issue so I am ok with that. Cheers Bertrand > > Jan > >> --- a/.gitignore >> +++ b/.gitignore >> @@ -44,7 +44,6 @@ config.cache >> config/Toplevel.mk >> config/Paths.mk >> >> -build-* >> dist/* >> docs/tmp.* >> docs/html/ >
diff --git a/.gitignore b/.gitignore index 4729911c51..f731975713 100644 --- a/.gitignore +++ b/.gitignore @@ -44,7 +44,6 @@ config.cache config/Toplevel.mk config/Paths.mk -build-* dist/* docs/tmp.* docs/html/
...because there are some scripts in automation corresponding to the entry (build-test.sh and build-each-commit.sh) Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com> --- .gitignore | 1 - 1 file changed, 1 deletion(-)