mbox series

[0/2] cpufreq: mediatek-hw: add support for mt8188

Message ID 20220805091211.2791-1-jia-wei.chang@mediatek.com (mailing list archive)
Headers show
Series cpufreq: mediatek-hw: add support for mt8188 | expand

Message

Jia-wei Chang (張佳偉) Aug. 5, 2022, 9:12 a.m. UTC
From: Jia-Wei Chang <jia-wei.chang@mediatek.com>

This series supports MT8188 cpufreq hw driver which used for power
saving to scale the clock frequency and supply the voltage for CPUs.

Jia-Wei Chang (2):
  dt-bindings: cpufreq: add mt8188 cpufreq hw dt-bindings
  cpufreq: mediatek-hw: add support for mt8188

 .../bindings/cpufreq/cpufreq-mediatek-hw.yaml          |  4 +++-
 drivers/cpufreq/mediatek-cpufreq-hw.c                  | 10 ++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Aug. 5, 2022, 9:18 a.m. UTC | #1
On 05/08/2022 11:12, jia-wei.chang wrote:
> From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> 
> Add mt8188 cpufreq hw compatible in dt-bindings.
> 
> Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> ---
>  .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml      | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> index 9cd42a64b13e..b56d36224612 100644
> --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml
> @@ -16,7 +16,9 @@ description:
>  
>  properties:
>    compatible:
> -    const: mediatek,cpufreq-hw
> +    enum:
> +      - mediatek,cpufreq-hw

Can you add a comment mentioning for which SoCs this is? Someone added a
generic compatible covering all MediaTek cpufreq-hw (all!) and now you
say it does not cover all?

Best regards,
Krzysztof
Jia-wei Chang (張佳偉) Aug. 19, 2022, 9:21 a.m. UTC | #2
On Fri, 2022-08-05 at 11:18 +0200, Krzysztof Kozlowski wrote:
> On 05/08/2022 11:12, jia-wei.chang wrote:
> > From: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> > 
> > Add mt8188 cpufreq hw compatible in dt-bindings.
> > 
> > Signed-off-by: Jia-Wei Chang <jia-wei.chang@mediatek.com>
> > ---
> >  .../devicetree/bindings/cpufreq/cpufreq-mediatek-hw.yaml      | 4
> > +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-
> > mediatek-hw.yaml
> > b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > index 9cd42a64b13e..b56d36224612 100644
> > --- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek-
> > hw.yaml
> > @@ -16,7 +16,9 @@ description:
> >  
> >  properties:
> >    compatible:
> > -    const: mediatek,cpufreq-hw
> > +    enum:
> > +      - mediatek,cpufreq-hw
> 
> Can you add a comment mentioning for which SoCs this is? Someone
> added a
> generic compatible covering all MediaTek cpufreq-hw (all!) and now
> you
> say it does not cover all?
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

I realized it is possible to make MT8188 completely reuse the
compatibles "mediatek,cpufreq-hw" and platform driver as well.

This series for MT8188 mediatek-cpufreq-hw is no longer required to be
reviewed.

Thanks for your help.