Message ID | pull.1303.v3.git.1660883290.gitgitgadget@gmail.com (mailing list archive) |
---|---|
Headers | show |
Series | Allow --ancestry-path to take an argument | expand |
On 8/19/2022 12:28 AM, Elijah Newren via GitGitGadget wrote: > Changes since v2: > > * Incorporated Stolee's suggested patch as a preliminary cleanup of t6019. > Slightly modified his patch by: > * fixing the "repetitive" typo pointed out by Eric > * removed the unnecessary "return 1" pointed out by Ævar > * switched "rev-list" to "log" since we are using --format anyway, in > order to remove the need to call "sed" afterward Thanks! I appreciate you fixing all of my mistakes and incorporating all of the existing feedback. It also looks nicer as your patch 2 than as a third on top. This version looks good to me. -Stolee
Derrick Stolee <derrickstolee@github.com> writes: > On 8/19/2022 12:28 AM, Elijah Newren via GitGitGadget wrote: >> Changes since v2: >> >> * Incorporated Stolee's suggested patch as a preliminary cleanup of t6019. >> Slightly modified his patch by: >> * fixing the "repetitive" typo pointed out by Eric >> * removed the unnecessary "return 1" pointed out by Ævar >> * switched "rev-list" to "log" since we are using --format anyway, in >> order to remove the need to call "sed" afterward > > Thanks! I appreciate you fixing all of my mistakes and > incorporating all of the existing feedback. It also looks > nicer as your patch 2 than as a third on top. > > This version looks good to me. Yup, it looks good to me, too. Thanks, both. Let's mark it for 'next' and merge it down soonish.
On Fri, Aug 19, 2022 at 2:08 PM Junio C Hamano <gitster@pobox.com> wrote: > > Derrick Stolee <derrickstolee@github.com> writes: > > > On 8/19/2022 12:28 AM, Elijah Newren via GitGitGadget wrote: > >> Changes since v2: > >> > >> * Incorporated Stolee's suggested patch as a preliminary cleanup of t6019. > >> Slightly modified his patch by: > >> * fixing the "repetitive" typo pointed out by Eric > >> * removed the unnecessary "return 1" pointed out by Ævar > >> * switched "rev-list" to "log" since we are using --format anyway, in > >> order to remove the need to call "sed" afterward > > > > Thanks! I appreciate you fixing all of my mistakes and > > incorporating all of the existing feedback. It also looks > > nicer as your patch 2 than as a third on top. > > > > This version looks good to me. > > Yup, it looks good to me, too. Thanks, both. And thanks to all the other reviewers as well! Good suggestions came in from several different folks. > Let's mark it for 'next' and merge it down soonish. Sounds good.