diff mbox series

[BlueZ] zsh: drop no more arguments message

Message ID 20220822023242.18162-1-ronan@rjp.ie (mailing list archive)
State Superseded
Headers show
Series [BlueZ] zsh: drop no more arguments message | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/scan_build success Pass

Commit Message

Ronan Pigott Aug. 22, 2022, 2:32 a.m. UTC 
This usage of the _message as a completion function is invalid, and
will result in an error if invoked by _arguments when the user has a
format style set for completion messages.

We can just drop this message, since it is not necessary.
---
 completion/zsh/_bluetoothctl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

bluez.test.bot@gmail.com Aug. 22, 2022, 4:45 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=669604

---Test result---

Test Summary:
CheckPatch                    PASS      0.97 seconds
GitLint                       PASS      0.74 seconds
Prep - Setup ELL              PASS      26.48 seconds
Build - Prep                  PASS      0.71 seconds
Build - Configure             PASS      8.37 seconds
Build - Make                  PASS      815.78 seconds
Make Check                    PASS      11.50 seconds
Make Check w/Valgrind         PASS      284.35 seconds
Make Distcheck                PASS      230.86 seconds
Build w/ext ELL - Configure   PASS      8.37 seconds
Build w/ext ELL - Make        PASS      81.70 seconds
Incremental Build w/ patches  PASS      0.00 seconds
Scan Build                    PASS      491.19 seconds



---
Regards,
Linux Bluetooth
Luiz Augusto von Dentz Aug. 22, 2022, 10:55 p.m. UTC | #2 
Hi Ronan,

On Sun, Aug 21, 2022 at 7:33 PM Ronan Pigott <ronan@rjp.ie> wrote:
>
> This usage of the _message as a completion function is invalid, and
> will result in an error if invoked by _arguments when the user has a
> format style set for completion messages.
>
> We can just drop this message, since it is not necessary.

It might be better to include the output of zsh when it fails to
auto-complete, or actually a pre and post patch output.

> ---
>  completion/zsh/_bluetoothctl | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/completion/zsh/_bluetoothctl b/completion/zsh/_bluetoothctl
> index bf35e503e..610ca2b8d 100644
> --- a/completion/zsh/_bluetoothctl
> +++ b/completion/zsh/_bluetoothctl
> @@ -68,8 +68,7 @@ _bluetoothctl() {
>                 '(info)'{-m,--monitor}'[Enable monitor output]' \
>                 + 'command' \
>                 '(info):command:->command' \
> -               '(info):: :->argument' \
> -               ': :_message "no more arguments"'
> +               '(info):: :->argument'
>
>         if [[ $state == "command" ]]; then
>                 _describe -t commands 'command' all_commands
> --
> 2.37.2
>
diff mbox series

Patch

diff --git a/completion/zsh/_bluetoothctl b/completion/zsh/_bluetoothctl
index bf35e503e..610ca2b8d 100644
--- a/completion/zsh/_bluetoothctl
+++ b/completion/zsh/_bluetoothctl
@@ -68,8 +68,7 @@  _bluetoothctl() {
 		'(info)'{-m,--monitor}'[Enable monitor output]' \
 		+ 'command' \
 		'(info):command:->command' \
-		'(info):: :->argument' \
-		': :_message "no more arguments"'
+		'(info):: :->argument'
 
 	if [[ $state == "command" ]]; then
 		_describe -t commands 'command' all_commands