| Message ID | 20220819053234.241501-8-tales.aparecida@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0f3f1123ac6e14a2c0a32f7a43163e6704beb74f |
| Headers | show |
| Series | Documentation: Kunit: clean kunit-tool.rst and start.rst | expand |
On Fri, Aug 19, 2022 at 02:32:33AM -0300, Tales Aparecida wrote: > Replace URL with an updated path to the full Documentation page > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org>
On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida <tales.aparecida@gmail.com> wrote: > > Replace URL with an updated path to the full Documentation page > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> > --- > lib/overflow_kunit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c > index 7e3e43679b73..78075106c0df 100644 > --- a/lib/overflow_kunit.c > +++ b/lib/overflow_kunit.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 OR MIT > /* > * Test cases for arithmetic overflow checks. See: > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst Oh, I thought I had sent a patch out for this. The rewritten version of the patch is https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html That's what I was intending to rewrite this line to point to. But if people like a Documentation/ path to start.rst instead, that also works. Daniel
Hi Daniel, Em seg., 22 de ago. de 2022 às 17:09, Daniel Latypov <dlatypov@google.com> escreveu: > > On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida > <tales.aparecida@gmail.com> wrote: > > > > Replace URL with an updated path to the full Documentation page > > > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> > > --- > > lib/overflow_kunit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c > > index 7e3e43679b73..78075106c0df 100644 > > --- a/lib/overflow_kunit.c > > +++ b/lib/overflow_kunit.c > > @@ -1,7 +1,7 @@ > > // SPDX-License-Identifier: GPL-2.0 OR MIT > > /* > > * Test cases for arithmetic overflow checks. See: > > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests > > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst > > Oh, I thought I had sent a patch out for this. > The rewritten version of the patch is > https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html > That's what I was intending to rewrite this line to point to. > > But if people like a Documentation/ path to start.rst instead, that also works. > > Daniel You are absolutely right! You did send and I wasn't aware, sorry. https://lore.kernel.org/all/20220603195626.121922-1-dlatypov@google.com/ I guess it stalled after that discussion about *where* it should be applied, I got a green flag in IRC and didn't do my due diligence carefully, just tried to find pending patches at linux-kselftest which wasn't CC'd Now, about the change, either way is fine by me. Kind regards, Tales
On Mon, Aug 22, 2022 at 3:35 PM Tales <tales.aparecida@gmail.com> wrote: > > Hi Daniel, > > Em seg., 22 de ago. de 2022 às 17:09, Daniel Latypov > <dlatypov@google.com> escreveu: > > > > On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida > > <tales.aparecida@gmail.com> wrote: > > > > > > Replace URL with an updated path to the full Documentation page > > > > > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> > > > --- > > > lib/overflow_kunit.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c > > > index 7e3e43679b73..78075106c0df 100644 > > > --- a/lib/overflow_kunit.c > > > +++ b/lib/overflow_kunit.c > > > @@ -1,7 +1,7 @@ > > > // SPDX-License-Identifier: GPL-2.0 OR MIT > > > /* > > > * Test cases for arithmetic overflow checks. See: > > > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests > > > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst > > > > Oh, I thought I had sent a patch out for this. > > The rewritten version of the patch is > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html > > That's what I was intending to rewrite this line to point to. > > > > But if people like a Documentation/ path to start.rst instead, that also works. > > > > Daniel > > You are absolutely right! You did send and I wasn't aware, sorry. > https://lore.kernel.org/all/20220603195626.121922-1-dlatypov@google.com/ > I guess it stalled after that discussion about *where* it should be applied, > I got a green flag in IRC and didn't do my due diligence carefully, > just tried to find pending patches at linux-kselftest which wasn't > CC'd Oh right, it was that series where I didn't cc linux-kselftest. That was my bad, sorry. But I had forgotten to include a patch in that series to update this file still, afaict. I could revive that series and add on a version of this patch, if we want? Daniel
Em seg., 22 de ago. de 2022 às 19:52, Daniel Latypov <dlatypov@google.com> escreveu: > > On Mon, Aug 22, 2022 at 3:35 PM Tales <tales.aparecida@gmail.com> wrote: > > > > Hi Daniel, > > > > Em seg., 22 de ago. de 2022 às 17:09, Daniel Latypov > > <dlatypov@google.com> escreveu: > > > > > > On Thu, Aug 18, 2022 at 10:33 PM Tales Aparecida > > > <tales.aparecida@gmail.com> wrote: > > > > > > > > Replace URL with an updated path to the full Documentation page > > > > > > > > Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> > > > > --- > > > > lib/overflow_kunit.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c > > > > index 7e3e43679b73..78075106c0df 100644 > > > > --- a/lib/overflow_kunit.c > > > > +++ b/lib/overflow_kunit.c > > > > @@ -1,7 +1,7 @@ > > > > // SPDX-License-Identifier: GPL-2.0 OR MIT > > > > /* > > > > * Test cases for arithmetic overflow checks. See: > > > > - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests > > > > + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst > > > > > > Oh, I thought I had sent a patch out for this. > > > The rewritten version of the patch is > > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/run_wrapper.html > > > That's what I was intending to rewrite this line to point to. > > > > > > But if people like a Documentation/ path to start.rst instead, that also works. > > > > > > Daniel > > > > You are absolutely right! You did send and I wasn't aware, sorry. > > https://lore.kernel.org/all/20220603195626.121922-1-dlatypov@google.com/ > > I guess it stalled after that discussion about *where* it should be applied, > > I got a green flag in IRC and didn't do my due diligence carefully, > > just tried to find pending patches at linux-kselftest which wasn't > > CC'd > > Oh right, it was that series where I didn't cc linux-kselftest. > That was my bad, sorry. > > But I had forgotten to include a patch in that series to update this > file still, afaict. > I could revive that series and add on a version of this patch, if we want? > > Daniel I can bring your patches in my V3, if you don't mind! :D
On Mon, Aug 22, 2022 at 4:12 PM Tales <tales.aparecida@gmail.com> wrote: > > I can bring your patches in my V3, if you don't mind! :D Sounds good to me! Thanks a lot for picking this up. Daniel
diff --git a/lib/overflow_kunit.c b/lib/overflow_kunit.c index 7e3e43679b73..78075106c0df 100644 --- a/lib/overflow_kunit.c +++ b/lib/overflow_kunit.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 OR MIT /* * Test cases for arithmetic overflow checks. See: - * https://www.kernel.org/doc/html/latest/dev-tools/kunit/kunit-tool.html#configuring-building-and-running-tests + * "Running tests with kunit_tool" at Documentation/dev-tools/kunit/start.rst * ./tools/testing/kunit/kunit.py run overflow [--raw_output] */ #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Replace URL with an updated path to the full Documentation page Signed-off-by: Tales Aparecida <tales.aparecida@gmail.com> --- lib/overflow_kunit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)