| Message ID | 20220824104040.17527-2-arinc.unal@arinc9.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | completely rework mediatek,mt7530 binding | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Wed, 24 Aug 2022 13:40:34 +0300, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Stretch descriptions up to the 80 character limit. > - Remove lists for single items. > - Remove quotes from $ref: "dsa.yaml#". > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > .../bindings/net/dsa/mediatek,mt7530.yaml | 39 +++++++++++-------- > 1 file changed, 23 insertions(+), 16 deletions(-) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
> On 24 Aug 2022, at 22:44, Rob Herring <robh@kernel.org> wrote: > > On Wed, 24 Aug 2022 13:40:34 +0300, Arınç ÜNAL wrote: >> Make trivial changes on the binding. >> >> - Update title to include MT7531 switch. >> - Add me as a maintainer. List maintainers in alphabetical order by first >> name. >> - Add description to compatible strings. >> - Stretch descriptions up to the 80 character limit. >> - Remove lists for single items. >> - Remove quotes from $ref: "dsa.yaml#". >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- >> .../bindings/net/dsa/mediatek,mt7530.yaml | 39 +++++++++++-------- >> 1 file changed, 23 insertions(+), 16 deletions(-) >> > > > Please add Acked-by/Reviewed-by tags when posting new versions. However, > there's no need to repost patches *only* to add the tags. The upstream > maintainer will do that for acks received on the version they apply. > > If a tag was not added on purpose, please state why and what changed. Thanks for the info. This is what I did on the composition for this patch series. Arınç
On 24/08/2022 13:40, Arınç ÜNAL wrote: > Make trivial changes on the binding. > > - Update title to include MT7531 switch. > - Add me as a maintainer. List maintainers in alphabetical order by first > name. > - Add description to compatible strings. > - Stretch descriptions up to the 80 character limit. > - Remove lists for single items. > - Remove quotes from $ref: "dsa.yaml#". Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml index 17ab6c69ecc7..4dc85a1cdfb5 100644 --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml @@ -4,12 +4,13 @@ $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Mediatek MT7530 Ethernet switch +title: Mediatek MT7530 and MT7531 Ethernet Switches maintainers: - - Sean Wang <sean.wang@mediatek.com> + - Arınç ÜNAL <arinc.unal@arinc9.com> - Landen Chao <Landen.Chao@mediatek.com> - DENG Qingfang <dqfext@gmail.com> + - Sean Wang <sean.wang@mediatek.com> description: | Port 5 of mt7530 and mt7621 switch is muxed between: @@ -61,10 +62,18 @@ description: | properties: compatible: - enum: - - mediatek,mt7530 - - mediatek,mt7531 - - mediatek,mt7621 + oneOf: + - description: + Standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC + const: mediatek,mt7530 + + - description: + Standalone MT7531 + const: mediatek,mt7531 + + - description: + Multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs + const: mediatek,mt7621 reg: maxItems: 1 @@ -79,7 +88,7 @@ properties: gpio-controller: type: boolean description: - if defined, MT7530's LED controller will run on GPIO mode. + If defined, MT7530's LED controller will run on GPIO mode. "#interrupt-cells": const: 1 @@ -92,8 +101,8 @@ properties: io-supply: description: Phandle to the regulator node necessary for the I/O power. - See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt - for details for the regulator setup on these boards. + See Documentation/devicetree/bindings/regulator/mt6323-regulator.txt for + details for the regulator setup on these boards. mediatek,mcm: type: boolean @@ -110,8 +119,8 @@ properties: resets: description: - Phandle pointing to the system reset controller with line index for - the ethsys. + Phandle pointing to the system reset controller with line index for the + ethsys. maxItems: 1 patternProperties: @@ -136,8 +145,7 @@ patternProperties: - if: properties: label: - items: - - const: cpu + const: cpu then: required: - reg @@ -148,7 +156,7 @@ required: - reg allOf: - - $ref: "dsa.yaml#" + - $ref: dsa.yaml# - if: required: - mediatek,mcm @@ -163,8 +171,7 @@ allOf: - if: properties: compatible: - items: - - const: mediatek,mt7530 + const: mediatek,mt7530 then: required: - core-supply
Make trivial changes on the binding. - Update title to include MT7531 switch. - Add me as a maintainer. List maintainers in alphabetical order by first name. - Add description to compatible strings. - Stretch descriptions up to the 80 character limit. - Remove lists for single items. - Remove quotes from $ref: "dsa.yaml#". Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- .../bindings/net/dsa/mediatek,mt7530.yaml | 39 +++++++++++-------- 1 file changed, 23 insertions(+), 16 deletions(-)