[v6,03/10] parallels: Fix data_end after out-of-image check

Commit Message

Alexander Ivanov Aug. 25, 2022, 2:31 p.m. UTC

Set data_end to the end of the last cluster inside the image.
In such a way we can be shure that corrupted offsets in the BAT
can't affect on the image size.

Signed-off-by: Alexander Ivanov <[e-mail]>
---
 block/parallels.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Denis V. Lunev Aug. 26, 2022, 1:01 p.m. UTC | #1

On 25.08.2022 16:31, Alexander Ivanov wrote:
> Set data_end to the end of the last cluster inside the image.
> In such a way we can be shure that corrupted offsets in the BAT
s/shure/sure/
> can't affect on the image size.
>
> Signed-off-by: Alexander Ivanov <[e-mail]>
> ---
>   block/parallels.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/block/parallels.c b/block/parallels.c
> index 7e8cdbbc3a..c1ff8bb5f0 100644
> --- a/block/parallels.c
> +++ b/block/parallels.c
> @@ -514,6 +514,8 @@ static int coroutine_fn parallels_co_check(BlockDriverState *bs,
>           }
>       }
>   
> +    s->data_end = res->image_end_offset >> BDRV_SECTOR_BITS;
> +
>   out:
>       qemu_co_mutex_unlock(&s->lock);
>       return ret;
Reviewed-by: Denis V. Lunev <[e-mail]>

Patch

diff --git a/block/parallels.c b/block/parallels.c
index 7e8cdbbc3a..c1ff8bb5f0 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -514,6 +514,8 @@  static int coroutine_fn parallels_co_check(BlockDriverState *bs,
         }
     }
 
+    s->data_end = res->image_end_offset >> BDRV_SECTOR_BITS;
+
 out:
     qemu_co_mutex_unlock(&s->lock);
     return ret;