mbox series

[v2,0/3] Drop version numbers from firmware files

Message ID 20220826030553.2611574-1-John.C.Harrison@Intel.com (mailing list archive)
Headers show
Series Drop version numbers from firmware files | expand

Message

John Harrison Aug. 26, 2022, 3:05 a.m. UTC 
From: John Harrison <John.C.Harrison@Intel.com>

Upstream direction is to include the bare minimum of version numbers
in firmware files and to replace them in the repo rather than
accumulating them. For HuC, that means going completely versionless.
For GuC, the major version needs to be kept as that indicates a break
in backwards compatibility with the KMD.

v2: Fix a bunch of issues and add better documentation (some found in
code review by Daniele, other through more thorough testing).

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
CC: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>


John Harrison (3):
  drm/i915/uc: Support for version reduced and multiple firmware files
  drm/i915/uc: Add patch level version number support
  drm/i915/uc: Enable version reduced firmware files for newest
    platforms

 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  10 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   8 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c      | 468 ++++++++++++------
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h      |  39 +-
 drivers/gpu/drm/i915/gt/uc/intel_uc_fw_abi.h  |   8 +-
 drivers/gpu/drm/i915/i915_gpu_error.c         |  16 +-
 6 files changed, 358 insertions(+), 191 deletions(-)

Comments

John Harrison Aug. 26, 2022, 3:43 p.m. UTC | #1 
On 8/25/2022 20:49, Patchwork wrote:
> Project List - Patchwork *Patch Details*
> *Series:* 	Drop version numbers from firmware files (rev3)
> *URL:* 	https://patchwork.freedesktop.org/series/107340/
> *State:* 	success
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/index.html
>
>
>   CI Bug Log - changes from CI_DRM_12029 -> Patchwork_107340v3
>
>
>     Summary
>
> *SUCCESS*
>
> No regressions found.
>
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/index.html
>
>
>     Participating hosts (33 -> 32)
>
> Missing (1): fi-kbl-soraka
>
>
>     Possible new issues
>
> Here are the unknown changes that may have been introduced in 
> Patchwork_107340v3:
>
>
>       IGT changes
>
>
>         Suppressed
>
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
>
>  *
>
>     igt@i915_module_load@load:
>
>      o
>
>         {bat-dg2-9}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/bat-dg2-9/igt@i915_module_load@load.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/bat-dg2-9/igt@i915_module_load@load.html>
>
>      o
>
>         {bat-dg2-8}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/bat-dg2-8/igt@i915_module_load@load.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/bat-dg2-8/igt@i915_module_load@load.html>
>
These are expected. Patch 3/3 sets DG2 to only allow the new style file 
name and the new files are not yet pushed to the repo. This was 
intentional to see that the load would fail as expected.

The DG1, ADL-S and RPL-S results shows that it tried to load the new 
style files, failed to find them (as expected), dropped back to the old 
style and successfully loaded those and ran with them:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/bat-dg1-6/igt@i915_module_load@load.html
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-adl-ddr5/igt@i915_module_load@load.html
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/bat-rpls-1/igt@i915_module_load@load.html

Unfortunately, the ADL-P and ADL-M results are invalid because they are 
apparently failing to run due to IOMMU issues that do not appear to be 
i915 related. KBL and APL are showing the same failures.

John.


>  *
>      o
>  *
>
>     igt@i915_selftest@live@ring_submission:
>
>       o {fi-ehl-2}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/fi-ehl-2/igt@i915_selftest@live@ring_submission.html>
>         -> INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-ehl-2/igt@i915_selftest@live@ring_submission.html>
>
>
>     Known issues
>
> Here are the changes found in Patchwork_107340v3 that come from known 
> issues:
>
>
>       IGT changes
>
>
>         Issues hit
>
>  *
>
>     igt@i915_selftest@live@hangcheck:
>
>      o
>
>         fi-hsw-4770: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html>
>         -> INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html>
>         (i915#4785 <https://gitlab.freedesktop.org/drm/intel/issues/4785>)
>
>      o
>
>         fi-hsw-g3258: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html>
>         -> INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html>
>         (i915#3303
>         <https://gitlab.freedesktop.org/drm/intel/issues/3303> /
>         i915#4785 <https://gitlab.freedesktop.org/drm/intel/issues/4785>)
>
>  *
>
>     igt@i915_selftest@live@requests:
>
>       o fi-pnv-d510: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12029/fi-pnv-d510/igt@i915_selftest@live@requests.html>
>         -> DMESG-FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-pnv-d510/igt@i915_selftest@live@requests.html>
>         (i915#4528 <https://gitlab.freedesktop.org/drm/intel/issues/4528>)
>  *
>
>     igt@runner@aborted:
>
>      o
>
>         fi-pnv-d510: NOTRUN -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-pnv-d510/igt@runner@aborted.html>
>         (fdo#109271
>         <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
>         i915#2403
>         <https://gitlab.freedesktop.org/drm/intel/issues/2403> /
>         i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>)
>
>      o
>
>         fi-hsw-g3258: NOTRUN -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107340v3/fi-hsw-g3258/igt@runner@aborted.html>
>         (fdo#109271
>         <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
>         i915#4312
>         <https://gitlab.freedesktop.org/drm/intel/issues/4312> /
>         i915#6246 <https://gitlab.freedesktop.org/drm/intel/issues/6246>)
>
> {name}: This element is suppressed. This means it is ignored when 
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
>     Build changes
>
>   * Linux: CI_DRM_12029 -> Patchwork_107340v3
>
> CI-20190529: 20190529
> CI_DRM_12029: 77ebe479d84890d78217fb7a6b556f7de71866f3 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6636: 1298b5f0e1b3e010657ffba41d2e775fab028e08 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_107340v3: 77ebe479d84890d78217fb7a6b556f7de71866f3 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
>       Linux commits
>
> 9f6445fdae59 drm/i915/uc: Enable version reduced firmware files for 
> newest platforms
> 29eb7ecd836a drm/i915/uc: Add patch level version number support
> 5636c16c1a4a drm/i915/uc: Support for version reduced and multiple 
> firmware files
>