| Message ID | 20220802175755.6530-11-sudip.mukherjee@sifive.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for enhanced SPI for Designware SPI controllers | expand |
On 02/08/2022 19:57, Sudip Mukherjee wrote: > From: Ben Dooks <ben.dooks@sifive.com> > > Add new snps,dw-ssi-1.03a version to the bindings. Use subject prefix properly identifying files. I do not have enough of time to check 200 patches everyday if they touch or do not touch bindings. > > Signed-off-by: Ben Dooks <ben.dooks@sifive.com> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@sifive.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index 37c3c272407d..35aa04a85813 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -45,6 +45,7 @@ properties: > enum: > - snps,dw-apb-ssi > - snps,dwc-ssi-1.01a > + - snps,dwc-ssi-1.03a With subject fixes: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Tue, Aug 02, 2022 at 06:57:54PM +0100, Sudip Mukherjee wrote: > From: Ben Dooks <ben.dooks@sifive.com> > > Add new snps,dw-ssi-1.03a version to the bindings. > > Signed-off-by: Ben Dooks <ben.dooks@sifive.com> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@sifive.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index 37c3c272407d..35aa04a85813 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -45,6 +45,7 @@ properties: > enum: > - snps,dw-apb-ssi > - snps,dwc-ssi-1.01a > + - snps,dwc-ssi-1.03a There is no point in having the IP-core versions used in the compatible string. The controller version is retrieved from the device CSR. Just add new generic compatible string "snps,dw-ahb-ssi" and use it to identify your device. -Sergey > - description: Microsemi Ocelot/Jaguar2 SoC SPI Controller > items: > - enum: > -- > 2.30.2 >
On Tue, Aug 02, 2022 at 06:57:54PM +0100, Sudip Mukherjee wrote: > From: Ben Dooks <ben.dooks@sifive.com> > > Add new snps,dw-ssi-1.03a version to the bindings. > > Signed-off-by: Ben Dooks <ben.dooks@sifive.com> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@sifive.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index 37c3c272407d..35aa04a85813 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -45,6 +45,7 @@ properties: > enum: > - snps,dw-apb-ssi > - snps,dwc-ssi-1.01a > + - snps,dwc-ssi-1.03a Just add the "snps,dw-ahb-ssi" compatible string instead. -Sergey > - description: Microsemi Ocelot/Jaguar2 SoC SPI Controller > items: > - enum: > -- > 2.30.2 >
diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml index 37c3c272407d..35aa04a85813 100644 --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml @@ -45,6 +45,7 @@ properties: enum: - snps,dw-apb-ssi - snps,dwc-ssi-1.01a + - snps,dwc-ssi-1.03a - description: Microsemi Ocelot/Jaguar2 SoC SPI Controller items: - enum: