| Message ID | 20220823001136.10944-1-afd@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/4] arm64: dts: ti: k3-am65-main: Disable RNG node | expand |
On 23/08/22 05:41, Andrew Davis wrote: > The hardware random number generator is used by OP-TEE and is access is > denied to other users with SoC level bus firewalls. Any access to this > device from Linux will result in firewall errors. > > We could remove this node, but it is still valid device description, > and it is possible it could be re-enabled in the bootloader if OP-TEE > is not used. So only disable this node for now. > > Signed-off-by: Andrew Davis <afd@ti.com> > --- > > Changes from v1: > - Added comment in DT > - Explained why it is only disabled in commit message > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 8919fede3cd7..b3e714e1abed 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -127,6 +127,7 @@ rng: rng@4e10000 { > reg = <0x0 0x4e10000 0x0 0x7d>; > interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; > clocks = <&k3_clks 136 1>; > + status = "disabled"; /* Used by OP-TEE */ > }; > }; > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
Hi Andrew Davis, On Mon, 22 Aug 2022 19:11:33 -0500, Andrew Davis wrote: > The hardware random number generator is used by OP-TEE and is access is > denied to other users with SoC level bus firewalls. Any access to this > device from Linux will result in firewall errors. > > We could remove this node, but it is still valid device description, > and it is possible it could be re-enabled in the bootloader if OP-TEE > is not used. So only disable this node for now. > > [...] I have applied the following to branch master on [1]. Thank you! [1/4] arm64: dts: ti: k3-am65-main: Disable RNG node commit: 1ad4669b4bbe6b72784acdb5b24f72b22ad8f1d1 [2/4] arm64: dts: ti: k3-am65-main: Move SA2UL to unused PSI-L thread ID commit: 530eaa573a33fdd86725fdd2b979cbbbc539d47c [3/4] arm64: dts: ti: k3-am65-main: Do not exclusively claim SA2UL commit: 49611f43e035f30be685fcf7468f23e85ce2ee06 [4/4] arm64: dts: ti: k3-j7200-mcu-wakeup: Add SA2UL node commit: d683a73980a61cc5d8abea7f3f996028e64e9144 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git -- Vignesh
diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 8919fede3cd7..b3e714e1abed 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -127,6 +127,7 @@ rng: rng@4e10000 { reg = <0x0 0x4e10000 0x0 0x7d>; interrupts = <GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>; clocks = <&k3_clks 136 1>; + status = "disabled"; /* Used by OP-TEE */ }; };
The hardware random number generator is used by OP-TEE and is access is denied to other users with SoC level bus firewalls. Any access to this device from Linux will result in firewall errors. We could remove this node, but it is still valid device description, and it is possible it could be re-enabled in the bootloader if OP-TEE is not used. So only disable this node for now. Signed-off-by: Andrew Davis <afd@ti.com> --- Changes from v1: - Added comment in DT - Explained why it is only disabled in commit message arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 + 1 file changed, 1 insertion(+)