diff mbox series

[v5,bpf-next,3/6] selftests: xsk: increase chars for interface name

Message ID 20220830135604.10173-4-maciej.fijalkowski@intel.com (mailing list archive)
State Superseded
Delegated to: BPF
Headers show
Series selftests: xsk: real device testing support | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for bpf-next
netdev/apply fail Patch does not apply to bpf-next
bpf/vmtest-bpf-next-PR fail merge-conflict

Commit Message

Maciej Fijalkowski Aug. 30, 2022, 1:56 p.m. UTC
So that "enp240s0f0" or such name can be used against xskxceiver.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
 tools/testing/selftests/bpf/xskxceiver.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Magnus Karlsson Aug. 31, 2022, 8:55 a.m. UTC | #1
On Tue, Aug 30, 2022 at 4:00 PM Maciej Fijalkowski
<maciej.fijalkowski@intel.com> wrote:
>
> So that "enp240s0f0" or such name can be used against xskxceiver.

Why not bump them up to 16 why you are at it, including
MAX_INTERFACES_NAMESPACE_CHARS? In any case:

Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>

> Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> ---
>  tools/testing/selftests/bpf/xskxceiver.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/xskxceiver.h b/tools/testing/selftests/bpf/xskxceiver.h
> index 8d1c31f127e7..12bfa6e463d3 100644
> --- a/tools/testing/selftests/bpf/xskxceiver.h
> +++ b/tools/testing/selftests/bpf/xskxceiver.h
> @@ -29,7 +29,7 @@
>  #define TEST_FAILURE -1
>  #define TEST_CONTINUE 1
>  #define MAX_INTERFACES 2
> -#define MAX_INTERFACE_NAME_CHARS 7
> +#define MAX_INTERFACE_NAME_CHARS 10
>  #define MAX_INTERFACES_NAMESPACE_CHARS 10
>  #define MAX_SOCKETS 2
>  #define MAX_TEST_NAME_SIZE 32
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/xskxceiver.h b/tools/testing/selftests/bpf/xskxceiver.h
index 8d1c31f127e7..12bfa6e463d3 100644
--- a/tools/testing/selftests/bpf/xskxceiver.h
+++ b/tools/testing/selftests/bpf/xskxceiver.h
@@ -29,7 +29,7 @@ 
 #define TEST_FAILURE -1
 #define TEST_CONTINUE 1
 #define MAX_INTERFACES 2
-#define MAX_INTERFACE_NAME_CHARS 7
+#define MAX_INTERFACE_NAME_CHARS 10
 #define MAX_INTERFACES_NAMESPACE_CHARS 10
 #define MAX_SOCKETS 2
 #define MAX_TEST_NAME_SIZE 32