[v2,intel-net,0/2] ice: xsk: ZC changes

Message

Maciej Fijalkowski Aug. 30, 2022, 12:51 p.m. UTC

Hi,

this set consists of two fixes to issues that were either pointed out on
indirectly (John was reviewing AF_XDP selftests that were testing ice's
ZC support) mailing list or were directly reported by customers.

First patch allows user space to see done descriptor in CQ even after a
single frame being transmitted and second patch removes the need for
having HW rings sized to power of 2 number of descriptors when used
against AF_XDP.

I also forgot to mention that due to the current Tx cleaning algorithm,
4k HW ring was broken and these two patches bring it back to life, so we
kill two birds with one stone.

v2:
- remove doubled fixes tag from patch 1
- add Alasdair to CC as he reported need for bigger rings used with
  AF_XDP ZC

Thanks!
Maciej

Maciej Fijalkowski (2):
  ice: xsk: change batched Tx descriptor cleaning
  ice: xsk: drop power of 2 ring size restriction for AF_XDP

 drivers/net/ethernet/intel/ice/ice_txrx.c |   2 +-
 drivers/net/ethernet/intel/ice/ice_xsk.c  | 165 +++++++++-------------
 drivers/net/ethernet/intel/ice/ice_xsk.h  |   7 +-
 3 files changed, 72 insertions(+), 102 deletions(-)

Comments

Tony Nguyen Aug. 31, 2022, 8:11 p.m. UTC | #1

On 8/30/2022 5:51 AM, Maciej Fijalkowski wrote:
> Hi,
> 
> this set consists of two fixes to issues that were either pointed out on
> indirectly (John was reviewing AF_XDP selftests that were testing ice's
> ZC support) mailing list or were directly reported by customers.
> 
> First patch allows user space to see done descriptor in CQ even after a
> single frame being transmitted and second patch removes the need for
> having HW rings sized to power of 2 number of descriptors when used
> against AF_XDP.
> 
> I also forgot to mention that due to the current Tx cleaning algorithm,
> 4k HW ring was broken and these two patches bring it back to life, so we
> kill two birds with one stone.

Hi Maciej,

This isn't applying to net-queue.

Thanks,
Tony