| Message ID | 20220831092919.146149-1-shaozhengchao@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75aad41ac3cf3d8d1d2bdbcaf0f662402c1e6c02 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: sched: etf: remove true check in etf_enable_offload() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Single patches do not need cover letters |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 9 of 9 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
Zhengchao Shao <shaozhengchao@huawei.com> writes: > etf_enable_offload() is only called when q->offload is false in > etf_init(). So remove true check in etf_enable_offload(). > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Wed, 31 Aug 2022 17:29:19 +0800 you wrote: > etf_enable_offload() is only called when q->offload is false in > etf_init(). So remove true check in etf_enable_offload(). > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> > --- > net/sched/sch_etf.c | 3 --- > 1 file changed, 3 deletions(-) Here is the summary with links: - [net-next] net: sched: etf: remove true check in etf_enable_offload() https://git.kernel.org/netdev/net-next/c/75aad41ac3cf You are awesome, thank you!
diff --git a/net/sched/sch_etf.c b/net/sched/sch_etf.c index d96103b0e2bf..61d1f0e32cf3 100644 --- a/net/sched/sch_etf.c +++ b/net/sched/sch_etf.c @@ -323,9 +323,6 @@ static int etf_enable_offload(struct net_device *dev, struct etf_sched_data *q, struct tc_etf_qopt_offload etf = { }; int err; - if (q->offload) - return 0; - if (!ops->ndo_setup_tc) { NL_SET_ERR_MSG(extack, "Specified device does not support ETF offload"); return -EOPNOTSUPP;
etf_enable_offload() is only called when q->offload is false in etf_init(). So remove true check in etf_enable_offload(). Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> --- net/sched/sch_etf.c | 3 --- 1 file changed, 3 deletions(-)