mbox series

[net-next,0/2] net: sched: remove redundant resource cleanup when init() fails

Message ID 20220830005638.276584-1-shaozhengchao@huawei.com (mailing list archive)
Headers show
Series net: sched: remove redundant resource cleanup when init() fails | expand

Message

shaozhengchao Aug. 30, 2022, 12:56 a.m. UTC
qdisc_create() calls .init() to initialize qdisc. If the initialization
fails, qdisc_create() will call .destroy() to release resources.

Zhengchao Shao (2):
  net: sched: fq_codel: remove redundant resource cleanup in
    fq_codel_init()
  net: sched: htb: remove redundant resource cleanup in htb_init()

 net/sched/sch_fq_codel.c | 17 ++++-------------
 net/sched/sch_htb.c      | 36 +++++++++---------------------------
 2 files changed, 13 insertions(+), 40 deletions(-)

Comments

Jakub Kicinski Sept. 1, 2022, 2:25 a.m. UTC | #1
On Tue, 30 Aug 2022 08:56:36 +0800 Zhengchao Shao wrote:
> qdisc_create() calls .init() to initialize qdisc. If the initialization
> fails, qdisc_create() will call .destroy() to release resources.

Looks like this set does not apply cleanly, please rebase on top 
of latest net-next/main and repost.