| Message ID | 20220901015130.419307-1-zhangxuezhi3@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] scsi: csiostor: convert sysfs snprintf to sysfs_emit | expand |
On 9/1/22 10:51, Xuezhi Zhang wrote: > From: Xuezhi Zhang <zhangxuezhi1@coolpad.com> > > Follow the advice of the Documentation/filesystems/sysfs.rst > and show() should only use sysfs_emit() or sysfs_emit_at() > when formatting the value to be returned to user space. > > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com> Looks OK. Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com> > --- > v2: delete 'else' and extra space. > v3: delete extra configs in patch v2 > and use a new changelog. > --- > drivers/scsi/csiostor/csio_scsi.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c > index 9aafe0002ab1..05e1a63e00c3 100644 > --- a/drivers/scsi/csiostor/csio_scsi.c > +++ b/drivers/scsi/csiostor/csio_scsi.c > @@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev, > struct csio_hw *hw = csio_lnode_to_hw(ln); > > if (csio_is_hw_ready(hw)) > - return snprintf(buf, PAGE_SIZE, "ready\n"); > - else > - return snprintf(buf, PAGE_SIZE, "not ready\n"); > + return sysfs_emit(buf, "ready\n"); > + > + return sysfs_emit(buf, "not ready\n"); > } > > /* Device reset */ > @@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev, > { > struct csio_lnode *ln = shost_priv(class_to_shost(dev)); > > - return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level); > + return sysfs_emit(buf, "%x\n", ln->params.log_level); > } > > /* Store debug level */ > @@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev, > { > struct csio_lnode *ln = shost_priv(class_to_shost(dev)); > > - return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes); > + return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes); > } > > static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL);
diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c index 9aafe0002ab1..05e1a63e00c3 100644 --- a/drivers/scsi/csiostor/csio_scsi.c +++ b/drivers/scsi/csiostor/csio_scsi.c @@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev, struct csio_hw *hw = csio_lnode_to_hw(ln); if (csio_is_hw_ready(hw)) - return snprintf(buf, PAGE_SIZE, "ready\n"); - else - return snprintf(buf, PAGE_SIZE, "not ready\n"); + return sysfs_emit(buf, "ready\n"); + + return sysfs_emit(buf, "not ready\n"); } /* Device reset */ @@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev, { struct csio_lnode *ln = shost_priv(class_to_shost(dev)); - return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level); + return sysfs_emit(buf, "%x\n", ln->params.log_level); } /* Store debug level */ @@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev, { struct csio_lnode *ln = shost_priv(class_to_shost(dev)); - return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes); + return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes); } static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL);