| Message ID | 20220829065044.1736-1-anand@edgeble.ai (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: net: rockchip-dwmac: add rv1126 compatible string | expand |
Am Montag, 29. August 2022, 08:50:41 CEST schrieb Anand Moon: > Add compatible string for RV1126 gmac, and constrain it to > be compatible with Synopsys dwmac 4.20a. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > Signed-off-by: Anand Moon <anand@edgeble.ai> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 083623c8d718..346e248a6ba5 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -26,6 +26,7 @@ select: > - rockchip,rk3399-gmac > - rockchip,rk3568-gmac > - rockchip,rv1108-gmac > + - rockchip,rv1126-gmac > required: > - compatible Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On 29/08/2022 09:50, Anand Moon wrote: > Add compatible string for RV1126 gmac, and constrain it to > be compatible with Synopsys dwmac 4.20a. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > Signed-off-by: Anand Moon <anand@edgeble.ai> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 083623c8d718..346e248a6ba5 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -26,6 +26,7 @@ select: > - rockchip,rk3399-gmac > - rockchip,rk3568-gmac > - rockchip,rv1108-gmac > + - rockchip,rv1126-gmac That's not a complete change. What about the other place listing compatibles? Did you test the bindings on your DTS? Best regards, Krzysztof
On Mon, 29 Aug 2022 at 12:23, Anand Moon <anand@edgeble.ai> wrote: > > Add compatible string for RV1126 gmac, and constrain it to > be compatible with Synopsys dwmac 4.20a. > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > Signed-off-by: Anand Moon <anand@edgeble.ai> > --- > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index 083623c8d718..346e248a6ba5 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -26,6 +26,7 @@ select: > - rockchip,rk3399-gmac > - rockchip,rk3568-gmac > - rockchip,rv1108-gmac > + - rockchip,rv1126-gmac it needs to be in the properties menu as well.
Hi Krzysztof, On Tue, 30 Aug 2022 at 15:21, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 29/08/2022 09:50, Anand Moon wrote: > > Add compatible string for RV1126 gmac, and constrain it to > > be compatible with Synopsys dwmac 4.20a. > > > > Signed-off-by: Jagan Teki <jagan@edgeble.ai> > > Signed-off-by: Anand Moon <anand@edgeble.ai> > > --- > > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > index 083623c8d718..346e248a6ba5 100644 > > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > > @@ -26,6 +26,7 @@ select: > > - rockchip,rk3399-gmac > > - rockchip,rk3568-gmac > > - rockchip,rv1108-gmac > > + - rockchip,rv1126-gmac > > That's not a complete change. What about the other place listing > compatibles? Did you test the bindings on your DTS? > Yes, I missed the properties menu, will update it in the next version. > > Best regards, > Krzysztof Thanks -Anand
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index 083623c8d718..346e248a6ba5 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -26,6 +26,7 @@ select: - rockchip,rk3399-gmac - rockchip,rk3568-gmac - rockchip,rv1108-gmac + - rockchip,rv1126-gmac required: - compatible