| Message ID | 20220826184144.605605-3-paul.kocialkowski@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Allwinner A31/A83T MIPI CSI-2 and A31 ISP / ISP Driver | expand |
Hi Paul, Thank you for the patch. On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote: > Some Allwinner devices come with an Image Signal Processor (ISP) that > allows processing camera data to produce good-looking images, > especially from raw bayer representations. > > The ISP does not have a dedicated capture path: it is fed directly by > one of the CSI controllers, which can be selected at run-time. > > Represent this possibility as a graph connection between the CSI > controller and the ISP in the device-tree bindings. > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > Acked-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > index 8551c4a711dc..54eb80e517e3 100644 > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > @@ -73,6 +73,10 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > description: MIPI CSI-2 bridge input port > > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: ISP output port > + I'd write "Output port to the ISP" to make it clearer. Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > anyOf: > - required: > - port@0
Hi Laurent, On Sat 27 Aug 22, 01:29, Laurent Pinchart wrote: > Hi Paul, > > Thank you for the patch. Thanks for the review! > On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote: > > Some Allwinner devices come with an Image Signal Processor (ISP) that > > allows processing camera data to produce good-looking images, > > especially from raw bayer representations. > > > > The ISP does not have a dedicated capture path: it is fed directly by > > one of the CSI controllers, which can be selected at run-time. > > > > Represent this possibility as a graph connection between the CSI > > controller and the ISP in the device-tree bindings. > > > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > > Acked-by: Rob Herring <robh@kernel.org> > > --- > > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > index 8551c4a711dc..54eb80e517e3 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > > @@ -73,6 +73,10 @@ properties: > > $ref: /schemas/graph.yaml#/properties/port > > description: MIPI CSI-2 bridge input port > > > > + port@2: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: ISP output port > > + > > I'd write "Output port to the ISP" to make it clearer. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Agreed, thanks! Paul > > anyOf: > > - required: > > - port@0 > > -- > Regards, > > Laurent Pinchart
diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml index 8551c4a711dc..54eb80e517e3 100644 --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml @@ -73,6 +73,10 @@ properties: $ref: /schemas/graph.yaml#/properties/port description: MIPI CSI-2 bridge input port + port@2: + $ref: /schemas/graph.yaml#/properties/port + description: ISP output port + anyOf: - required: - port@0