[0/2] TI-Nspire cleanups

Message

Andrew Davis Aug. 22, 2022, 11:20 p.m. UTC

Hello all,

I don't have the hardware to test this (yes I know who my current
employer is), but it does look right and this lets us remove the rest
of mach-nspire/ without losing any functionality.
Does anyone have one of these to test with?

The second patch removes a couple defines that do not seem to have ever
been used, but if one want to implement it, then it should be a simple
generic syscon DT node.

Thanks,
Andrew

Andrew Davis (2):
  ARM: nspire: Use syscon-reboot to handle restart
  ARM: nspire: Remove unused header file mmio.h

 arch/arm/boot/dts/nspire.dtsi |  7 ++++
 arch/arm/mach-nspire/Kconfig  |  2 ++
 arch/arm/mach-nspire/mmio.h   | 16 ----------
 arch/arm/mach-nspire/nspire.c | 60 +++++++++++------------------------
 4 files changed, 27 insertions(+), 58 deletions(-)
 delete mode 100644 arch/arm/mach-nspire/mmio.h
 rewrite arch/arm/mach-nspire/nspire.c (61%)

Comments

Daniel Tang Aug. 23, 2022, 9:16 a.m. UTC | #1

I've CC'd in Fabian, who has previously been able to assist testing
kernel patches for this platform.


On Tue, 23 Aug 2022 at 09:20, Andrew Davis <[e-mail]> wrote:
>
> Hello all,
>
> I don't have the hardware to test this (yes I know who my current
> employer is), but it does look right and this lets us remove the rest
> of mach-nspire/ without losing any functionality.
> Does anyone have one of these to test with?
>
> The second patch removes a couple defines that do not seem to have ever
> been used, but if one want to implement it, then it should be a simple
> generic syscon DT node.
>
> Thanks,
> Andrew
>
> Andrew Davis (2):
>   ARM: nspire: Use syscon-reboot to handle restart
>   ARM: nspire: Remove unused header file mmio.h
>
>  arch/arm/boot/dts/nspire.dtsi |  7 ++++
>  arch/arm/mach-nspire/Kconfig  |  2 ++
>  arch/arm/mach-nspire/mmio.h   | 16 ----------
>  arch/arm/mach-nspire/nspire.c | 60 +++++++++++------------------------
>  4 files changed, 27 insertions(+), 58 deletions(-)
>  delete mode 100644 arch/arm/mach-nspire/mmio.h
>  rewrite arch/arm/mach-nspire/nspire.c (61%)
>
> --
> 2.36.1
>

Fabian Vogt Sept. 1, 2022, 7:38 p.m. UTC | #2

Hi,

Am Dienstag, 23. August 2022, 11:16:17 CEST schrieb Daniel Tang:
> I've CC'd in Fabian, who has previously been able to assist testing
> kernel patches for this platform.
> 
> 
> On Tue, 23 Aug 2022 at 09:20, Andrew Davis <[e-mail]> wrote:
> >
> > Hello all,
> >
> > I don't have the hardware to test this (yes I know who my current
> > employer is), but it does look right and this lets us remove the rest
> > of mach-nspire/ without losing any functionality.
> > Does anyone have one of these to test with?
> >
> > The second patch removes a couple defines that do not seem to have ever
> > been used, but if one want to implement it, then it should be a simple
> > generic syscon DT node.

I applied both patches on current master (c5e4d5e99162) and they work fine in
the emulator (including rebooting). On real HW the kernel does unfortunately
not boot, so I'll have to do some further testing and debugging. The changes
look good to me, so it's probably some other change which broke it though.

Cheers,
Fabian

> > Thanks,
> > Andrew
> >
> > Andrew Davis (2):
> >   ARM: nspire: Use syscon-reboot to handle restart
> >   ARM: nspire: Remove unused header file mmio.h
> >
> >  arch/arm/boot/dts/nspire.dtsi |  7 ++++
> >  arch/arm/mach-nspire/Kconfig  |  2 ++
> >  arch/arm/mach-nspire/mmio.h   | 16 ----------
> >  arch/arm/mach-nspire/nspire.c | 60 +++++++++++------------------------
> >  4 files changed, 27 insertions(+), 58 deletions(-)
> >  delete mode 100644 arch/arm/mach-nspire/mmio.h
> >  rewrite arch/arm/mach-nspire/nspire.c (61%)
> >
> > --
> > 2.36.1
> >