diff mbox series

[1/2] dt-bindings: gpio: rockchip: add clock-names

Message ID 20220901012944.2634398-2-jay.xu@rock-chips.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: gpio: rockchip: add clock-names | expand

Commit Message

Jianqun Xu Sept. 1, 2022, 1:29 a.m. UTC
Add 'clock-names' to the gpio dt node. so the driver could get clocks by
a const char id, this patch names the clock-names as
  - 'bus': the apb clock for cpu to access the gpio controller
  - 'db': the debounce clock for cpu to set debounce clock rate

Since the old dt nodes may have no clock-names, this patch not make them
as part of 'required properties'.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
 .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml        | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Sept. 1, 2022, 11:48 a.m. UTC | #1
On Wed, Aug 31, 2022 at 8:36 PM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
> a const char id, this patch names the clock-names as
>   - 'bus': the apb clock for cpu to access the gpio controller
>   - 'db': the debounce clock for cpu to set debounce clock rate
>
> Since the old dt nodes may have no clock-names, this patch not make them
> as part of 'required properties'.
>
> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
> ---
>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml        | 6 ++++++
>  1 file changed, 6 insertions(+)

Please resend DT patches to the DT list, so they are tested and reviewed.

Rob
Jianqun Xu Sept. 2, 2022, 12:48 a.m. UTC | #2
Hi Rob

--------------
jay.xu@rock-chips.com
>On Wed, Aug 31, 2022 at 8:36 PM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>>
>> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
>> a const char id, this patch names the clock-names as
>>   - 'bus': the apb clock for cpu to access the gpio controller
>>   - 'db': the debounce clock for cpu to set debounce clock rate
>>
>> Since the old dt nodes may have no clock-names, this patch not make them
>> as part of 'required properties'.
>>
>> Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>> ---
>>  .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml        | 6 ++++++
>>  1 file changed, 6 insertions(+)
>
>Please resend DT patches to the DT list, so they are tested and reviewed.
> 
Got it, thanks

>Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index affd823c881d..d43d4c71bebf 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -27,6 +27,12 @@  properties:
       - description: APB interface clock source
       - description: GPIO debounce reference clock source
 
+  clock-names:
+    minItems: 1
+    items:
+      - const: bus
+      - const: db
+
   gpio-ranges: true
 
   gpio-controller: true