mbox series

[V2,0/2] chrontel-ch7033: Add byteswap order option

Message ID 20220902153906.31000-1-macroalpha82@gmail.com (mailing list archive)
Headers show
Series chrontel-ch7033: Add byteswap order option | expand

Message

Chris Morgan Sept. 2, 2022, 3:39 p.m. UTC
From: Chris Morgan <macromorgan@hotmail.com>

This series adds the ability to set the byteswap order in the chrontel
ch7033 driver via an optional devicetree node. This is necessary
because the HDMI DIP of the NTC CHIP requires a byteswap order that
differs from the default value of the driver.

Changes from V1:

 - Updated devicetree documentation to be easier to understand.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

Chris Morgan (2):
  dt-bindings: Add byteswap order to chrontel ch7033
  drm/bridge: chrontel-ch7033: Add byteswap order setting

 .../bindings/display/bridge/chrontel,ch7033.yaml  | 13 +++++++++++++
 drivers/gpu/drm/bridge/chrontel-ch7033.c          | 15 +++++++++++++--
 2 files changed, 26 insertions(+), 2 deletions(-)

Comments

Robert Foss Sept. 2, 2022, 4:21 p.m. UTC | #1
On Fri, 2 Sept 2022 at 17:39, Chris Morgan <macroalpha82@gmail.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> This series adds the ability to set the byteswap order in the chrontel
> ch7033 driver via an optional devicetree node. This is necessary
> because the HDMI DIP of the NTC CHIP requires a byteswap order that
> differs from the default value of the driver.
>
> Changes from V1:
>
>  - Updated devicetree documentation to be easier to understand.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>
> Chris Morgan (2):
>   dt-bindings: Add byteswap order to chrontel ch7033
>   drm/bridge: chrontel-ch7033: Add byteswap order setting
>
>  .../bindings/display/bridge/chrontel,ch7033.yaml  | 13 +++++++++++++
>  drivers/gpu/drm/bridge/chrontel-ch7033.c          | 15 +++++++++++++--
>  2 files changed, 26 insertions(+), 2 deletions(-)
>
> --
> 2.25.1
>

Applied to drm-misc-next.
Laurent Pinchart Sept. 3, 2022, 12:18 a.m. UTC | #2
Hi Rob,

On Fri, Sep 02, 2022 at 06:21:50PM +0200, Robert Foss wrote:
> On Fri, 2 Sept 2022 at 17:39, Chris Morgan <macroalpha82@gmail.com> wrote:
> >
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > This series adds the ability to set the byteswap order in the chrontel
> > ch7033 driver via an optional devicetree node. This is necessary
> > because the HDMI DIP of the NTC CHIP requires a byteswap order that
> > differs from the default value of the driver.
> >
> > Changes from V1:
> >
> >  - Updated devicetree documentation to be easier to understand.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> >
> > Chris Morgan (2):
> >   dt-bindings: Add byteswap order to chrontel ch7033
> >   drm/bridge: chrontel-ch7033: Add byteswap order setting
> >
> >  .../bindings/display/bridge/chrontel,ch7033.yaml  | 13 +++++++++++++
> >  drivers/gpu/drm/bridge/chrontel-ch7033.c          | 15 +++++++++++++--
> >  2 files changed, 26 insertions(+), 2 deletions(-)
> 
> Applied to drm-misc-next.

I've just reviewed the series, and I don't think this is right. Patch
2/2 has a small issue that could be fixed on top, but more importantly,
I don't think this belongs to DT. See the reply to 1/2.