| Message ID | 1661328262-3867-1-git-send-email-jun.li@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend clock | expand |
On 24/08/2022 11:04, Li Jun wrote: > usb suspend clock has a gate shared with usb_root_clk. > > Signed-off-by: Li Jun <jun.li@nxp.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 22-08-24 16:04:21, Li Jun wrote: > usb suspend clock has a gate shared with usb_root_clk. > > Signed-off-by: Li Jun <jun.li@nxp.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > index 9d5cc2ddde89..1417b7b1b7df 100644 > --- a/include/dt-bindings/clock/imx8mp-clock.h > +++ b/include/dt-bindings/clock/imx8mp-clock.h > @@ -324,8 +324,9 @@ > #define IMX8MP_CLK_CLKOUT2_SEL 317 > #define IMX8MP_CLK_CLKOUT2_DIV 318 > #define IMX8MP_CLK_CLKOUT2 319 > +#define IMX8MP_CLK_USB_SUSP 320 > > -#define IMX8MP_CLK_END 320 > +#define IMX8MP_CLK_END 321 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > -- > 2.34.1 >
On 22-08-24 16:04:21, Li Jun wrote: > usb suspend clock has a gate shared with usb_root_clk. > > Signed-off-by: Li Jun <jun.li@nxp.com> Applied both, thanks! > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > index 9d5cc2ddde89..1417b7b1b7df 100644 > --- a/include/dt-bindings/clock/imx8mp-clock.h > +++ b/include/dt-bindings/clock/imx8mp-clock.h > @@ -324,8 +324,9 @@ > #define IMX8MP_CLK_CLKOUT2_SEL 317 > #define IMX8MP_CLK_CLKOUT2_DIV 318 > #define IMX8MP_CLK_CLKOUT2 319 > +#define IMX8MP_CLK_USB_SUSP 320 > > -#define IMX8MP_CLK_END 320 > +#define IMX8MP_CLK_END 321 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > -- > 2.34.1 >
On 22-09-02 21:22:08, Abel Vesa wrote: > On 22-08-24 16:04:21, Li Jun wrote: > > usb suspend clock has a gate shared with usb_root_clk. > > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > Applied both, thanks! As discussed in the thread [1], I dropped this patch from my tree for now. You need to send a new version wil Fixes tag. [1] https://lore.kernel.org/all/YxhxSdDGXfO%2F%2Fbgc@linaro.org/ > > > > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h > > index 9d5cc2ddde89..1417b7b1b7df 100644 > > --- a/include/dt-bindings/clock/imx8mp-clock.h > > +++ b/include/dt-bindings/clock/imx8mp-clock.h > > @@ -324,8 +324,9 @@ > > #define IMX8MP_CLK_CLKOUT2_SEL 317 > > #define IMX8MP_CLK_CLKOUT2_DIV 318 > > #define IMX8MP_CLK_CLKOUT2 319 > > +#define IMX8MP_CLK_USB_SUSP 320 > > > > -#define IMX8MP_CLK_END 320 > > +#define IMX8MP_CLK_END 321 > > > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > > -- > > 2.34.1 > >
Hi Abel, > -----Original Message----- > From: Abel Vesa <abel.vesa@linaro.org> > Sent: Wednesday, September 7, 2022 6:33 PM > To: Jun Li <jun.li@nxp.com> > Cc: abelvesa@kernel.org; mturquette@baylibre.com; sboyd@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de; > festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linux-clk@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org > Subject: Re: [PATCH 1/2] dt-bindings: clocks: imx8mp: Add ID for usb suspend > clock > > On 22-09-02 21:22:08, Abel Vesa wrote: > > On 22-08-24 16:04:21, Li Jun wrote: > > > usb suspend clock has a gate shared with usb_root_clk. > > > > > > Signed-off-by: Li Jun <jun.li@nxp.com> > > > > Applied both, thanks! > > As discussed in the thread [1], I dropped this patch from my tree for now. > You need to send a new version wil Fixes tag. Thanks, I will resend those 2 patches with fix tag. Li Jun > > [1] > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore. > kernel.org%2Fall%2FYxhxSdDGXfO%252F%252Fbgc%40linaro.org%2F&data=05 > %7C01%7Cjun.li%40nxp.com%7Cf62126a63a4442644c9308da90bc54ed%7C686ea1d3b > c2b4c6fa92cd99c5c301635%7C0%7C0%7C637981435790610771%7CUnknown%7CTWFpbG > Zsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3 > D%7C3000%7C%7C%7C&sdata=DRZzC7rKqNexnGN%2F%2FW5LXvhnhRwIN7CLC4KCu9z > fTFA%3D&reserved=0 > > > > > > > > diff --git a/include/dt-bindings/clock/imx8mp-clock.h > > > b/include/dt-bindings/clock/imx8mp-clock.h > > > index 9d5cc2ddde89..1417b7b1b7df 100644 > > > --- a/include/dt-bindings/clock/imx8mp-clock.h > > > +++ b/include/dt-bindings/clock/imx8mp-clock.h > > > @@ -324,8 +324,9 @@ > > > #define IMX8MP_CLK_CLKOUT2_SEL 317 > > > #define IMX8MP_CLK_CLKOUT2_DIV 318 > > > #define IMX8MP_CLK_CLKOUT2 319 > > > +#define IMX8MP_CLK_USB_SUSP 320 > > > > > > -#define IMX8MP_CLK_END 320 > > > +#define IMX8MP_CLK_END 321 > > > > > > #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 > > > #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1 > > > -- > > > 2.34.1 > > >
diff --git a/include/dt-bindings/clock/imx8mp-clock.h b/include/dt-bindings/clock/imx8mp-clock.h index 9d5cc2ddde89..1417b7b1b7df 100644 --- a/include/dt-bindings/clock/imx8mp-clock.h +++ b/include/dt-bindings/clock/imx8mp-clock.h @@ -324,8 +324,9 @@ #define IMX8MP_CLK_CLKOUT2_SEL 317 #define IMX8MP_CLK_CLKOUT2_DIV 318 #define IMX8MP_CLK_CLKOUT2 319 +#define IMX8MP_CLK_USB_SUSP 320 -#define IMX8MP_CLK_END 320 +#define IMX8MP_CLK_END 321 #define IMX8MP_CLK_AUDIOMIX_SAI1_IPG 0 #define IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1 1
usb suspend clock has a gate shared with usb_root_clk. Signed-off-by: Li Jun <jun.li@nxp.com>