| Message ID | 20220903-gpiod_get_from_of_node-remove-v1-0-b29adfb27a6c@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Get rid of [devm_]gpiod_get_from_of_node() public APIs | expand |
On Sun, Sep 04, 2022 at 11:30:52PM -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door to augmenting device tree and ACPI information through secondary > software properties (once we teach gpiolib how to handle those). > > I hope that relevant maintainers will take patches through their trees and > then we could merge the last one some time after -rc1. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Nice work, I'll go add the USB ones to my tree now, thanks! greg k-h
On Mon, Sep 5, 2022 at 9:32 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door to augmenting device tree and ACPI information through secondary > software properties (once we teach gpiolib how to handle those). > > I hope that relevant maintainers will take patches through their trees and > then we could merge the last one some time after -rc1. I'm in favour of the series, but some comments would be good to be addressed.
On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > so that gpiolib can be cleaned a bit. We can do that by switching drivers > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > the door to augmenting device tree and ACPI information through secondary > software properties (once we teach gpiolib how to handle those). > > I hope that relevant maintainers will take patches through their trees and > then we could merge the last one some time after -rc1. > > [...] Applied to pci/tegra, thanks! [01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get https://git.kernel.org/lpieralisi/pci/c/16e3f4077965 Thanks, Lorenzo
Hi Lorenzo, On Thu, Oct 27, 2022 at 03:38:11PM +0200, Lorenzo Pieralisi wrote: > On Sun, 4 Sep 2022 23:30:52 -0700, Dmitry Torokhov wrote: > > I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() > > so that gpiolib can be cleaned a bit. We can do that by switching drivers > > to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open > > the door to augmenting device tree and ACPI information through secondary > > software properties (once we teach gpiolib how to handle those). > > > > I hope that relevant maintainers will take patches through their trees and > > then we could merge the last one some time after -rc1. > > > > [...] > > Applied to pci/tegra, thanks! > > [01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get > https://git.kernel.org/lpieralisi/pci/c/16e3f4077965 Any chance you could also pick up [06/11] PCI: aardvark: switch to using devm_gpiod_get_optional() (20220903-gpiod_get_from_of_node-remove-v1-6-b29adfb27a6c@gmail.com) - Pali Rohár has acked it. Thanks!
I would like to stop exporting OF-specific [devm_]gpiod_get_from_of_node() so that gpiolib can be cleaned a bit. We can do that by switching drivers to use generic fwnode API ([devm_]fwnode_gpiod_get()). By doing so we open the door to augmenting device tree and ACPI information through secondary software properties (once we teach gpiolib how to handle those). I hope that relevant maintainers will take patches through their trees and then we could merge the last one some time after -rc1. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- Dmitry Torokhov (11): PCI: tegra: switch to using devm_fwnode_gpiod_get drm/tegra: switch to using devm_fwnode_gpiod_get mtd: rawnand: stm32_fmc2: switch to using devm_fwnode_gpiod_get() usb: phy: tegra: switch to using devm_gpiod_get() usb: gadget: udc: at91: switch to using fwnode_gpiod_get_index() PCI: aardvark: switch to using devm_gpiod_get_optional() PCI: apple: switch to using fwnode_gpiod_get_index() regulator: bd71815: switch to using devm_fwnode_gpiod_get() regulator: bd9576: switch to using devm_fwnode_gpiod_get() watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get() gpiolib: of: remove [devm_]gpiod_get_from_of_node() APIs drivers/gpio/gpiolib-devres.c | 55 ---------------------------------- drivers/gpio/gpiolib-of.c | 1 - drivers/gpio/gpiolib-of.h | 13 ++++++++ drivers/gpu/drm/tegra/output.c | 10 +++---- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 5 ++-- drivers/pci/controller/pci-aardvark.c | 23 +++++++------- drivers/pci/controller/pci-tegra.c | 9 +++--- drivers/pci/controller/pcie-apple.c | 4 +-- drivers/regulator/bd71815-regulator.c | 7 ++--- drivers/regulator/bd9576-regulator.c | 17 ++++++----- drivers/usb/gadget/udc/at91_udc.c | 8 +++-- drivers/usb/phy/phy-tegra-usb.c | 14 ++++++--- drivers/watchdog/bd9576_wdt.c | 51 ++++++++++++++++++------------- include/linux/gpio/consumer.h | 48 ----------------------------- 14 files changed, 96 insertions(+), 169 deletions(-) --- base-commit: 7fd22855300e693668c3397771b3a2b3948f827a change-id: 20220903-gpiod_get_from_of_node-remove-de3032fc01de Best regards,