[net-next,v4,0/5] net: altera: tse: phylink conversion

Message

Maxime Chevallier Sept. 2, 2022, 8:32 a.m. UTC

This is V4 of a series converting the Altera TSE driver to phylink,
introducing a new PCS driver along the way.

The Altera TSE can be built with a SGMII/1000BaseX PCS, allowing to use
SFP ports with this MAC, which is the end goal of adding phylink support
and a proper PCS driver.

The PCS itself can either be mapped in the MAC's register space, in that
case, it's accessed through 32 bits registers, with the higher 16 bits
always 0. Alternatively, it can sit on its own register space, exposing
16 bits registers, some of which ressemble the standard PHY registers.

To tackle that rework, several things needs updating, starting by the DT
binding, since we add support for a new register range for the PCS.

Hence, the first patch of the series is a conversion to YAML of the
existing binding.

Then, patch 2 does a bit of simple cleanup to the TSE driver, using nice
reverse xmas tree definitions.

Patch 3 adds the actual PCS driver, as a standalone driver. Some future
series will then reuse that PCS driver from the dwmac-socfpga driver,
which implements support for this exact PCS too, allowing to share the
code nicely.

Patch 4 is then a phylink conversion of the altera_tse driver, to use
this new PCS driver.

Finally, patch 5 updates the newly converted DT binding to support the
pcs register range.

This series contains bits and pieces for this conversion, please tell me if
you want me to send it as individual patches.

Thanks,

Maxime

V4 Changes:
 - Add missing MODULE_* macros to the TSE PCS driver

V3 Changes:
 - YAML binding conversion changes and PCS addition changes thanks to
   Krzysztof's reviews

V2 Changes :
 - Fixed the binding after the YAML conversion
 - Added a pcs_validate() callback
 - Introduced a comment to justify a soft reset for the PCS



Maxime Chevallier (5):
  dt-bindings: net: Convert Altera TSE bindings to yaml
  net: altera: tse: cosmetic change to use reverse xmas tree ordering
  net: pcs: add new PCS driver for altera TSE PCS
  net: altera: tse: convert to phylink
  dt-bindings: net: altera: tse: add an optional pcs register range

 .../devicetree/bindings/net/altera_tse.txt    | 113 -----
 .../devicetree/bindings/net/altr,tse.yaml     | 168 +++++++
 MAINTAINERS                                   |   7 +
 drivers/net/ethernet/altera/Kconfig           |   2 +
 drivers/net/ethernet/altera/altera_tse.h      |  19 +-
 .../net/ethernet/altera/altera_tse_ethtool.c  |  22 +-
 drivers/net/ethernet/altera/altera_tse_main.c | 453 +++++-------------
 drivers/net/pcs/Kconfig                       |   6 +
 drivers/net/pcs/Makefile                      |   1 +
 drivers/net/pcs/pcs-altera-tse.c              | 175 +++++++
 include/linux/pcs-altera-tse.h                |  17 +
 11 files changed, 536 insertions(+), 447 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/net/altera_tse.txt
 create mode 100644 Documentation/devicetree/bindings/net/altr,tse.yaml
 create mode 100644 drivers/net/pcs/pcs-altera-tse.c
 create mode 100644 include/linux/pcs-altera-tse.h

Comments

[e-mail] Sept. 5, 2022, 9:30 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Fri,  2 Sep 2022 10:32:00 +0200 you wrote:
> This is V4 of a series converting the Altera TSE driver to phylink,
> introducing a new PCS driver along the way.
> 
> The Altera TSE can be built with a SGMII/1000BaseX PCS, allowing to use
> SFP ports with this MAC, which is the end goal of adding phylink support
> and a proper PCS driver.
> 
> [...]

Here is the summary with links:
  - [net-next,v4,1/5] dt-bindings: net: Convert Altera TSE bindings to yaml
    https://git.kernel.org/netdev/net-next/c/b0155d909690
  - [net-next,v4,2/5] net: altera: tse: cosmetic change to use reverse xmas tree ordering
    https://git.kernel.org/netdev/net-next/c/5adb0ed04535
  - [net-next,v4,3/5] net: pcs: add new PCS driver for altera TSE PCS
    https://git.kernel.org/netdev/net-next/c/4a502cf4d77e
  - [net-next,v4,4/5] net: altera: tse: convert to phylink
    https://git.kernel.org/netdev/net-next/c/fef2998203e1
  - [net-next,v4,5/5] dt-bindings: net: altera: tse: add an optional pcs register range
    https://git.kernel.org/netdev/net-next/c/565f02fc1e5d

You are awesome, thank you!