| Message ID | 20220830091110.27857-1-matthias.bgg@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] dt-bindings: mfd: Rename mediatek,mt8195-scpsys.yaml | expand |
On Tue, 30 Aug 2022 11:11:10 +0200, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > The file describes the scpsys node for all SoCs and not only the mt8195. > Rename it to reflect this fact. > > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > Changes in v2: > - Fix id > > .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote: > From: Matthias Brugger <mbrugger@suse.com> > > The file describes the scpsys node for all SoCs and not only the mt8195. > Rename it to reflect this fact. Actually, this is fairly typical. Same with actual drivers. Both tend to adopt the name of the module first supported. > Signed-off-by: Matthias Brugger <mbrugger@suse.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > Changes in v2: > - Fix id > > .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%) > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > similarity index 96% > rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > index 3737207d8504..1a5901ca90f5 100644 > --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml# > +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: MediaTek System Control Processor System
On 08/09/2022 12:37, Lee Jones wrote: > On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote: > >> From: Matthias Brugger <mbrugger@suse.com> >> >> The file describes the scpsys node for all SoCs and not only the mt8195. >> Rename it to reflect this fact. > > Actually, this is fairly typical. Same with actual drivers. > > Both tend to adopt the name of the module first supported. > Well I think that's unfortunate as it can create confusion for people searching for the binding as well as people adding a new compatible as they might think each SoC should have a independent yaml file. For that I reason I think it makes sense to fix the naming. Regards, Matthias >> Signed-off-by: Matthias Brugger <mbrugger@suse.com> >> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> >> --- >> >> Changes in v2: >> - Fix id >> >> .../mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> rename Documentation/devicetree/bindings/mfd/{mediatek,mt8195-scpsys.yaml => mediatek,scpsys.yaml} (96%) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml >> similarity index 96% >> rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml >> rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml >> index 3737207d8504..1a5901ca90f5 100644 >> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml >> +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml >> @@ -1,7 +1,7 @@ >> # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> %YAML 1.2 >> --- >> -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml# >> +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: MediaTek System Control Processor System >
On Tue, 13 Sep 2022, Matthias Brugger wrote: > On 08/09/2022 12:37, Lee Jones wrote: > > On Tue, 30 Aug 2022, matthias.bgg@kernel.org wrote: > > > > > From: Matthias Brugger <mbrugger@suse.com> > > > > > > The file describes the scpsys node for all SoCs and not only the mt8195. > > > Rename it to reflect this fact. > > > > Actually, this is fairly typical. Same with actual drivers. > > > > Both tend to adopt the name of the module first supported. > > > > Well I think that's unfortunate as it can create confusion for people > searching for the binding as well as people adding a new compatible as they > might think each SoC should have a independent yaml file. For that I reason > I think it makes sense to fix the naming. I'm not keen to open those flood-gates right now, sorry.
diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml similarity index 96% rename from Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml rename to Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml index 3737207d8504..1a5901ca90f5 100644 --- a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml +++ b/Documentation/devicetree/bindings/mfd/mediatek,scpsys.yaml @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 --- -$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml# +$id: http://devicetree.org/schemas/mfd/mediatek,scpsys.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# title: MediaTek System Control Processor System