| Message ID | 20220907045925.1284785-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] arm64: dts: rockchip: add LED for ROCK Pi 4A/B/C/A+/B+ | expand |
Hi, Am Mittwoch, 7. September 2022, 06:59:24 CEST schrieb FUKAUMI Naoki: > only user_led2 (blue) is supported. > > user_led1 (green) is not connected to any gpio so it cannot be > controlled. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > .../boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > index 401e1ae9d944..49126560b30b 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi > @@ -6,6 +6,7 @@ > > /dts-v1/; > #include <dt-bindings/input/linux-event-codes.h> > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/pwm/pwm.h> > #include "rk3399.dtsi" > #include "rk3399-opp.dtsi" > @@ -27,6 +28,19 @@ clkin_gmac: external-gmac-clock { > #clock-cells = <0>; > }; > > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&user_led2>; > + > + user_led2 { Node names should definitly use "-" not underscores. Also gpio-leds define a pattern for node names in the yaml binding: "(^led-[0-9a-f]$|led)": So running dtbscheck on those new nodes should have found new errors with that addition. See commit e916d85b922f ("arm64: dts: rockchip: rename and label gpio-led subnodes") where existing already were already converted to be binding compliant. Heiko > + function = LED_FUNCTION_STATUS; > + color = <LED_COLOR_ID_BLUE>; > + gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > sdio_pwrseq: sdio-pwrseq { > compatible = "mmc-pwrseq-simple"; > clocks = <&rk808 1>; > @@ -553,6 +567,12 @@ hp_int: hp-int { > }; > }; > > + leds { > + user_led2: user-led2 { > + rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > pcie { > pcie_pwr_en: pcie-pwr-en { > rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; >
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi index 401e1ae9d944..49126560b30b 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi @@ -6,6 +6,7 @@ /dts-v1/; #include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/pwm/pwm.h> #include "rk3399.dtsi" #include "rk3399-opp.dtsi" @@ -27,6 +28,19 @@ clkin_gmac: external-gmac-clock { #clock-cells = <0>; }; + leds { + compatible = "gpio-leds"; + pinctrl-names = "default"; + pinctrl-0 = <&user_led2>; + + user_led2 { + function = LED_FUNCTION_STATUS; + color = <LED_COLOR_ID_BLUE>; + gpios = <&gpio3 RK_PD5 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; + }; + }; + sdio_pwrseq: sdio-pwrseq { compatible = "mmc-pwrseq-simple"; clocks = <&rk808 1>; @@ -553,6 +567,12 @@ hp_int: hp-int { }; }; + leds { + user_led2: user-led2 { + rockchip,pins = <3 RK_PD5 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; + pcie { pcie_pwr_en: pcie-pwr-en { rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;
only user_led2 (blue) is supported. user_led1 (green) is not connected to any gpio so it cannot be controlled. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- .../boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)