| Message ID | 20220906070309.18809-1-yee.lee@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [5.15.y] Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()" | expand |
On Tue, Sep 06, 2022 at 03:03:06PM +0800, yee.lee@mediatek.com wrote: > From: Yee Lee <yee.lee@mediatek.com> > > This reverts commit 23c2d497de21f25898fbea70aeb292ab8acc8c94. > > Commit 23c2d497de21 ("mm: kmemleak: take a full lowmem check in > kmemleak_*_phys()") brought false leak alarms on some archs like arm64 > that does not init pfn boundary in early booting. The final solution > lands on linux-6.0: commit 0c24e061196c ("mm: kmemleak: add rbtree and > store physical address for objects allocated with PA"). > > Revert this commit before linux-6.0. The original issue of invalid PA > can be mitigated by additional check in devicetree. > > The false alarm report is as following: Kmemleak output: (Qemu/arm64) > unreferenced object 0xffff0000c0170a00 (size 128): > comm "swapper/0", pid 1, jiffies 4294892404 (age 126.208s) > hex dump (first 32 bytes): > 62 61 73 65 00 00 00 00 00 00 00 00 00 00 00 00 base............ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<(____ptrval____)>] __kmalloc_track_caller+0x1b0/0x2e4 > [<(____ptrval____)>] kstrdup_const+0x8c/0xc4 > [<(____ptrval____)>] kvasprintf_const+0xbc/0xec > [<(____ptrval____)>] kobject_set_name_vargs+0x58/0xe4 > [<(____ptrval____)>] kobject_add+0x84/0x100 > [<(____ptrval____)>] __of_attach_node_sysfs+0x78/0xec > [<(____ptrval____)>] of_core_init+0x68/0x104 > [<(____ptrval____)>] driver_init+0x28/0x48 > [<(____ptrval____)>] do_basic_setup+0x14/0x28 > [<(____ptrval____)>] kernel_init_freeable+0x110/0x178 > [<(____ptrval____)>] kernel_init+0x20/0x1a0 > [<(____ptrval____)>] ret_from_fork+0x10/0x20 > > This pacth is also applicable to linux-5.17.y/linux-5.18.y/linux-5.19.y > > Cc: <stable@vger.kernel.org> > Signed-off-by: Yee Lee <yee.lee@mediatek.com> > --- > mm/kmemleak.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) What is the git commit id of this change in Linus's tree? And what about older stable trees with this commit in it? thanks, greg k-h
The commit ids are listed. Linus tree: 23c2d497de21f25898fbea70aeb292ab8acc8c94 Linux-5.19.y: 23c2d497de21f25898fbea70aeb292ab8acc8c94 Linux-5.18.y: 23c2d497de21f25898fbea70aeb292ab8acc8c94 (backported) Linux-5.17.y: 0d2e07c04c7f7d83c75c56da3e2f970c5653ade0 Linux-5.15.y: 70ea5e7b38c30b60821e432abde6f3c359224139 Linux-5.10.y: 06c348fde545ec90e25de3e5bc4b814bff70ae9f Linux-5.4.y: 534d0aebe164fe9afff2a58fb1d5fb458d8a036b Linux-4.19.y: 7f4f020286e0bd4aaf40512c80c63a5e5bd629bc Linux-4.14.y: 07f108f15fd75a9bff704eed718cc12f91b080dc Linux-4.9.y: 96eb48099a7e740768d215a989b26e0af7381371 Thanks. -----Original Message----- From: Greg KH <greg@kroah.com> Sent: Tuesday, September 6, 2022 8:09 PM To: Yee Lee (李建誼) <Yee.Lee@mediatek.com> Cc: linux-kernel@vger.kernel.org; patrick.wang.shcn@gmail.com; stable@vger.kernel.org; Catalin Marinas <catalin.marinas@arm.com>; Andrew Morton <akpm@linux-foundation.org>; Matthias Brugger <matthias.bgg@gmail.com>; open list:MEMORY MANAGEMENT <linux-mm@kvack.org>; moderated list:ARM/Mediatek SoC support <linux-arm-kernel@lists.infradead.org>; moderated list:ARM/Mediatek SoC support <linux-mediatek@lists.infradead.org> Subject: Re: [PATCH 5.15.y] Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()" On Tue, Sep 06, 2022 at 03:03:06PM +0800, mailto:yee.lee@mediatek.com wrote: > From: Yee Lee <mailto:yee.lee@mediatek.com> > > This reverts commit 23c2d497de21f25898fbea70aeb292ab8acc8c94. > > Commit 23c2d497de21 ("mm: kmemleak: take a full lowmem check in > kmemleak_*_phys()") brought false leak alarms on some archs like arm64 > that does not init pfn boundary in early booting. The final solution > lands on linux-6.0: commit 0c24e061196c ("mm: kmemleak: add rbtree and > store physical address for objects allocated with PA"). > > Revert this commit before linux-6.0. The original issue of invalid PA > can be mitigated by additional check in devicetree. > > The false alarm report is as following: Kmemleak output: (Qemu/arm64) > unreferenced object 0xffff0000c0170a00 (size 128): > comm "swapper/0", pid 1, jiffies 4294892404 (age 126.208s) > hex dump (first 32 bytes): > 62 61 73 65 00 00 00 00 00 00 00 00 00 00 00 00 base............ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<(____ptrval____)>] __kmalloc_track_caller+0x1b0/0x2e4 > [<(____ptrval____)>] kstrdup_const+0x8c/0xc4 > [<(____ptrval____)>] kvasprintf_const+0xbc/0xec > [<(____ptrval____)>] kobject_set_name_vargs+0x58/0xe4 > [<(____ptrval____)>] kobject_add+0x84/0x100 > [<(____ptrval____)>] __of_attach_node_sysfs+0x78/0xec > [<(____ptrval____)>] of_core_init+0x68/0x104 > [<(____ptrval____)>] driver_init+0x28/0x48 > [<(____ptrval____)>] do_basic_setup+0x14/0x28 > [<(____ptrval____)>] kernel_init_freeable+0x110/0x178 > [<(____ptrval____)>] kernel_init+0x20/0x1a0 > [<(____ptrval____)>] ret_from_fork+0x10/0x20 > > This pacth is also applicable to > linux-5.17.y/linux-5.18.y/linux-5.19.y > > Cc: <mailto:stable@vger.kernel.org> > Signed-off-by: Yee Lee <mailto:yee.lee@mediatek.com> > --- > mm/kmemleak.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) What is the git commit id of this change in Linus's tree? And what about older stable trees with this commit in it? thanks, greg k-h
On Wed, Sep 07, 2022 at 08:37:56AM +0000, Yee Lee (李建誼) wrote: > The commit ids are listed. > > Linus tree: 23c2d497de21f25898fbea70aeb292ab8acc8c94 > Linux-5.19.y: 23c2d497de21f25898fbea70aeb292ab8acc8c94 > Linux-5.18.y: 23c2d497de21f25898fbea70aeb292ab8acc8c94 > > (backported) > Linux-5.17.y: 0d2e07c04c7f7d83c75c56da3e2f970c5653ade0 > Linux-5.15.y: 70ea5e7b38c30b60821e432abde6f3c359224139 > Linux-5.10.y: 06c348fde545ec90e25de3e5bc4b814bff70ae9f > Linux-5.4.y: 534d0aebe164fe9afff2a58fb1d5fb458d8a036b > Linux-4.19.y: 7f4f020286e0bd4aaf40512c80c63a5e5bd629bc > Linux-4.14.y: 07f108f15fd75a9bff704eed718cc12f91b080dc > Linux-4.9.y: 96eb48099a7e740768d215a989b26e0af7381371 Thanks, now queued up everywhere. greg k-h
diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 859303aae180..b78861b8e013 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1125,7 +1125,7 @@ EXPORT_SYMBOL(kmemleak_no_scan); void __ref kmemleak_alloc_phys(phys_addr_t phys, size_t size, int min_count, gfp_t gfp) { - if (PHYS_PFN(phys) >= min_low_pfn && PHYS_PFN(phys) < max_low_pfn) + if (!IS_ENABLED(CONFIG_HIGHMEM) || PHYS_PFN(phys) < max_low_pfn) kmemleak_alloc(__va(phys), size, min_count, gfp); } EXPORT_SYMBOL(kmemleak_alloc_phys); @@ -1139,7 +1139,7 @@ EXPORT_SYMBOL(kmemleak_alloc_phys); */ void __ref kmemleak_free_part_phys(phys_addr_t phys, size_t size) { - if (PHYS_PFN(phys) >= min_low_pfn && PHYS_PFN(phys) < max_low_pfn) + if (!IS_ENABLED(CONFIG_HIGHMEM) || PHYS_PFN(phys) < max_low_pfn) kmemleak_free_part(__va(phys), size); } EXPORT_SYMBOL(kmemleak_free_part_phys); @@ -1151,7 +1151,7 @@ EXPORT_SYMBOL(kmemleak_free_part_phys); */ void __ref kmemleak_not_leak_phys(phys_addr_t phys) { - if (PHYS_PFN(phys) >= min_low_pfn && PHYS_PFN(phys) < max_low_pfn) + if (!IS_ENABLED(CONFIG_HIGHMEM) || PHYS_PFN(phys) < max_low_pfn) kmemleak_not_leak(__va(phys)); } EXPORT_SYMBOL(kmemleak_not_leak_phys); @@ -1163,7 +1163,7 @@ EXPORT_SYMBOL(kmemleak_not_leak_phys); */ void __ref kmemleak_ignore_phys(phys_addr_t phys) { - if (PHYS_PFN(phys) >= min_low_pfn && PHYS_PFN(phys) < max_low_pfn) + if (!IS_ENABLED(CONFIG_HIGHMEM) || PHYS_PFN(phys) < max_low_pfn) kmemleak_ignore(__va(phys)); } EXPORT_SYMBOL(kmemleak_ignore_phys);