| Message ID | 20220831081715.14673-1-pali@kernel.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | [v3,1/3] dt-bindings: reset: syscon-reboot: Add priority property | expand |
On 31/08/2022 10:17, Pali Rohár wrote: > This new optional priority property allows to specify custom priority level > of reset device. Prior this change priority level was hardcoded to 192 and > not possible to specify or change. Specifying other value is needed for > some boards. Default level when not specified stays at 192 as before. > > Signed-off-by: Pali Rohár <pali@kernel.org> Thanks for the changes. Explanation looks good. I sent a patch adding the common schema with priority. If it gets ack/review from Rob and Sebastian, please kindly rebase on top of it and use same way as I did for gpio-restart.yaml Best regards, Krzysztof
On Wednesday 07 September 2022 14:38:42 Krzysztof Kozlowski wrote: > On 31/08/2022 10:17, Pali Rohár wrote: > > This new optional priority property allows to specify custom priority level > > of reset device. Prior this change priority level was hardcoded to 192 and > > not possible to specify or change. Specifying other value is needed for > > some boards. Default level when not specified stays at 192 as before. > > > > Signed-off-by: Pali Rohár <pali@kernel.org> > > Thanks for the changes. Explanation looks good. > > I sent a patch adding the common schema with priority. If it gets > ack/review from Rob and Sebastian, please kindly rebase on top of it and > use same way as I did for gpio-restart.yaml > > Best regards, > Krzysztof Ok, so just by adding "allOf: - $ref: restart-handler.yaml#" right?
On 07/09/2022 18:33, Pali Rohár wrote: > On Wednesday 07 September 2022 14:38:42 Krzysztof Kozlowski wrote: >> On 31/08/2022 10:17, Pali Rohár wrote: >>> This new optional priority property allows to specify custom priority level >>> of reset device. Prior this change priority level was hardcoded to 192 and >>> not possible to specify or change. Specifying other value is needed for >>> some boards. Default level when not specified stays at 192 as before. >>> >>> Signed-off-by: Pali Rohár <pali@kernel.org> >> >> Thanks for the changes. Explanation looks good. >> >> I sent a patch adding the common schema with priority. If it gets >> ack/review from Rob and Sebastian, please kindly rebase on top of it and >> use same way as I did for gpio-restart.yaml >> >> Best regards, >> Krzysztof > > Ok, so just by adding "allOf: - $ref: restart-handler.yaml#" right? Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml index da2509724812..4c8b0d0a0111 100644 --- a/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml +++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot.yaml @@ -42,6 +42,11 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: The reset value written to the reboot register (32 bit access). + priority: + $ref: /schemas/types.yaml#/definitions/int32 + description: Priority level of this syscon reset device. + default: 192 + required: - compatible - offset
This new optional priority property allows to specify custom priority level of reset device. Prior this change priority level was hardcoded to 192 and not possible to specify or change. Specifying other value is needed for some boards. Default level when not specified stays at 192 as before. Signed-off-by: Pali Rohár <pali@kernel.org> --- Changes in v3: * Add explanation into commit message Changes in v2: * Change sint32 to int32 * Add default --- .../devicetree/bindings/power/reset/syscon-reboot.yaml | 5 +++++ 1 file changed, 5 insertions(+)