diff mbox series

[v1] Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk

Message ID 20220907071945.9925-1-kiran.k@intel.com (mailing list archive)
State Accepted
Commit dd0a1794f4334ddbf9b7c5e7d642aaffff38c69b
Headers show
Series [v1] Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/subjectprefix success PASS
tedd_an/buildkernel success Build Kernel PASS
tedd_an/buildkernel32 success Build Kernel32 PASS
tedd_an/incremental_build success Pass
tedd_an/testrunnersetup success Test Runner Setup PASS
tedd_an/testrunnerl2cap-tester success Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneriso-tester success Total: 55, Passed: 55 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerbnep-tester success Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnermgmt-tester success Total: 494, Passed: 494 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnerrfcomm-tester success Total: 10, Passed: 10 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersco-tester success Total: 12, Passed: 12 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunnersmp-tester success Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0
tedd_an/testrunneruserchan-tester success Total: 4, Passed: 4 (100.0%), Failed: 0, Not Run: 0

Commit Message

K, Kiran Sept. 7, 2022, 7:19 a.m. UTC 
HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers
are marked to support HCI_QUIRK_LE_STATES.

Signed-off-by: Kiran K <kiran.k@intel.com>
Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
---
 drivers/bluetooth/btintel.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

Comments

bluez.test.bot@gmail.com Sept. 7, 2022, 8:25 a.m. UTC | #1 
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=674745

---Test result---

Test Summary:
CheckPatch                    PASS      1.91 seconds
GitLint                       PASS      1.02 seconds
SubjectPrefix                 PASS      0.85 seconds
BuildKernel                   PASS      36.62 seconds
BuildKernel32                 PASS      30.13 seconds
Incremental Build with patchesPASS      44.68 seconds
TestRunner: Setup             PASS      500.11 seconds
TestRunner: l2cap-tester      PASS      16.90 seconds
TestRunner: iso-tester        PASS      15.85 seconds
TestRunner: bnep-tester       PASS      6.28 seconds
TestRunner: mgmt-tester       PASS      100.95 seconds
TestRunner: rfcomm-tester     PASS      9.91 seconds
TestRunner: sco-tester        PASS      9.36 seconds
TestRunner: smp-tester        PASS      9.32 seconds
TestRunner: userchan-tester   PASS      6.46 seconds



---
Regards,
Linux Bluetooth
Paul Menzel Sept. 7, 2022, 9:28 a.m. UTC | #2 
Dear Kiran,


Thank you for the patch.


Am 07.09.22 um 09:19 schrieb Kiran K:
> HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers

Harrison

> are marked to support HCI_QUIRK_LE_STATES.

“Supporting” a quirk sounds strange. Maybe better use “need”?

If new platforms need the quirk, do you know if the hardware folks are 
aware of this?


Kind regards,

Paul


> Signed-off-by: Kiran K <kiran.k@intel.com>
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> ---
>   drivers/bluetooth/btintel.c | 17 ++++++++---------
>   1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 818681c89db8..d44a96667517 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2439,15 +2439,20 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   					       INTEL_ROM_LEGACY_NO_WBS_SUPPORT))
>   				set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
>   					&hdev->quirks);
> +			if (ver.hw_variant == 0x08 && ver.fw_variant == 0x22)
> +				set_bit(HCI_QUIRK_VALID_LE_STATES,
> +					&hdev->quirks);
>   
>   			err = btintel_legacy_rom_setup(hdev, &ver);
>   			break;
>   		case 0x0b:      /* SfP */
> -		case 0x0c:      /* WsP */
>   		case 0x11:      /* JfP */
>   		case 0x12:      /* ThP */
>   		case 0x13:      /* HrP */
>   		case 0x14:      /* CcP */
> +			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
> +			fallthrough;
> +		case 0x0c:	/* WsP */
>   			/* Apply the device specific HCI quirks
>   			 *
>   			 * All Legacy bootloader devices support WBS
> @@ -2455,11 +2460,6 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
>   				&hdev->quirks);
>   
> -			/* Valid LE States quirk for JfP/ThP familiy */
> -			if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
> -				set_bit(HCI_QUIRK_VALID_LE_STATES,
> -					&hdev->quirks);
> -
>   			/* Setup MSFT Extension support */
>   			btintel_set_msft_opcode(hdev, ver.hw_variant);
>   
> @@ -2530,9 +2530,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>   		 */
>   		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
>   
> -		/* Valid LE States quirk for JfP/ThP familiy */
> -		if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
> -			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
> +		/* Set Valid LE States quirk */
> +		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
>   
>   		/* Setup MSFT Extension support */
>   		btintel_set_msft_opcode(hdev, ver.hw_variant);
patchwork-bot+bluetooth@kernel.org Sept. 9, 2022, 7:30 p.m. UTC | #3 
Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed,  7 Sep 2022 12:49:45 +0530 you wrote:
> HarrrisonPeak, CyclonePeak, SnowFieldPeak and SandyPeak controllers
> are marked to support HCI_QUIRK_LE_STATES.
> 
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Signed-off-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> ---
>  drivers/bluetooth/btintel.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)

Here is the summary with links:
  - [v1] Bluetooth: btintel: Mark Intel controller to support LE_STATES quirk
    https://git.kernel.org/bluetooth/bluetooth-next/c/dd0a1794f433

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 818681c89db8..d44a96667517 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2439,15 +2439,20 @@  static int btintel_setup_combined(struct hci_dev *hdev)
 					       INTEL_ROM_LEGACY_NO_WBS_SUPPORT))
 				set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
 					&hdev->quirks);
+			if (ver.hw_variant == 0x08 && ver.fw_variant == 0x22)
+				set_bit(HCI_QUIRK_VALID_LE_STATES,
+					&hdev->quirks);
 
 			err = btintel_legacy_rom_setup(hdev, &ver);
 			break;
 		case 0x0b:      /* SfP */
-		case 0x0c:      /* WsP */
 		case 0x11:      /* JfP */
 		case 0x12:      /* ThP */
 		case 0x13:      /* HrP */
 		case 0x14:      /* CcP */
+			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+			fallthrough;
+		case 0x0c:	/* WsP */
 			/* Apply the device specific HCI quirks
 			 *
 			 * All Legacy bootloader devices support WBS
@@ -2455,11 +2460,6 @@  static int btintel_setup_combined(struct hci_dev *hdev)
 			set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
 				&hdev->quirks);
 
-			/* Valid LE States quirk for JfP/ThP familiy */
-			if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-				set_bit(HCI_QUIRK_VALID_LE_STATES,
-					&hdev->quirks);
-
 			/* Setup MSFT Extension support */
 			btintel_set_msft_opcode(hdev, ver.hw_variant);
 
@@ -2530,9 +2530,8 @@  static int btintel_setup_combined(struct hci_dev *hdev)
 		 */
 		set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
 
-		/* Valid LE States quirk for JfP/ThP familiy */
-		if (ver.hw_variant == 0x11 || ver.hw_variant == 0x12)
-			set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+		/* Set Valid LE States quirk */
+		set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
 
 		/* Setup MSFT Extension support */
 		btintel_set_msft_opcode(hdev, ver.hw_variant);