Message ID | 0da7c28a377a1fac9db524dbc8462731d922b39c.1662708705.git.mchehab@kernel.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | drm/i915: fix kernel-doc issues | expand |
Hi Mauro, On Fri, Sep 09, 2022 at 09:34:40AM +0200, Mauro Carvalho Chehab wrote: > commit d1b48c1e7184 ("drm/i915: Replace execbuf vma ht with an idr") > added a rbtree list to allow searching for obj/ctx. > > Document it. > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org> > --- > > To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover. > See [PATCH v3 00/37] at: https://lore.kernel.org/all/cover.1662708705.git.mchehab@kernel.org/ > > drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > index 9f6b14ec189a..35746cf268ea 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h > @@ -21,9 +21,15 @@ struct drm_i915_gem_object; > struct intel_fronbuffer; > struct intel_memory_region; > > -/* > - * struct i915_lut_handle tracks the fast lookups from handle to vma used > - * for execbuf. Although we use a radixtree for that mapping, in order to > +/** > + * struct i915_lut_handle - tracks the fast lookups from handle to vma used > + * for execbuf. > + * just to be picky: do we or don't we want this extra space here? I think that besides our personal taste it's important to have a coherent style. I would r-b it anyway if I didn't look the next patch. Andi > + * @obj_link: link to the object associated with the @handle. > + * @ctx: context associated with the @handle. > + * @handle: a rbtree handle to lookup context for specific obj/vma. > + * > + * Although we use a radixtree for that mapping, in order to > * remove them as the object or context is closed, we need a secondary list > * and a translation entry (i915_lut_handle). > */ > -- > 2.37.3
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h index 9f6b14ec189a..35746cf268ea 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object_types.h +++ b/drivers/gpu/drm/i915/gem/i915_gem_object_types.h @@ -21,9 +21,15 @@ struct drm_i915_gem_object; struct intel_fronbuffer; struct intel_memory_region; -/* - * struct i915_lut_handle tracks the fast lookups from handle to vma used - * for execbuf. Although we use a radixtree for that mapping, in order to +/** + * struct i915_lut_handle - tracks the fast lookups from handle to vma used + * for execbuf. + * + * @obj_link: link to the object associated with the @handle. + * @ctx: context associated with the @handle. + * @handle: a rbtree handle to lookup context for specific obj/vma. + * + * Although we use a radixtree for that mapping, in order to * remove them as the object or context is closed, we need a secondary list * and a translation entry (i915_lut_handle). */