| Message ID | 20220910170207.1592220-1-danct12@riseup.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | clk: qcom: sm6115: Select QCOM_GDSC | expand |
On 10/09/2022 18:02, Dang Huynh wrote: > While working on the Fxtec Pro1X device, this error shows up with > my own minimal configuration: > > gcc-sm6115: probe of 1400000.clock-controller failed with error -38 > > The clock driver depends on CONFIG_QCOM_GDSC and after enabling > that, the driver probes successfully. > > Signed-off-by: Dang Huynh <danct12@riseup.net> > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > index 1cf1ef70e347..d566fbdebdf9 100644 > --- a/drivers/clk/qcom/Kconfig > +++ b/drivers/clk/qcom/Kconfig > @@ -645,6 +645,7 @@ config SM_DISPCC_6350 > > config SM_GCC_6115 > tristate "SM6115 and SM4250 Global Clock Controller" > + select QCOM_GDSC depends on QCOM_GDSC > help > Support for the global clock controller on SM6115 and SM4250 devices. > Say Y if you want to use peripheral devices such as UART, SPI, > -- > 2.37.3 > -- Kind Regards, Caleb
On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <caleb@connolly.tech> wrote: > > > > On 10/09/2022 18:02, Dang Huynh wrote: > > While working on the Fxtec Pro1X device, this error shows up with > > my own minimal configuration: > > > > gcc-sm6115: probe of 1400000.clock-controller failed with error -38 > > > > The clock driver depends on CONFIG_QCOM_GDSC and after enabling > > that, the driver probes successfully. > > > > Signed-off-by: Dang Huynh <danct12@riseup.net> > > --- > > drivers/clk/qcom/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig > > index 1cf1ef70e347..d566fbdebdf9 100644 > > --- a/drivers/clk/qcom/Kconfig > > +++ b/drivers/clk/qcom/Kconfig > > @@ -645,6 +645,7 @@ config SM_DISPCC_6350 > > > > config SM_GCC_6115 > > tristate "SM6115 and SM4250 Global Clock Controller" > > + select QCOM_GDSC > > depends on QCOM_GDSC All other Qualcomm clock drivers select the GDSC if required, so I'd tend to disagree.
On Sat, 10 Sept 2022 at 20:02, Dang Huynh <danct12@riseup.net> wrote: > > While working on the Fxtec Pro1X device, this error shows up with > my own minimal configuration: > > gcc-sm6115: probe of 1400000.clock-controller failed with error -38 > > The clock driver depends on CONFIG_QCOM_GDSC and after enabling > that, the driver probes successfully. > > Signed-off-by: Dang Huynh <danct12@riseup.net> Fixes: cbe63bfdc54f ("clk: qcom: Add Global Clock controller (GCC) driver for SM6115") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/clk/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+)
On 12/09/2022 14:32, Dmitry Baryshkov wrote: > On Mon, 12 Sept 2022 at 16:17, Caleb Connolly <caleb@connolly.tech> wrote: >> >> >> >> On 10/09/2022 18:02, Dang Huynh wrote: >>> While working on the Fxtec Pro1X device, this error shows up with >>> my own minimal configuration: >>> >>> gcc-sm6115: probe of 1400000.clock-controller failed with error -38 >>> >>> The clock driver depends on CONFIG_QCOM_GDSC and after enabling >>> that, the driver probes successfully. >>> >>> Signed-off-by: Dang Huynh <danct12@riseup.net> >>> --- >>> drivers/clk/qcom/Kconfig | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >>> index 1cf1ef70e347..d566fbdebdf9 100644 >>> --- a/drivers/clk/qcom/Kconfig >>> +++ b/drivers/clk/qcom/Kconfig >>> @@ -645,6 +645,7 @@ config SM_DISPCC_6350 >>> >>> config SM_GCC_6115 >>> tristate "SM6115 and SM4250 Global Clock Controller" >>> + select QCOM_GDSC >> >> depends on QCOM_GDSC > > All other Qualcomm clock drivers select the GDSC if required, so I'd > tend to disagree. Ah, in that case please disregard, sorry for the noise. > > > -- > With best wishes > Dmitry -- Kind Regards, Caleb
On Sun, 11 Sep 2022 00:02:07 +0700, Dang Huynh wrote: > While working on the Fxtec Pro1X device, this error shows up with > my own minimal configuration: > > gcc-sm6115: probe of 1400000.clock-controller failed with error -38 > > The clock driver depends on CONFIG_QCOM_GDSC and after enabling > that, the driver probes successfully. > > [...] Applied, thanks! [1/1] clk: qcom: sm6115: Select QCOM_GDSC commit: 50ee65dc512b9b5c4de354cf3b4dded34f46c571 Best regards,
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig index 1cf1ef70e347..d566fbdebdf9 100644 --- a/drivers/clk/qcom/Kconfig +++ b/drivers/clk/qcom/Kconfig @@ -645,6 +645,7 @@ config SM_DISPCC_6350 config SM_GCC_6115 tristate "SM6115 and SM4250 Global Clock Controller" + select QCOM_GDSC help Support for the global clock controller on SM6115 and SM4250 devices. Say Y if you want to use peripheral devices such as UART, SPI,
While working on the Fxtec Pro1X device, this error shows up with my own minimal configuration: gcc-sm6115: probe of 1400000.clock-controller failed with error -38 The clock driver depends on CONFIG_QCOM_GDSC and after enabling that, the driver probes successfully. Signed-off-by: Dang Huynh <danct12@riseup.net> --- drivers/clk/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+)