Message ID | 20220912103700.18338-1-xu.panda@zte.com.cn (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [linux-next] USB: serial: keyspan_pda: remove the unneeded result variable | expand |
On Mon, Sep 12, 2022 at 10:37:01AM +0000, cgel.zte@gmail.com wrote: > From: Xu Panda <xu.panda@zte.com.cn> > > Return the usb_control_msg() directly instead of storing it in > another redundant variable. > > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn> > --- > drivers/usb/serial/keyspan_pda.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c > index 6fd15cd9e1eb..902675ac7f5c 100644 > --- a/drivers/usb/serial/keyspan_pda.c > +++ b/drivers/usb/serial/keyspan_pda.c > @@ -393,12 +393,10 @@ static int keyspan_pda_get_modem_info(struct usb_serial *serial, > static int keyspan_pda_set_modem_info(struct usb_serial *serial, > unsigned char value) > { > - int rc; > - rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), > - 3, /* set pins */ > - USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_OUT, > - value, 0, NULL, 0, 2000); > - return rc; > + return usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), > + 3, /* set pins */ > + USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_OUT, > + value, 0, NULL, 0, 2000); > } Again, incorrect use of the usb_control_msg() return value.
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c index 6fd15cd9e1eb..902675ac7f5c 100644 --- a/drivers/usb/serial/keyspan_pda.c +++ b/drivers/usb/serial/keyspan_pda.c @@ -393,12 +393,10 @@ static int keyspan_pda_get_modem_info(struct usb_serial *serial, static int keyspan_pda_set_modem_info(struct usb_serial *serial, unsigned char value) { - int rc; - rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), - 3, /* set pins */ - USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_OUT, - value, 0, NULL, 0, 2000); - return rc; + return usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), + 3, /* set pins */ + USB_TYPE_VENDOR|USB_RECIP_INTERFACE|USB_DIR_OUT, + value, 0, NULL, 0, 2000); } static int keyspan_pda_tiocmget(struct tty_struct *tty)