| Message ID | 20220908150658.1839520-2-kavyasree.kotagiri@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for lan966x flexcom chip-select configuration | expand |
On 08/09/2022 17:06, Kavyasree Kotagiri wrote: > Convert the Atmel flexcom device tree bindings to json schema. > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > --- (...) > + > +patternProperties: > + "^serial@[0-9a-f]+$": > + type: object > + description: > + Child node describing USART. See atmel-usart.txt for details > + of USART bindings. > + > + "^spi@[0-9a-f]+$": > + $ref: ../spi/atmel,at91rm9200-spi.yaml Full path, so /schemas/spi/atmel... > + description: > + Child node describing SPI. > + > + "^i2c@[0-9a-f]+$": > + $ref: ../i2c/atmel,at91sam-i2c.yaml /schemas/i2c/atmel.... Best regards, Krzysztof
On Thu, 08 Sep 2022 13:06:56 -0200, Kavyasree Kotagiri wrote: > Convert the Atmel flexcom device tree bindings to json schema. > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > --- > v8 -> v9: > - Changed reference provided for spi bindings to atmel,at91rm9200-spi.yaml > > v7 -> v8: > - Added back patternProperties for child nodes. > > v6 -> v7: > - Change filename to atmel,sama5d2-flexcom.yaml > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > v5 -> v6: > - Removed spi node from example as suggested by Rob and > also pattern properties(spi dt-bindings conversion to yaml patch is under review). > Once that is accepted, I will add back spi example through new patch. > > v4 -> v5: > - Fixed indentations. > > v3 -> v4: > - Corrected format of enum used for compatible string. > > v2 -> v3: > - used enum for compatible string. > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > - fixed dtschema errors. > > v1 -> v2: > - Fix title. > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91 +++++++++++++++++++ > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- > 2 files changed, 91 insertions(+), 63 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ flexcom@e0040000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb arch/arm/boot/dts/lan966x-pcb8291.dtb arch/arm/boot/dts/lan966x-pcb8309.dtb flexcom@e0044000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb arch/arm/boot/dts/lan966x-pcb8291.dtb arch/arm/boot/dts/lan966x-pcb8309.dtb flexcom@e0060000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb arch/arm/boot/dts/lan966x-pcb8291.dtb arch/arm/boot/dts/lan966x-pcb8309.dtb flexcom@e0064000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb arch/arm/boot/dts/lan966x-pcb8291.dtb arch/arm/boot/dts/lan966x-pcb8309.dtb flexcom@e0070000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb arch/arm/boot/dts/lan966x-pcb8291.dtb arch/arm/boot/dts/lan966x-pcb8309.dtb flexcom@e2824000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-sama7g5ek.dtb flexcom@f8034000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-kizbox3-hs.dtb arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb arch/arm/boot/dts/at91-sama5d2_icp.dtb arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb arch/arm/boot/dts/at91-sama5d2_xplained.dtb flexcom@f8038000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-kizbox3-hs.dtb arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb arch/arm/boot/dts/at91-sama5d2_icp.dtb arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb arch/arm/boot/dts/at91-sama5d2_xplained.dtb flexcom@fc010000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-kizbox3-hs.dtb arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb arch/arm/boot/dts/at91-sama5d2_icp.dtb arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb arch/arm/boot/dts/at91-sama5d2_xplained.dtb flexcom@fc014000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-kizbox3-hs.dtb arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb arch/arm/boot/dts/at91-sama5d2_icp.dtb arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb arch/arm/boot/dts/at91-sama5d2_xplained.dtb flexcom@fc018000: spi@400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected) arch/arm/boot/dts/at91-kizbox3-hs.dtb arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb arch/arm/boot/dts/at91-sama5d2_icp.dtb arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> > On Thu, 08 Sep 2022 13:06:56 -0200, Kavyasree Kotagiri wrote: > > Convert the Atmel flexcom device tree bindings to json schema. > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > --- > > v8 -> v9: > > - Changed reference provided for spi bindings to atmel,at91rm9200- > spi.yaml > > > > v7 -> v8: > > - Added back patternProperties for child nodes. > > > > v6 -> v7: > > - Change filename to atmel,sama5d2-flexcom.yaml > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > > > v5 -> v6: > > - Removed spi node from example as suggested by Rob and > > also pattern properties(spi dt-bindings conversion to yaml patch is under > review). > > Once that is accepted, I will add back spi example through new patch. > > > > v4 -> v5: > > - Fixed indentations. > > > > v3 -> v4: > > - Corrected format of enum used for compatible string. > > > > v2 -> v3: > > - used enum for compatible string. > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > - fixed dtschema errors. > > > > v1 -> v2: > > - Fix title. > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91 > +++++++++++++++++++ > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- > > 2 files changed, 91 insertions(+), 63 deletions(-) > > create mode 100644 > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > flexcom.txt > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > flexcom@e0040000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > arch/arm/boot/dts/lan966x-pcb8291.dtb > arch/arm/boot/dts/lan966x-pcb8309.dtb > > flexcom@e0044000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > arch/arm/boot/dts/lan966x-pcb8291.dtb > arch/arm/boot/dts/lan966x-pcb8309.dtb > > flexcom@e0060000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > arch/arm/boot/dts/lan966x-pcb8291.dtb > arch/arm/boot/dts/lan966x-pcb8309.dtb > > flexcom@e0064000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > arch/arm/boot/dts/lan966x-pcb8291.dtb > arch/arm/boot/dts/lan966x-pcb8309.dtb > > flexcom@e0070000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > arch/arm/boot/dts/lan966x-pcb8291.dtb > arch/arm/boot/dts/lan966x-pcb8309.dtb > > flexcom@e2824000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-sama7g5ek.dtb > > flexcom@f8034000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-kizbox3-hs.dtb > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > arch/arm/boot/dts/at91-sama5d2_icp.dtb > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > flexcom@f8038000: spi@400: Unevaluated properties are not allowed > ('dma-names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-kizbox3-hs.dtb > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > arch/arm/boot/dts/at91-sama5d2_icp.dtb > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > flexcom@fc010000: spi@400: Unevaluated properties are not allowed ('dma- > names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-kizbox3-hs.dtb > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > arch/arm/boot/dts/at91-sama5d2_icp.dtb > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > flexcom@fc014000: spi@400: Unevaluated properties are not allowed ('dma- > names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-kizbox3-hs.dtb > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > arch/arm/boot/dts/at91-sama5d2_icp.dtb > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > flexcom@fc018000: spi@400: Unevaluated properties are not allowed ('dma- > names', 'dmas' were unexpected) > arch/arm/boot/dts/at91-kizbox3-hs.dtb > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > arch/arm/boot/dts/at91-sama5d2_icp.dtb > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > arch/arm/boot/dts/at91-sama5d2_xplained.dtb dma properties for spi node is already being covered by Sergiu in below patch: https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854-751a48545576@linaro.org/ Thanks, Kavya
> > > Convert the Atmel flexcom device tree bindings to json schema. > > > > > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> > > > --- > > > v8 -> v9: > > > - Changed reference provided for spi bindings to atmel,at91rm9200- > > spi.yaml > > > > > > v7 -> v8: > > > - Added back patternProperties for child nodes. > > > > > > v6 -> v7: > > > - Change filename to atmel,sama5d2-flexcom.yaml > > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings. > > > > > > v5 -> v6: > > > - Removed spi node from example as suggested by Rob and > > > also pattern properties(spi dt-bindings conversion to yaml patch is > under > > review). > > > Once that is accepted, I will add back spi example through new patch. > > > > > > v4 -> v5: > > > - Fixed indentations. > > > > > > v3 -> v4: > > > - Corrected format of enum used for compatible string. > > > > > > v2 -> v3: > > > - used enum for compatible string. > > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. > > > - fixed dtschema errors. > > > > > > v1 -> v2: > > > - Fix title. > > > > > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91 > > +++++++++++++++++++ > > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- > > > 2 files changed, 91 insertions(+), 63 deletions(-) > > > create mode 100644 > > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml > > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel- > > flexcom.txt > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > > This will change in the future. > > > > Full log is available here: https://patchwork.ozlabs.org/patch/ > > > > > > flexcom@e0040000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0044000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0060000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0064000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e0070000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb > > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb > > arch/arm/boot/dts/lan966x-pcb8291.dtb > > arch/arm/boot/dts/lan966x-pcb8309.dtb > > > > flexcom@e2824000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-sama7g5ek.dtb > > > > flexcom@f8034000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@f8038000: spi@400: Unevaluated properties are not allowed > > ('dma-names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc010000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc014000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > > > flexcom@fc018000: spi@400: Unevaluated properties are not allowed > ('dma- > > names', 'dmas' were unexpected) > > arch/arm/boot/dts/at91-kizbox3-hs.dtb > > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_icp.dtb > > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > dma properties for spi node is already being covered by Sergiu in below > patch: > https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > 751a48545576@linaro.org/ > Hi Rob, Please let me know your comments. Thanks, Kavya > > Thanks, > Kavya
On 12/09/2022 10:16, Kavyasree.Kotagiri@microchip.com wrote: >>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed >> ('dma- >>> names', 'dmas' were unexpected) >>> arch/arm/boot/dts/at91-kizbox3-hs.dtb >>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb >>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb >>> arch/arm/boot/dts/at91-sama5d2_icp.dtb >>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb >>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb >> >> dma properties for spi node is already being covered by Sergiu in below >> patch: >> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- >> 751a48545576@linaro.org/ >> > Hi Rob, Please let me know your comments. this means it cannot be currently tested. Are you sure that there are no warnings in all DTBs with your patches? Best regards, Krzysztof
> >>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed > >> ('dma- > >>> names', 'dmas' were unexpected) > >>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > >>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > >>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > >>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > >> > >> dma properties for spi node is already being covered by Sergiu in below > >> patch: > >> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > >> 751a48545576@linaro.org/ > >> > > Hi Rob, Please let me know your comments. > > this means it cannot be currently tested. Are you sure that there are no > warnings in all DTBs with your patches? > Yes, I ran dtbs_check. I don’t see any warnings. Thanks, Kavya > > Best regards, > Krzysztof
On 13/09/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote: >>>>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed >>>> ('dma- >>>>> names', 'dmas' were unexpected) >>>>> arch/arm/boot/dts/at91-kizbox3-hs.dtb >>>>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb >>>>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb >>>>> arch/arm/boot/dts/at91-sama5d2_icp.dtb >>>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb >>>>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb >>>> >>>> dma properties for spi node is already being covered by Sergiu in below >>>> patch: >>>> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- >>>> 751a48545576@linaro.org/ >>>> >>> Hi Rob, Please let me know your comments. >> >> this means it cannot be currently tested. Are you sure that there are no >> warnings in all DTBs with your patches? >> > Yes, I ran dtbs_check. I don’t see any warnings. Then the warning could be probably ignored (I assume it is really fixed when both patchsets land). Best regards, Krzysztof
> On 13/09/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote: > >>>>> flexcom@fc018000: spi@400: Unevaluated properties are not allowed > >>>> ('dma- > >>>>> names', 'dmas' were unexpected) > >>>>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > >>>>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > >>>>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > >>>> > >>>> dma properties for spi node is already being covered by Sergiu in below > >>>> patch: > >>>> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > >>>> 751a48545576@linaro.org/ > >>>> > >>> Hi Rob, Please let me know your comments. > >> > >> this means it cannot be currently tested. Are you sure that there are no > >> warnings in all DTBs with your patches? > >> > > Yes, I ran dtbs_check. I don’t see any warnings. > > Then the warning could be probably ignored (I assume it is really fixed > when both patchsets land). > Yes. You are right. > > Best regards, > Krzysztof
> > On 13/09/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote: > > >>>>> flexcom@fc018000: spi@400: Unevaluated properties are not > allowed > > >>>> ('dma- > > >>>>> names', 'dmas' were unexpected) > > >>>>> arch/arm/boot/dts/at91-kizbox3-hs.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_icp.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb > > >>>>> arch/arm/boot/dts/at91-sama5d2_xplained.dtb > > >>>> > > >>>> dma properties for spi node is already being covered by Sergiu in > below > > >>>> patch: > > >>>> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854- > > >>>> 751a48545576@linaro.org/ > > >>>> > > >>> Hi Rob, Please let me know your comments. > > >> > > >> this means it cannot be currently tested. Are you sure that there are no > > >> warnings in all DTBs with your patches? > > >> > > > Yes, I ran dtbs_check. I don’t see any warnings. > > > > Then the warning could be probably ignored (I assume it is really fixed > > when both patchsets land). > > > Yes. You are right. > Hi All, Please let me know your comments on this patch series. Thanks, Kavya > > > > Best regards, > > Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml new file mode 100644 index 000000000000..63849dacefb8 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml @@ -0,0 +1,91 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Atmel Flexcom (Flexible Serial Communication Unit) + +maintainers: + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> + +description: + The Atmel Flexcom is just a wrapper which embeds a SPI controller, + an I2C controller and an USART. Only one function can be used at a + time and is chosen at boot time according to the device tree. + +properties: + compatible: + enum: + - atmel,sama5d2-flexcom + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: + description: + One range for the full I/O register region. (including USART, + TWI and SPI registers). + items: + maxItems: 3 + + atmel,flexcom-mode: + description: | + Specifies the flexcom mode as follows: + 1: USART + 2: SPI + 3: I2C. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 2, 3] + +patternProperties: + "^serial@[0-9a-f]+$": + type: object + description: + Child node describing USART. See atmel-usart.txt for details + of USART bindings. + + "^spi@[0-9a-f]+$": + $ref: ../spi/atmel,at91rm9200-spi.yaml + description: + Child node describing SPI. + + "^i2c@[0-9a-f]+$": + $ref: ../i2c/atmel,at91sam-i2c.yaml + description: + Child node describing I2C. + +required: + - compatible + - reg + - clocks + - "#address-cells" + - "#size-cells" + - ranges + - atmel,flexcom-mode + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + flx0: flexcom@f8034000 { + compatible = "atmel,sama5d2-flexcom"; + reg = <0xf8034000 0x200>; + clocks = <&flx0_clk>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0xf8034000 0x800>; + atmel,flexcom-mode = <2>; + }; +... diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt deleted file mode 100644 index 9d837535637b..000000000000 --- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt +++ /dev/null @@ -1,63 +0,0 @@ -* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit) - -The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C -controller and an USART. Only one function can be used at a time and is chosen -at boot time according to the device tree. - -Required properties: -- compatible: Should be "atmel,sama5d2-flexcom" -- reg: Should be the offset/length value for Flexcom dedicated - I/O registers (without USART, TWI or SPI registers). -- clocks: Should be the Flexcom peripheral clock from PMC. -- #address-cells: Should be <1> -- #size-cells: Should be <1> -- ranges: Should be one range for the full I/O register region - (including USART, TWI and SPI registers). -- atmel,flexcom-mode: Should be one of the following values: - - <1> for USART - - <2> for SPI - - <3> for I2C - -Required child: -A single available child device of type matching the "atmel,flexcom-mode" -property. - -The phandle provided by the clocks property of the child is the same as one for -the Flexcom parent. - -For other properties, please refer to the documentations of the respective -device: -- ../serial/atmel-usart.txt -- ../spi/spi_atmel.txt -- ../i2c/i2c-at91.txt - -Example: - -flexcom@f8034000 { - compatible = "atmel,sama5d2-flexcom"; - reg = <0xf8034000 0x200>; - clocks = <&flx0_clk>; - #address-cells = <1>; - #size-cells = <1>; - ranges = <0x0 0xf8034000 0x800>; - atmel,flexcom-mode = <2>; - - spi@400 { - compatible = "atmel,at91rm9200-spi"; - reg = <0x400 0x200>; - interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>; - pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_flx0_default>; - #address-cells = <1>; - #size-cells = <0>; - clocks = <&flx0_clk>; - clock-names = "spi_clk"; - atmel,fifo-size = <32>; - - flash@0 { - compatible = "atmel,at25f512b"; - reg = <0>; - spi-max-frequency = <20000000>; - }; - }; -};
Convert the Atmel flexcom device tree bindings to json schema. Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com> --- v8 -> v9: - Changed reference provided for spi bindings to atmel,at91rm9200-spi.yaml v7 -> v8: - Added back patternProperties for child nodes. v6 -> v7: - Change filename to atmel,sama5d2-flexcom.yaml - Add #address-cells, #size-cells to flexcom node - Fixed warnings. v5 -> v6: - Removed spi node from example as suggested by Rob and also pattern properties(spi dt-bindings conversion to yaml patch is under review). Once that is accepted, I will add back spi example through new patch. v4 -> v5: - Fixed indentations. v3 -> v4: - Corrected format of enum used for compatible string. v2 -> v3: - used enum for compatible string. - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example. - fixed dtschema errors. v1 -> v2: - Fix title. .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91 +++++++++++++++++++ .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ------------- 2 files changed, 91 insertions(+), 63 deletions(-) create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt