[v3,0/3] SDM670 Global Clocks

Message

Richard Acayan Sept. 8, 2022, 11:12 p.m. UTC

Changes since v2:
 - drop GCC_SDCC1_BCR reset
 - reorder gcc-sdm845 and gcc-sdm670 if statements in bindings
 - add space
 - accumulate review tags

Changes since v1:
 - regenerate patches to fixed malformed patch
 - fix schema so that the parent clocks are specified correctly
 - remove core_bi_test_pll_se from new parent_data to match array sizes
 - reference correct frequency table for gcc_sdm670_cpuss_rbcpr_clk_src
 - set correct index for sdcc1_ice_core_clk_src

This patch series adds global clocks essential for features of the Qualcomm
Snapdragon 670 (hopefully) cleanly into the SDM845 driver without doing
runtime fixups like in Google's bonito kernel (see patch 3).

This series (mostly patch 2) affects kernels made for Snapdragon 845 and
might need some further testing on SDM845 devices. I do not have a
Snapdragon 845-based device so someone else will have to double check if
necessary.

 .../devicetree/bindings/clock/qcom,gcc-sdm845.yaml |  61 +++-
 drivers/clk/qcom/Kconfig                           |   4 +-
 drivers/clk/qcom/gcc-sdm845.c                      | 400 ++++++++++++++++++++-
 include/dt-bindings/clock/qcom,gcc-sdm845.h        |   1 +
 4 files changed, 449 insertions(+), 17 deletions(-)

Comments

Bjorn Andersson Sept. 15, 2022, 3:36 a.m. UTC | #1

On Thu, 8 Sep 2022 19:12:21 -0400, Richard Acayan wrote:
> Changes since v2:
>  - drop GCC_SDCC1_BCR reset
>  - reorder gcc-sdm845 and gcc-sdm670 if statements in bindings
>  - add space
>  - accumulate review tags
> 
> Changes since v1:
>  - regenerate patches to fixed malformed patch
>  - fix schema so that the parent clocks are specified correctly
>  - remove core_bi_test_pll_se from new parent_data to match array sizes
>  - reference correct frequency table for gcc_sdm670_cpuss_rbcpr_clk_src
>  - set correct index for sdcc1_ice_core_clk_src
> 
> [...]

Applied, thanks!

[1/3] dt-bindings: clock: gcc-sdm845: add sdm670 global clocks
      commit: 657e9326658c1c570eb1e8fd122a4a7936433673
[2/3] clk: qcom: gcc-sdm845: use device tree match data
      commit: 8e90216d2db99f0b883be3b40d5b581437dc4a5d
[3/3] clk: qcom: gcc-sdm845: add sdm670 global clock data
      commit: ae66b1fe48e2dd91229f2b8f25295bce629382d0

Best regards,