| Message ID | 20220915075028.644-4-rex-bc.chen@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Refactor MediaTek DP drivers | expand |
Il 15/09/22 09:50, Bo-Chen Chen ha scritto: > Warning: > ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ > expects argument of type ‘unsigned int’, but argument 4 has type ‘long > unsigned int’ [-Wformat=] > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../include/linux/dev_printk.h:129:27: note: in definition of macro ‘dev_printk’ > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > ../include/linux/dev_printk.h:163:31: note: in expansion of macro ‘dev_fmt’ > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:2: note: in expansion of > macro ‘dev_dbg’ > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:36: note: format string is defined here > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ~^ > | | > | unsigned int > | %lx > > To fix this issue, we use %s to replace 0x%x. > > Reported-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> Please add a Fixes tag to this commit. Thanks, Angelo.
On 15/09/2022 09:50, Bo-Chen Chen wrote: > Warning: > ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ > expects argument of type ‘unsigned int’, but argument 4 has type ‘long > unsigned int’ [-Wformat=] > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ../include/linux/dev_printk.h:129:27: note: in definition of macro ‘dev_printk’ > 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ > | ^~~ > ../include/linux/dev_printk.h:163:31: note: in expansion of macro ‘dev_fmt’ > 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:2: note: in expansion of > macro ‘dev_dbg’ > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ^~~~~~~ > ../drivers/gpu/drm/mediatek/mtk_dp.c:947:36: note: format string is defined here > 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > | ~^ > | | > | unsigned int > | %lx > > To fix this issue, we use %s to replace 0x%x. > > Reported-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > drivers/gpu/drm/mediatek/mtk_dp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c > index c72c646e25e9..d58e98b2f83a 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dp.c > +++ b/drivers/gpu/drm/mediatek/mtk_dp.c > @@ -1222,8 +1222,8 @@ static void mtk_dp_video_mute(struct mtk_dp *mtk_dp, bool enable) > mtk_dp->data->smc_cmd, enable, > 0, 0, 0, 0, 0, &res); > > - dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", > - mtk_dp->data->smc_cmd, enable, res.a0, res.a1); > + dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: %s, ret: 0x%lx-0x%lx\n", > + mtk_dp->data->smc_cmd, enable ? "enable" : "disable", res.a0, res.a1); > } > > static void mtk_dp_audio_mute(struct mtk_dp *mtk_dp, bool mute)
diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c b/drivers/gpu/drm/mediatek/mtk_dp.c index c72c646e25e9..d58e98b2f83a 100644 --- a/drivers/gpu/drm/mediatek/mtk_dp.c +++ b/drivers/gpu/drm/mediatek/mtk_dp.c @@ -1222,8 +1222,8 @@ static void mtk_dp_video_mute(struct mtk_dp *mtk_dp, bool enable) mtk_dp->data->smc_cmd, enable, 0, 0, 0, 0, 0, &res); - dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", - mtk_dp->data->smc_cmd, enable, res.a0, res.a1); + dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: %s, ret: 0x%lx-0x%lx\n", + mtk_dp->data->smc_cmd, enable ? "enable" : "disable", res.a0, res.a1); } static void mtk_dp_audio_mute(struct mtk_dp *mtk_dp, bool mute)
Warning: ../drivers/gpu/drm/mediatek/mtk_dp.c: In function ‘mtk_dp_video_mute’: ../drivers/gpu/drm/mediatek/mtk_dp.c:947:23: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘long unsigned int’ [-Wformat=] 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../include/linux/dev_printk.h:129:27: note: in definition of macro ‘dev_printk’ 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~ ../include/linux/dev_printk.h:163:31: note: in expansion of macro ‘dev_fmt’ 163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ | ^~~~~~~ ../drivers/gpu/drm/mediatek/mtk_dp.c:947:2: note: in expansion of macro ‘dev_dbg’ 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", | ^~~~~~~ ../drivers/gpu/drm/mediatek/mtk_dp.c:947:36: note: format string is defined here 947 | dev_dbg(mtk_dp->dev, "smc cmd: 0x%x, p1: 0x%x, ret: 0x%lx-0x%lx\n", | ~^ | | | unsigned int | %lx To fix this issue, we use %s to replace 0x%x. Reported-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)