Message ID | dbdcffd009302734fe2fb895ce04b72fa1ea4355.1663165000.git.geert+renesas@glider.be |
---|---|
State | Accepted |
Commit | 92086b884caf6ff02fda75084a331e70b0e26f81 |
Headers | show |
Series | [v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to json-schema | expand |
On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote: > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation > to json-schema. > > Add missing properties. > Rename the device node from "usb-phy" to "usb-phy-controller", as it > does not represent a USB PHY itself, and thus does not have a > "#phy-cells" property. > Rename the child nodes from "usb-channel" to "usb-phy", as these do > represent USB PHYs. > Drop the second example, as it doesn't add any value. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Rename nodes to fix "'#phy-cells' is a required property". > > This is the final conversion to json-schema of DT bindings for Renesas > ARM SoCs, hurray! > > Note that there are still a few plain text bindings left for Renesas IP > cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). > --- > .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- > .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ > 2 files changed, 123 insertions(+), 112 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/ usb-phy@e6590100: 'usb-channel@0' does not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+' arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb usb-phy@e6590100: 'usb-channel@0', 'usb-channel@2' do not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+' arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb arch/arm/boot/dts/r8a7743-sk-rzg1m.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb arch/arm/boot/dts/r8a7745-sk-rzg1e.dtb arch/arm/boot/dts/r8a7790-lager.dtb arch/arm/boot/dts/r8a7790-stout.dtb arch/arm/boot/dts/r8a7791-koelsch.dtb arch/arm/boot/dts/r8a7791-porter.dtb arch/arm/boot/dts/r8a7794-alt.dtb arch/arm/boot/dts/r8a7794-silk.dtb usb-phy@e6590100: 'usb-phy@0' is a required property arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb arch/arm/boot/dts/r8a7790-lager.dtb arch/arm/boot/dts/r8a7790-stout.dtb arch/arm/boot/dts/r8a7791-koelsch.dtb arch/arm/boot/dts/r8a7791-porter.dtb arch/arm/boot/dts/r8a7794-alt.dtb arch/arm/boot/dts/r8a7794-silk.dtb usb-phy@e6590100: 'usb-phy@2' is a required property arch/arm/boot/dts/r8a7742-iwg21d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7742-iwg21d-q7.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7743-iwg20d-q7.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7-dbcm-ca.dtb arch/arm/boot/dts/r8a7744-iwg20d-q7.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dtb arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dtb arch/arm/boot/dts/r8a7790-lager.dtb arch/arm/boot/dts/r8a7790-stout.dtb arch/arm/boot/dts/r8a7791-koelsch.dtb arch/arm/boot/dts/r8a7791-porter.dtb arch/arm/boot/dts/r8a7794-alt.dtb arch/arm/boot/dts/r8a7794-silk.dtb usb-phy@e6598100: 'usb-channel@0' does not match any of the regexes: '^usb-phy@[02]$', 'pinctrl-[0-9]+' arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb usb-phy@e6598100: 'usb-phy@0' is a required property arch/arm/boot/dts/r8a77470-iwg23s-sbc.dtb
Hi Krzysztof, On Thu, Sep 15, 2022 at 10:35 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:> > On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote: > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation > > to json-schema. > > > > Add missing properties. > > Rename the device node from "usb-phy" to "usb-phy-controller", as it > > does not represent a USB PHY itself, and thus does not have a > > "#phy-cells" property. > > Rename the child nodes from "usb-channel" to "usb-phy", as these do > > represent USB PHYs. > > Drop the second example, as it doesn't add any value. > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > > v2: > > - Rename nodes to fix "'#phy-cells' is a required property". > > > > This is the final conversion to json-schema of DT bindings for Renesas > > ARM SoCs, hurray! > > > > Note that there are still a few plain text bindings left for Renesas IP > > cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). > > --- > > .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- > > .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ > > 2 files changed, 123 insertions(+), 112 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > > create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. These should be fixed by the DTS counterpart "[PATCH] ARM: dts: renesas: Fix USB PHY device and child node names" https://lore.kernel.org/all/6442b4042e26537abc8632c4772f8201685f1f1f.1663165098.git.geert+renesas@glider.be/> In hindsight, I should have cross-linked the patches in both directions, not just in one direction. Sorry for that. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On 15/09/2022 12:12, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Sep 15, 2022 at 10:35 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote:> >> On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote: >>> Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation >>> to json-schema. >>> >>> Add missing properties. >>> Rename the device node from "usb-phy" to "usb-phy-controller", as it >>> does not represent a USB PHY itself, and thus does not have a >>> "#phy-cells" property. >>> Rename the child nodes from "usb-channel" to "usb-phy", as these do >>> represent USB PHYs. >>> Drop the second example, as it doesn't add any value. >>> >>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> >>> --- >>> v2: >>> - Rename nodes to fix "'#phy-cells' is a required property". >>> >>> This is the final conversion to json-schema of DT bindings for Renesas >>> ARM SoCs, hurray! >>> >>> Note that there are still a few plain text bindings left for Renesas IP >>> cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). >>> --- >>> .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- >>> .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ >>> 2 files changed, 123 insertions(+), 112 deletions(-) >>> delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt >>> create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml >>> >> >> Running 'make dtbs_check' with the schema in this patch gives the >> following warnings. Consider if they are expected or the schema is >> incorrect. These may not be new warnings. > > These should be fixed by the DTS counterpart > "[PATCH] ARM: dts: renesas: Fix USB PHY device and child node names" > https://lore.kernel.org/all/6442b4042e26537abc8632c4772f8201685f1f1f.1663165098.git.geert+renesas@glider.be/> > > In hindsight, I should have cross-linked the patches in both > directions, not just in one direction. Sorry for that. No worries. Thanks for fixing it and error can be ignored. Best regards, Krzysztof
On Thu, 15 Sep 2022 12:12:48 +0100, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Thu, Sep 15, 2022 at 10:35 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote:> > > On Wed, 14 Sep 2022 16:17:37 +0200, Geert Uytterhoeven wrote: > > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation > > > to json-schema. > > > > > > Add missing properties. > > > Rename the device node from "usb-phy" to "usb-phy-controller", as it > > > does not represent a USB PHY itself, and thus does not have a > > > "#phy-cells" property. > > > Rename the child nodes from "usb-channel" to "usb-phy", as these do > > > represent USB PHYs. > > > Drop the second example, as it doesn't add any value. > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > --- > > > v2: > > > - Rename nodes to fix "'#phy-cells' is a required property". > > > > > > This is the final conversion to json-schema of DT bindings for Renesas > > > ARM SoCs, hurray! > > > > > > Note that there are still a few plain text bindings left for Renesas IP > > > cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). > > > --- > > > .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- > > > .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ > > > 2 files changed, 123 insertions(+), 112 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > > > create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml > > > > > > > Running 'make dtbs_check' with the schema in this patch gives the > > following warnings. Consider if they are expected or the schema is > > incorrect. These may not be new warnings. > > These should be fixed by the DTS counterpart > "[PATCH] ARM: dts: renesas: Fix USB PHY device and child node names" > https://lore.kernel.org/all/6442b4042e26537abc8632c4772f8201685f1f1f.1663165098.git.geert+renesas@glider.be/> > > In hindsight, I should have cross-linked the patches in both > directions, not just in one direction. Sorry for that. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > > > From git@z Thu Jan 1 00:00:00 1970 > Return-Path: <devicetree-owner@kernel.org> > X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on > aws-us-west-2-korg-lkml-1.web.codeaurora.org > Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) > by smtp.lore.kernel.org (Postfix) with ESMTP id 70230C6FA82 > for <linux-devicetree@archiver.kernel.org>; > Wed, 14 Sep 2022 14:33:50 +0000 (UTC) > Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand > id S230107AbiINOds (ORCPT > <rfc822;linux-devicetree@archiver.kernel.org>); > Wed, 14 Sep 2022 10:33:48 -0400 > Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO > lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org > with ESMTP id S230095AbiINOdr (ORCPT > <rfc822;devicetree@vger.kernel.org>); Wed, 14 Sep 2022 10:33:47 -0400 > Received: from andre.telenet-ops.be (andre.telenet-ops.be > [IPv6:2a02:1800:120:4::f00:15]) > by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D62BE2C125 > for <devicetree@vger.kernel.org>; > Wed, 14 Sep 2022 07:33:45 -0700 (PDT) > Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:e925:8cbe:2e99:b03b]) > by andre.telenet-ops.be with bizsmtp > id KqZi2800x3vs4GX01qZilT; Wed, 14 Sep 2022 16:33:43 +0200 > Received: from rox.of.borg ([192.168.97.57]) > by ramsan.of.borg with esmtps (TLS1.3) tls > TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 > (Exim 4.93) > (envelope-from <geert@linux-m68k.org>) > id 1oYTSQ-005B5L-8B; Wed, 14 Sep 2022 16:33:42 +0200 > Received: from geert by rox.of.borg with local (Exim 4.93) > (envelope-from <geert@linux-m68k.org>) > id 1oYTD1-000z8A-UK; Wed, 14 Sep 2022 16:17:47 +0200 > From: Geert Uytterhoeven <geert+renesas@glider.be> > To: Kishon Vijay Abraham I <kishon@ti.com>, > Vinod Koul <vkoul@kernel.org>, > Rob Herring <robh+dt@kernel.org>, > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, > Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, > linux-renesas-soc@vger.kernel.org, > Geert Uytterhoeven <geert+renesas@glider.be> > Subject: [PATCH v2] dt-bindings: phy: renesas,rcar-gen2-usb-phy: Convert to > json-schema > Date: Wed, 14 Sep 2022 16:17:37 +0200 > Message-Id: > <dbdcffd009302734fe2fb895ce04b72fa1ea4355.1663165000.git.geert+renesas@glider.be> > X-Mailer: git-send-email 2.25.1 > MIME-Version: 1.0 > Content-Transfer-Encoding: 8bit > Precedence: bulk > List-ID: <devicetree.vger.kernel.org> > X-Mailing-List: devicetree@vger.kernel.org > > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation > to json-schema. > > Add missing properties. > Rename the device node from "usb-phy" to "usb-phy-controller", as it > does not represent a USB PHY itself, and thus does not have a > "#phy-cells" property. > Rename the child nodes from "usb-channel" to "usb-phy", as these do > represent USB PHYs. > Drop the second example, as it doesn't add any value. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > v2: > - Rename nodes to fix "'#phy-cells' is a required property". > > This is the final conversion to json-schema of DT bindings for Renesas > ARM SoCs, hurray! > > Note that there are still a few plain text bindings left for Renesas IP > cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). > --- > .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- > .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ > 2 files changed, 123 insertions(+), 112 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt > create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml > Reviewed-by: Rob Herring <robh@kernel.org>
On 14-09-22, 16:17, Geert Uytterhoeven wrote: > Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation > to json-schema. Applied, thanks
diff --git a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt b/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt deleted file mode 100644 index a3bd1c4499b75bdb..0000000000000000 --- a/Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt +++ /dev/null @@ -1,112 +0,0 @@ -* Renesas R-Car generation 2 USB PHY - -This file provides information on what the device node for the R-Car generation -2 USB PHY contains. - -Required properties: -- compatible: "renesas,usb-phy-r8a7742" if the device is a part of R8A7742 SoC. - "renesas,usb-phy-r8a7743" if the device is a part of R8A7743 SoC. - "renesas,usb-phy-r8a7744" if the device is a part of R8A7744 SoC. - "renesas,usb-phy-r8a7745" if the device is a part of R8A7745 SoC. - "renesas,usb-phy-r8a77470" if the device is a part of R8A77470 SoC. - "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC. - "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC. - "renesas,usb-phy-r8a7794" if the device is a part of R8A7794 SoC. - "renesas,rcar-gen2-usb-phy" for a generic R-Car Gen2 or - RZ/G1 compatible device. - - When compatible with the generic version, nodes must list the - SoC-specific version corresponding to the platform first - followed by the generic version. - -- reg: offset and length of the register block. -- #address-cells: number of address cells for the USB channel subnodes, must - be <1>. -- #size-cells: number of size cells for the USB channel subnodes, must be <0>. -- clocks: clock phandle and specifier pair. -- clock-names: string, clock input name, must be "usbhs". - -The USB PHY device tree node should have the subnodes corresponding to the USB -channels. These subnodes must contain the following properties: -- reg: the USB controller selector; see the table below for the values. -- #phy-cells: see phy-bindings.txt in the same directory, must be <1>. - -The phandle's argument in the PHY specifier is the USB controller selector for -the USB channel other than r8a77470 SoC; see the selector meanings below: - -+-----------+---------------+---------------+ -|\ Selector | | | -+ --------- + 0 | 1 | -| Channel \| | | -+-----------+---------------+---------------+ -| 0 | PCI EHCI/OHCI | HS-USB | -| 2 | PCI EHCI/OHCI | xHCI | -+-----------+---------------+---------------+ - -For r8a77470 SoC;see the selector meaning below: - -+-----------+---------------+---------------+ -|\ Selector | | | -+ --------- + 0 | 1 | -| Channel \| | | -+-----------+---------------+---------------+ -| 0 | EHCI/OHCI | HS-USB | -+-----------+---------------+---------------+ - -Example (Lager board): - - usb-phy@e6590100 { - compatible = "renesas,usb-phy-r8a7790", "renesas,rcar-gen2-usb-phy"; - reg = <0 0xe6590100 0 0x100>; - #address-cells = <1>; - #size-cells = <0>; - clocks = <&cpg CPG_MOD 704>; - clock-names = "usbhs"; - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; - resets = <&cpg 704>; - - usb0: usb-channel@0 { - reg = <0>; - #phy-cells = <1>; - }; - usb2: usb-channel@2 { - reg = <2>; - #phy-cells = <1>; - }; - }; - -Example (iWave RZ/G1C sbc): - - usbphy0: usb-phy0@e6590100 { - compatible = "renesas,usb-phy-r8a77470", - "renesas,rcar-gen2-usb-phy"; - reg = <0 0xe6590100 0 0x100>; - #address-cells = <1>; - #size-cells = <0>; - clocks = <&cpg CPG_MOD 704>; - clock-names = "usbhs"; - power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; - resets = <&cpg 704>; - - usb0: usb-channel@0 { - reg = <0>; - #phy-cells = <1>; - }; - }; - - usbphy1: usb-phy@e6598100 { - compatible = "renesas,usb-phy-r8a77470", - "renesas,rcar-gen2-usb-phy"; - reg = <0 0xe6598100 0 0x100>; - #address-cells = <1>; - #size-cells = <0>; - clocks = <&cpg CPG_MOD 706>; - clock-names = "usbhs"; - power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; - resets = <&cpg 706>; - - usb1: usb-channel@0 { - reg = <0>; - #phy-cells = <1>; - }; - }; diff --git a/Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml new file mode 100644 index 0000000000000000..afc09f39b02bd2c4 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml @@ -0,0 +1,123 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/renesas,rcar-gen2-usb-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas R-Car Gen2 USB PHY + +maintainers: + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> + +properties: + compatible: + items: + - enum: + - renesas,usb-phy-r8a7742 # RZ/G1H + - renesas,usb-phy-r8a7743 # RZ/G1M + - renesas,usb-phy-r8a7744 # RZ/G1N + - renesas,usb-phy-r8a7745 # RZ/G1E + - renesas,usb-phy-r8a77470 # RZ/G1C + - renesas,usb-phy-r8a7790 # R-Car H2 + - renesas,usb-phy-r8a7791 # R-Car M2-W + - renesas,usb-phy-r8a7794 # R-Car E2 + - const: renesas,rcar-gen2-usb-phy # R-Car Gen2 or RZ/G1 + + reg: + maxItems: 1 + + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + + clocks: + maxItems: 1 + + clock-names: + items: + - const: usbhs + + power-domains: + maxItems: 1 + + resets: + maxItems: 1 + +patternProperties: + "^usb-phy@[02]$": + type: object + description: Subnode corresponding to a USB channel. + + properties: + reg: + description: FIXME RZ/G1C supports channel 0 only + enum: [0, 2] + + '#phy-cells': + description: | + The phandle's argument in the PHY specifier is the USB controller + selector for the USB channel. + For RZ/G1C: + - 0 for EHCI/OHCI + - 1 for HS-USB + For all other SoCS: + - 0 for PCI EHCI/OHCI + - 1 for HS-USB (channel 0) or xHCI (channel 2) + const: 1 + + required: + - reg + - '#phy-cells' + + additionalProperties: false + +required: + - compatible + - reg + - '#address-cells' + - '#size-cells' + - clocks + - clock-names + - resets + - power-domains + - usb-phy@0 + +if: + properties: + compatible: + contains: + const: renesas,usb-phy-r8a77470 +then: + properties: + usb-phy@2: false +else: + required: + - usb-phy@2 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/r8a7790-cpg-mssr.h> + #include <dt-bindings/power/r8a7790-sysc.h> + usb-phy-controller@e6590100 { + compatible = "renesas,usb-phy-r8a7790", "renesas,rcar-gen2-usb-phy"; + reg = <0xe6590100 0x100>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&cpg CPG_MOD 704>; + clock-names = "usbhs"; + power-domains = <&sysc R8A7790_PD_ALWAYS_ON>; + resets = <&cpg 704>; + + usb0: usb-phy@0 { + reg = <0>; + #phy-cells = <1>; + }; + usb2: usb-phy@2 { + reg = <2>; + #phy-cells = <1>; + }; + };
Convert the Renesas R-Car Gen2 USB PHY Device Tree binding documentation to json-schema. Add missing properties. Rename the device node from "usb-phy" to "usb-phy-controller", as it does not represent a USB PHY itself, and thus does not have a "#phy-cells" property. Rename the child nodes from "usb-channel" to "usb-phy", as these do represent USB PHYs. Drop the second example, as it doesn't add any value. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- v2: - Rename nodes to fix "'#phy-cells' is a required property". This is the final conversion to json-schema of DT bindings for Renesas ARM SoCs, hurray! Note that there are still a few plain text bindings left for Renesas IP cores that are present on non-Renesas SoCs (nbpfaxi and usdhi6rol0). --- .../devicetree/bindings/phy/rcar-gen2-phy.txt | 112 ---------------- .../phy/renesas,rcar-gen2-usb-phy.yaml | 123 ++++++++++++++++++ 2 files changed, 123 insertions(+), 112 deletions(-) delete mode 100644 Documentation/devicetree/bindings/phy/rcar-gen2-phy.txt create mode 100644 Documentation/devicetree/bindings/phy/renesas,rcar-gen2-usb-phy.yaml