mbox series

[0/7] drm/i915: Add HWMON support

Message ID 20220916150054.807590-1-badal.nilawar@intel.com (mailing list archive)
Headers show
Series drm/i915: Add HWMON support | expand

Message

Nilawar, Badal Sept. 16, 2022, 3 p.m. UTC 
This series adds the HWMON support for DGFX

Test-with: 20220914140721.3500129-1-riana.tauro@intel.com

v2:
  - Reorganized series. Created first patch as infrastructure patch
    followed by feature patches. (Ashutosh)
  - Fixed review comments (Jani)
  - Fixed review comments (Ashutosh)

v3:
  - Fixed review comments from Guenter
  - Exposed energy inferface as standard hwmon interface (Ashutosh)
  - For power interface added entries for critical power and maintained
    standard interface for all the entries except 
    power1_max_interval
  - Extended support for XEHPSDV (Ashutosh)

v4:
  - Fixed review comment from Guenter
  - Cleaned up unused code

v5:
  - Fixed review comments (Jani)

v6: 
  - Fixed review comments (Ashutosh)
  - Updated date and kernel version in documentation

Ashutosh Dixit (2):
  drm/i915/hwmon: Expose card reactive critical power
  drm/i915/hwmon: Expose power1_max_interval

Dale B Stimson (4):
  drm/i915/hwmon: Add HWMON infrastructure
  drm/i915/hwmon: Power PL1 limit and TDP setting
  drm/i915/hwmon: Show device level energy usage
  drm/i915/hwmon: Extend power/energy for XEHPSDV

Riana Tauro (1):
  drm/i915/hwmon: Add HWMON current voltage support

 .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
 drivers/gpu/drm/i915/Makefile                 |   3 +
 drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
 drivers/gpu/drm/i915/i915_driver.c            |   5 +
 drivers/gpu/drm/i915/i915_drv.h               |   2 +
 drivers/gpu/drm/i915/i915_hwmon.c             | 761 ++++++++++++++++++
 drivers/gpu/drm/i915/i915_hwmon.h             |  21 +
 drivers/gpu/drm/i915/i915_reg.h               |  14 +
 drivers/gpu/drm/i915/intel_mchbar_regs.h      |  12 +
 9 files changed, 901 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
 create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c
 create mode 100644 drivers/gpu/drm/i915/i915_hwmon.h

Comments

Gupta, Anshuman Sept. 19, 2022, 10:15 a.m. UTC | #1 
> -----Original Message-----
> From: Nilawar, Badal <badal.nilawar@intel.com>
> Sent: Friday, September 16, 2022 8:31 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Dixit, Ashutosh <ashutosh.dixit@intel.com>; Tauro, Riana
> <riana.tauro@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>;
> Ewins, Jon <jon.ewins@intel.com>; linux-hwmon@vger.kernel.org; dri-
> devel@lists.freedesktop.org
> Subject: [PATCH 0/7] drm/i915: Add HWMON support
> 
> This series adds the HWMON support for DGFX
> 
> Test-with: 20220914140721.3500129-1-riana.tauro@intel.com
CI-BAT is failing with this series,
Could you please check the failures, whether related to this series ?

Thanks,
Anshuman Gupta. 
> 
> v2:
>   - Reorganized series. Created first patch as infrastructure patch
>     followed by feature patches. (Ashutosh)
>   - Fixed review comments (Jani)
>   - Fixed review comments (Ashutosh)
> 
> v3:
>   - Fixed review comments from Guenter
>   - Exposed energy inferface as standard hwmon interface (Ashutosh)
>   - For power interface added entries for critical power and maintained
>     standard interface for all the entries except
>     power1_max_interval
>   - Extended support for XEHPSDV (Ashutosh)
> 
> v4:
>   - Fixed review comment from Guenter
>   - Cleaned up unused code
> 
> v5:
>   - Fixed review comments (Jani)
> 
> v6:
>   - Fixed review comments (Ashutosh)
>   - Updated date and kernel version in documentation
> 
> Ashutosh Dixit (2):
>   drm/i915/hwmon: Expose card reactive critical power
>   drm/i915/hwmon: Expose power1_max_interval
> 
> Dale B Stimson (4):
>   drm/i915/hwmon: Add HWMON infrastructure
>   drm/i915/hwmon: Power PL1 limit and TDP setting
>   drm/i915/hwmon: Show device level energy usage
>   drm/i915/hwmon: Extend power/energy for XEHPSDV
> 
> Riana Tauro (1):
>   drm/i915/hwmon: Add HWMON current voltage support
> 
>  .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
>  drivers/gpu/drm/i915/Makefile                 |   3 +
>  drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
>  drivers/gpu/drm/i915/i915_driver.c            |   5 +
>  drivers/gpu/drm/i915/i915_drv.h               |   2 +
>  drivers/gpu/drm/i915/i915_hwmon.c             | 761 ++++++++++++++++++
>  drivers/gpu/drm/i915/i915_hwmon.h             |  21 +
>  drivers/gpu/drm/i915/i915_reg.h               |  14 +
>  drivers/gpu/drm/i915/intel_mchbar_regs.h      |  12 +
>  9 files changed, 901 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
>  create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c  create mode
> 100644 drivers/gpu/drm/i915/i915_hwmon.h
> 
> --
> 2.25.1
Nilawar, Badal Sept. 19, 2022, 10:45 a.m. UTC | #2 
Quoting lakshminarayana.vudum@intel.com

On 16-09-2022 23:29, Patchwork wrote:
> *Patch Details*
> *Series:*	drm/i915: Add HWMON support (rev6)
> *URL:*	https://patchwork.freedesktop.org/series/104278/ 
> <https://patchwork.freedesktop.org/series/104278/>
> *State:*	failure
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/index.html 
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/index.html>
> 
> 
>   CI Bug Log - changes from CI_DRM_12146 -> Patchwork_104278v6
> 
> 
>     Summary
> 
> *FAILURE*
> 
> Serious unknown changes coming with Patchwork_104278v6 absolutely need to be
> verified manually.
> 
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_104278v6, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
> 
> External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/index.html
> 
> 
>     Participating hosts (44 -> 39)
> 
> Additional (1): fi-kbl-guc
> Missing (6): fi-rkl-11600 fi-hsw-4200u bat-dg2-8 fi-icl-u2 fi-ctg-p8600 
> fi-bdw-samus
> 
> 
>     Possible new issues
> 
> Here are the unknown changes that may have been introduced in 
> Patchwork_104278v6:
> 
> 
>       IGT changes
> 
> 
>         Possible regressions
> 
>   * igt@debugfs_test@read_all_entries:
>       o fi-pnv-d510: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12146/fi-pnv-d510/igt@debugfs_test@read_all_entries.html> -> INCOMPLETE <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-pnv-d510/igt@debugfs_test@read_all_entries.html>
This issue is not related to my patch series. Looks like this patch is 
trying to handle it https://patchwork.freedesktop.org/series/108686/
It was reported initially here 
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108091v4/fi-pnv-d510/igt@debugfs_test@read_all_entries.html#dmesg-warnings71 


Regards,
Badal
> 
> 
>     Known issues
> 
> Here are the changes found in Patchwork_104278v6 that come from known 
> issues:
> 
> 
>       IGT changes
> 
> 
>         Issues hit
> 
>   *
> 
>     igt@i915_selftest@live@hangcheck:
> 
>       o fi-hsw-4770: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12146/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> -> INCOMPLETE <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-hsw-4770/igt@i915_selftest@live@hangcheck.html> (i915#4785 <https://gitlab.freedesktop.org/drm/intel/issues/4785>)
>   *
> 
>     igt@runner@aborted:
> 
>       o
> 
>         fi-hsw-4770: NOTRUN -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-hsw-4770/igt@runner@aborted.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312> / i915#5594 <https://gitlab.freedesktop.org/drm/intel/issues/5594> / i915#6246 <https://gitlab.freedesktop.org/drm/intel/issues/6246>)
> 
>       o
> 
>         fi-kbl-guc: NOTRUN -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-kbl-guc/igt@runner@aborted.html> (i915#6219 <https://gitlab.freedesktop.org/drm/intel/issues/6219>)
> 
> 
>         Possible fixes
> 
>   *
> 
>     igt@i915_module_load@reload:
> 
>       o {fi-tgl-mst}: WARN
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12146/fi-tgl-mst/igt@i915_module_load@reload.html> (i915#6596 <https://gitlab.freedesktop.org/drm/intel/issues/6596>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-tgl-mst/igt@i915_module_load@reload.html>
>   *
> 
>     igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
> 
>       o fi-bsw-kefka: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12146/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html> (i915#6298 <https://gitlab.freedesktop.org/drm/intel/issues/6298>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html>
> 
> 
>         Warnings
> 
>   * igt@runner@aborted:
>       o fi-pnv-d510: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12146/fi-pnv-d510/igt@runner@aborted.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2403 <https://gitlab.freedesktop.org/drm/intel/issues/2403> / i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>) -> FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_104278v6/fi-pnv-d510/igt@runner@aborted.html> (i915#2403 <https://gitlab.freedesktop.org/drm/intel/issues/2403> / i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>)
> 
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
> 
>     Build changes
> 
>   * IGT: IGT_6656 -> IGTPW_7782
>   * Linux: CI_DRM_12146 -> Patchwork_104278v6
> 
> CI-20190529: 20190529
> CI_DRM_12146: afdeadb1830054a87b9e2d765caa2f197321ca0c @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGTPW_7782: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7782/index.html
> IGT_6656: 24100c4e181c50e3678aeca9c641b8a43555ad73 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_104278v6: afdeadb1830054a87b9e2d765caa2f197321ca0c @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
>       Linux commits
> 
> e0d313f9824e drm/i915/hwmon: Extend power/energy for XEHPSDV
> 838370702cd9 drm/i915/hwmon: Expose power1_max_interval
> 2ce87f02bcab drm/i915/hwmon: Expose card reactive critical power
> e854da3eb44c drm/i915/hwmon: Show device level energy usage
> 9bd6d1d4bb2d drm/i915/hwmon: Power PL1 limit and TDP setting
> 6be6b6797886 drm/i915/hwmon: Add HWMON current voltage support
> 36f18098a1aa drm/i915/hwmon: Add HWMON infrastructure
>
Nilawar, Badal Sept. 19, 2022, 12:13 p.m. UTC | #3 
On 19-09-2022 15:45, Gupta, Anshuman wrote:
> 
> 
>> -----Original Message-----
>> From: Nilawar, Badal <badal.nilawar@intel.com>
>> Sent: Friday, September 16, 2022 8:31 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Dixit, Ashutosh <ashutosh.dixit@intel.com>; Tauro, Riana
>> <riana.tauro@intel.com>; Gupta, Anshuman <anshuman.gupta@intel.com>;
>> Ewins, Jon <jon.ewins@intel.com>; linux-hwmon@vger.kernel.org; dri-
>> devel@lists.freedesktop.org
>> Subject: [PATCH 0/7] drm/i915: Add HWMON support
>>
>> This series adds the HWMON support for DGFX
>>
>> Test-with: 20220914140721.3500129-1-riana.tauro@intel.com
> CI-BAT is failing with this series,
> Could you please check the failures, whether related to this series ?
Thanks for pointing out. I checked the failures, those are not related 
to this series. I responded to "✗ Fi.CI.BAT: failure" thread

Regards,
Badal Nilawar
> 
> Thanks,
> Anshuman Gupta.
>>
>> v2:
>>    - Reorganized series. Created first patch as infrastructure patch
>>      followed by feature patches. (Ashutosh)
>>    - Fixed review comments (Jani)
>>    - Fixed review comments (Ashutosh)
>>
>> v3:
>>    - Fixed review comments from Guenter
>>    - Exposed energy inferface as standard hwmon interface (Ashutosh)
>>    - For power interface added entries for critical power and maintained
>>      standard interface for all the entries except
>>      power1_max_interval
>>    - Extended support for XEHPSDV (Ashutosh)
>>
>> v4:
>>    - Fixed review comment from Guenter
>>    - Cleaned up unused code
>>
>> v5:
>>    - Fixed review comments (Jani)
>>
>> v6:
>>    - Fixed review comments (Ashutosh)
>>    - Updated date and kernel version in documentation
>>
>> Ashutosh Dixit (2):
>>    drm/i915/hwmon: Expose card reactive critical power
>>    drm/i915/hwmon: Expose power1_max_interval
>>
>> Dale B Stimson (4):
>>    drm/i915/hwmon: Add HWMON infrastructure
>>    drm/i915/hwmon: Power PL1 limit and TDP setting
>>    drm/i915/hwmon: Show device level energy usage
>>    drm/i915/hwmon: Extend power/energy for XEHPSDV
>>
>> Riana Tauro (1):
>>    drm/i915/hwmon: Add HWMON current voltage support
>>
>>   .../ABI/testing/sysfs-driver-intel-i915-hwmon |  75 ++
>>   drivers/gpu/drm/i915/Makefile                 |   3 +
>>   drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   8 +
>>   drivers/gpu/drm/i915/i915_driver.c            |   5 +
>>   drivers/gpu/drm/i915/i915_drv.h               |   2 +
>>   drivers/gpu/drm/i915/i915_hwmon.c             | 761 ++++++++++++++++++
>>   drivers/gpu/drm/i915/i915_hwmon.h             |  21 +
>>   drivers/gpu/drm/i915/i915_reg.h               |  14 +
>>   drivers/gpu/drm/i915/intel_mchbar_regs.h      |  12 +
>>   9 files changed, 901 insertions(+)
>>   create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
>>   create mode 100644 drivers/gpu/drm/i915/i915_hwmon.c  create mode
>> 100644 drivers/gpu/drm/i915/i915_hwmon.h
>>
>> --
>> 2.25.1
>