| Message ID | 20220919174423.31146-1-vfedorenko@novek.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: bnxt: replace reset with config timestamps | expand |
On 19.09.2022 18:44, Vadim Fedorenko wrote: > Any change to the hardware timestamps configuration triggers nic restart, > which breaks transmition and reception of network packets for a while. > But there is no need to fully restart the device because while configuring > hardware timestamps. The code for changing configuration runs after all > of the initialisation, when the NIC is actually up and running. This patch > changes the code that ioctl will only update configuration registers and > will not trigger carrier status change. Tested on BCM57504. > Ignore this one, plz. I'll send another with proper subject and Fixes tag.
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 8e316367f6ce..36e9148468b5 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -505,10 +505,8 @@ static int bnxt_hwrm_ptp_cfg(struct bnxt *bp) ptp->tstamp_filters = flags; if (netif_running(bp->dev)) { - rc = bnxt_close_nic(bp, false, false); - if (!rc) - rc = bnxt_open_nic(bp, false, false); - if (!rc && !ptp->tstamp_filters) + bnxt_ptp_cfg_tstamp_filters(bp); + if (!ptp->tstamp_filters) rc = -EIO; }
Any change to the hardware timestamps configuration triggers nic restart, which breaks transmition and reception of network packets for a while. But there is no need to fully restart the device because while configuring hardware timestamps. The code for changing configuration runs after all of the initialisation, when the NIC is actually up and running. This patch changes the code that ioctl will only update configuration registers and will not trigger carrier status change. Tested on BCM57504. Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)