Message ID | 20220912075045.17060-1-xu.panda@zte.com.cn (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | [linux-next] net: dsa: microchip: remove the unneeded result variable ------------------------------------------------------------------------- | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
On Mon, 12 Sep 2022 07:50:46 +0000 cgel.zte@gmail.com wrote: > Subject: [PATCH linux-next] net: dsa: microchip: remove the unneeded result variable ------------------------------------------------------------------------- > Date: Mon, 12 Sep 2022 07:50:46 +0000 > Return the value ksz_get_xmii() directly instead of storing it in > another redundant variable. Does not apply either, also the subject is off.
diff --git a/drivers/net/dsa/microchip/ksz9477.c b/drivers/net/dsa/microchip/ksz9477.c index 42d7e4c12459..ab7245b24493 100644 --- a/drivers/net/dsa/microchip/ksz9477.c +++ b/drivers/net/dsa/microchip/ksz9477.c @@ -884,7 +884,6 @@ void ksz9477_port_mirror_del(struct ksz_device *dev, int port, static phy_interface_t ksz9477_get_interface(struct ksz_device *dev, int port) { - phy_interface_t interface; bool gbit; if (dev->info->internal_phy[port]) @@ -892,9 +891,7 @@ static phy_interface_t ksz9477_get_interface(struct ksz_device *dev, int port) gbit = ksz_get_gbit(dev, port); - interface = ksz_get_xmii(dev, port, gbit); - - return interface; + return ksz_get_xmii(dev, port, gbit); } static void ksz9477_port_mmd_write(struct ksz_device *dev, int port,