| Message ID | 20220909092035.223915-9-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | ARM/hwlock: qcom: switch TCSR mutex to MMIO | expand |
On 09/09/2022 12:20, Krzysztof Kozlowski wrote: > TCSR syscon node should come with dedicated compatible. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index 166374566a49..5f45d0589265 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -3499,7 +3499,7 @@ frame@98c0000 { > }; > > saw3: syscon@9a10000 { > - compatible = "syscon"; > + compatible = "qcom,tcsr-msm8996", "syscon"; No! saw3 is not a TCSR. It is a separate region, which should be managed by the SPM driver. > reg = <0x09a10000 0x1000>; > }; >
On 20/09/2022 00:13, Dmitry Baryshkov wrote: > On 09/09/2022 12:20, Krzysztof Kozlowski wrote: >> TCSR syscon node should come with dedicated compatible. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> index 166374566a49..5f45d0589265 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi >> @@ -3499,7 +3499,7 @@ frame@98c0000 { >> }; >> >> saw3: syscon@9a10000 { >> - compatible = "syscon"; >> + compatible = "qcom,tcsr-msm8996", "syscon"; > > No! saw3 is not a TCSR. It is a separate region, which should be managed > by the SPM driver. Indeed. Thanks for checking this. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 166374566a49..5f45d0589265 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi @@ -3499,7 +3499,7 @@ frame@98c0000 { }; saw3: syscon@9a10000 { - compatible = "syscon"; + compatible = "qcom,tcsr-msm8996", "syscon"; reg = <0x09a10000 0x1000>; };
TCSR syscon node should come with dedicated compatible. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)