| Message ID | 20220915234932.25497-1-vfedorenko@novek.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ae8ffba8baad651af706538e8c47d0a049d406c6 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | bnxt_en: fix flags to check for supported fw version | expand |
On Fri, Sep 16, 2022 at 02:49:32AM +0300, Vadim Fedorenko wrote: > The warning message of unsupported FW appears every time RX timestamps > are disabled on the interface. The patch fixes the flags to correct set > for the check. Looks good to me. Thanks for sending this. > Fixes: 66ed81dcedc6 ("bnxt_en: Enable packet timestamping for all RX packets") > Cc: Richard Cochran <richardcochran@gmail.com> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> Reviewed-by: Andy Gospodarek <gospo@broadcom.com> > --- > drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c > index 7f3c0875b6f5..8e316367f6ce 100644 > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c > @@ -317,9 +317,9 @@ void bnxt_ptp_cfg_tstamp_filters(struct bnxt *bp) > > if (!(bp->fw_cap & BNXT_FW_CAP_RX_ALL_PKT_TS) && (ptp->tstamp_filters & > (PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE | > - PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE))) { > + PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE))) { > ptp->tstamp_filters &= ~(PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE | > - PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE); > + PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE); > netdev_warn(bp->dev, "Unsupported FW for all RX pkts timestamp filter\n"); > } >
On Fri, Sep 16, 2022 at 11:31 AM Andy Gospodarek <andrew.gospodarek@broadcom.com> wrote: > > On Fri, Sep 16, 2022 at 02:49:32AM +0300, Vadim Fedorenko wrote: > > The warning message of unsupported FW appears every time RX timestamps > > are disabled on the interface. The patch fixes the flags to correct set > > for the check. > Looks good to me. Thanks for sending this. > > > Fixes: 66ed81dcedc6 ("bnxt_en: Enable packet timestamping for all RX packets") > > Cc: Richard Cochran <richardcochran@gmail.com> > > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> > Reviewed-by: Andy Gospodarek <gospo@broadcom.com> Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@kernel.org>: On Fri, 16 Sep 2022 02:49:32 +0300 you wrote: > The warning message of unsupported FW appears every time RX timestamps > are disabled on the interface. The patch fixes the flags to correct set > for the check. > > Fixes: 66ed81dcedc6 ("bnxt_en: Enable packet timestamping for all RX packets") > Cc: Richard Cochran <richardcochran@gmail.com> > Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> > > [...] Here is the summary with links: - bnxt_en: fix flags to check for supported fw version https://git.kernel.org/netdev/net/c/ae8ffba8baad You are awesome, thank you!
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 7f3c0875b6f5..8e316367f6ce 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -317,9 +317,9 @@ void bnxt_ptp_cfg_tstamp_filters(struct bnxt *bp) if (!(bp->fw_cap & BNXT_FW_CAP_RX_ALL_PKT_TS) && (ptp->tstamp_filters & (PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE | - PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE))) { + PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE))) { ptp->tstamp_filters &= ~(PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_ENABLE | - PORT_MAC_CFG_REQ_FLAGS_PTP_RX_TS_CAPTURE_DISABLE); + PORT_MAC_CFG_REQ_FLAGS_ALL_RX_TS_CAPTURE_DISABLE); netdev_warn(bp->dev, "Unsupported FW for all RX pkts timestamp filter\n"); }
The warning message of unsupported FW appears every time RX timestamps are disabled on the interface. The patch fixes the flags to correct set for the check. Fixes: 66ed81dcedc6 ("bnxt_en: Enable packet timestamping for all RX packets") Cc: Richard Cochran <richardcochran@gmail.com> Signed-off-by: Vadim Fedorenko <vfedorenko@novek.ru> --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)