| Message ID | 20220818124602.20394-1-johnson.wang@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] dt-bindings: timer: Add compatible for MediaTek MT8188 | expand |
On 18/08/2022 15:51, Krzysztof Kozlowski wrote: > On 18/08/2022 15:46, Johnson Wang wrote: >> Add dt-binding documentation of timer for MediaTek MT8188 SoC >> platform. >> >> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> index f1c848af91d3..8bbb6e94508b 100644 >> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> @@ -25,6 +25,7 @@ Required properties: >> For those SoCs that use SYST >> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) >> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) >> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) > > Where is the driver change implementing this? Or is there a generic fallback and you just added a specific one (not visible on the diff)? Best regards, Krzysztof
On Thu, 2022-08-18 at 16:40 +0300, Krzysztof Kozlowski wrote: > On 18/08/2022 15:51, Krzysztof Kozlowski wrote: > > On 18/08/2022 15:46, Johnson Wang wrote: > > > Add dt-binding documentation of timer for MediaTek MT8188 SoC > > > platform. > > > > > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > --- > > > Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | > > > 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > > > b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > > > index f1c848af91d3..8bbb6e94508b 100644 > > > --- a/Documentation/devicetree/bindings/timer/mediatek,mtk- > > > timer.txt > > > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk- > > > timer.txt > > > @@ -25,6 +25,7 @@ Required properties: > > > For those SoCs that use SYST > > > * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) > > > * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) > > > + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) > > > > Where is the driver change implementing this? > > Or is there a generic fallback and you just added a specific one (not > visible on the diff)? > > Best regards, > Krzysztof Hi Krzysztof, Yes, MT8188 uses "mediatek,mt6765-timer" as fallback compatible. BRs, Johnson Wang
On Thu, 2022-08-18 at 20:46 +0800, Johnson Wang wrote: > Add dt-binding documentation of timer for MediaTek MT8188 SoC > platform. > > Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk- > timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk- > timer.txt > index f1c848af91d3..8bbb6e94508b 100644 > --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > @@ -25,6 +25,7 @@ Required properties: > For those SoCs that use SYST > * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) > * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) > + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) > * "mediatek,mt8192-timer" for MT8192 compatible timers (SYST) > * "mediatek,mt8195-timer" for MT8195 compatible timers (SYST) > * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST) Hi Daniel, Just a gentle ping on this. Could you please review this patch and give us some suggestion? Thanks. BRs, Johnson Wang
On 20/09/2022 07:20, Johnson Wang wrote: > On Thu, 2022-08-18 at 20:46 +0800, Johnson Wang wrote: >> Add dt-binding documentation of timer for MediaTek MT8188 SoC >> platform. >> >> Signed-off-by: Johnson Wang <johnson.wang@mediatek.com> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk- >> timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk- >> timer.txt >> index f1c848af91d3..8bbb6e94508b 100644 >> --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt >> @@ -25,6 +25,7 @@ Required properties: >> For those SoCs that use SYST >> * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) >> * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) >> + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) >> * "mediatek,mt8192-timer" for MT8192 compatible timers (SYST) >> * "mediatek,mt8195-timer" for MT8195 compatible timers (SYST) >> * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST) > > Hi Daniel, > > Just a gentle ping on this. > Could you please review this patch and give us some suggestion? I've applied the patch Thanks -- D.
diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt index f1c848af91d3..8bbb6e94508b 100644 --- a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt @@ -25,6 +25,7 @@ Required properties: For those SoCs that use SYST * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) * "mediatek,mt8192-timer" for MT8192 compatible timers (SYST) * "mediatek,mt8195-timer" for MT8195 compatible timers (SYST) * "mediatek,mt7629-timer" for MT7629 compatible timers (SYST)