| Message ID | 20220919165808.1.Idfb956ebc035c3bd0d682f4697c297c7a975c50d@changeid (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | arm64: dts: qcom: sc7280: All current evoker boards are LTE | expand |
> At the time that commit 2abf6b6b9429 ("arm64: dts: qcom: sc7280: Add > device tree for herobrine evoker") was posted, all herobrine SKUs were > LTE. > > At the time that commit d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs > for sc7280-villager family"), the evoker board device tree hadn't yet > landed. > > I belive that the above two facts mean that the evoker boards ought to > be setup for LTE but currently aren't. Let's fix that. Evoker should also have wifi/lte SKU, I think we need to follow villager to create evoker.dtsi then separate wifi/lte dts.
Hi, On Tue, Sep 20, 2022 at 4:40 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > > At the time that commit 2abf6b6b9429 ("arm64: dts: qcom: sc7280: Add > > device tree for herobrine evoker") was posted, all herobrine SKUs were > > LTE. > > > > At the time that commit d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs > > for sc7280-villager family"), the evoker board device tree hadn't yet > > landed. > > > > I belive that the above two facts mean that the evoker boards ought to > > be setup for LTE but currently aren't. Let's fix that. > Evoker should also have wifi/lte SKU, > I think we need to follow villager to create evoker.dtsi then separate wifi/lte dts. OK, sounds good. I'm happy if you want to post patches for that. If you need me to then let me know, but you probably know better what hardware exists and at what version. -Doug
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts index ccbe50b6249a..5e5cddb8ec99 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts @@ -8,6 +8,7 @@ /dts-v1/; #include "sc7280-herobrine.dtsi" +#include "sc7280-herobrine-lte-sku.dtsi" / { model = "Google Evoker";
At the time that commit 2abf6b6b9429 ("arm64: dts: qcom: sc7280: Add device tree for herobrine evoker") was posted, all herobrine SKUs were LTE. At the time that commit d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family"), the evoker board device tree hadn't yet landed. I belive that the above two facts mean that the evoker boards ought to be setup for LTE but currently aren't. Let's fix that. Cc: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> Cc: Sibi Sankar <quic_sibis@quicinc.com> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm64/boot/dts/qcom/sc7280-herobrine-evoker-r0.dts | 1 + 1 file changed, 1 insertion(+)