| Message ID | 20220817080757.352021-3-bchihi@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add LVTS thermal architecture | expand |
On 17/08/2022 11:07, bchihi@baylibre.com wrote: > From: Alexandre Bailon <abailon@baylibre.com> > > Add dt-binding document for mt8192 and mt8195 LVTS thermal controllers. Rebase your patchset on decent kernel tree. You seem to use something a bit old. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > Co-developed-by: Balsam CHIHI <bchihi@baylibre.com> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > .../thermal/mediatek,lvts-thermal.yaml | 152 ++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..31d9e220513a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SoC LVTS thermal controller > + > +maintainers: > + - Yu-Chia Chang <ethan.chang@mediatek.com> > + - Ben Tseng <ben.tseng@mediatek.com> > + > +description: | > + LVTS (Low Voltage Thermal Sensor). > + The architecture will be first used on mt8192 and mt8195. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + > + "#thermal-sensor-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + description: LVTS instance registers. > + > + interrupts: > + maxItems: 1 > + description: LVTS instance interrupts. > + > + clocks: > + maxItems: 1 > + description: LVTS instance clock. Skip all these three descriptions. They are obvious. > + > + resets: > + maxItems: 1 > + description: | > + LVTS instance SW reset for HW AP/MCU domain to clean temporary data > + on HW initialization/resume. > + > + nvmem-cells: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse data for LVTS > + > + nvmem-cell-names: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse cell names for LVTS > + > +allOf: > + - $ref: thermal-sensor.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + then: > + properties: > + nvmem-cells: > + items: > + - description: Calibration efuse data for LVTS > + > + nvmem-cell-names: > + items: > + - const: lvts_calib_data1 > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + then: > + properties: > + nvmem-cells: > + items: > + - description: Calibration efuse data 1 for LVTS > + - description: Calibration efuse data 2 for LVTS > + > + nvmem-cell-names: > + items: > + - const: lvts_calib_data1 > + - const: lvts_calib_data2 > + > +required: > + - compatible > + - '#thermal-sensor-cells' Use consistent quotes: either ' or " > + - reg > + - interrupts > + - clocks > + - resets > + - nvmem-cells > + - nvmem-cell-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/mt8192-clk.h> > + #include <dt-bindings/reset/mt8192-resets.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + lvts_ap: thermal-sensor@1100b000 { > + compatible = "mediatek,mt8192-lvts-ap"; > + #thermal-sensor-cells = <1>; > + reg = <0 0x1100b000 0 0x1000>; Convention is: compatible, then reg, then the rest of properties > + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&infracfg CLK_INFRA_THERM>; > + resets = <&infracfg MT8192_INFRA_RST0_THERM_CTRL_SWRST>; > + nvmem-cells = <&lvts_e_data1>; > + nvmem-cell-names = "lvts_calib_data1"; > + }; > + > + lvts_mcu: thermal-sensor@11278000 { > + compatible = "mediatek,mt8192-lvts-mcu"; > + #thermal-sensor-cells = <1>; > + reg = <0 0x11278000 0 0x1000>; > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&infracfg CLK_INFRA_THERM>; > + resets = <&infracfg MT8192_INFRA_RST4_THERM_CTRL_MCU_SWRST>; > + nvmem-cells = <&lvts_e_data1>; > + nvmem-cell-names = "lvts_calib_data1"; > + }; > + }; This part is the same as previous, so just skip it or replace with an example which is different somehow. Best regards, Krzysztof
Hi Krzysztof, Thank you for the reviews. Would you please explain the meaning of "Rebase your patchset on decent kernel tree. You seem to use something a bit old"? It is rebased on top of linux-6.0.0-rc1. Am I missing something? Best regards, Balsam On Thu, Aug 18, 2022 at 3:48 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 17/08/2022 11:07, bchihi@baylibre.com wrote: > > From: Alexandre Bailon <abailon@baylibre.com> > > > > Add dt-binding document for mt8192 and mt8195 LVTS thermal controllers. > > Rebase your patchset on decent kernel tree. You seem to use something a > bit old. > > > > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > > Co-developed-by: Balsam CHIHI <bchihi@baylibre.com> > > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > > --- > > .../thermal/mediatek,lvts-thermal.yaml | 152 ++++++++++++++++++ > > 1 file changed, 152 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > new file mode 100644 > > index 000000000000..31d9e220513a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > @@ -0,0 +1,152 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: MediaTek SoC LVTS thermal controller > > + > > +maintainers: > > + - Yu-Chia Chang <ethan.chang@mediatek.com> > > + - Ben Tseng <ben.tseng@mediatek.com> > > + > > +description: | > > + LVTS (Low Voltage Thermal Sensor). > > + The architecture will be first used on mt8192 and mt8195. > > + > > +properties: > > + compatible: > > + enum: > > + - mediatek,mt8192-lvts-ap > > + - mediatek,mt8192-lvts-mcu > > + - mediatek,mt8195-lvts-ap > > + - mediatek,mt8195-lvts-mcu > > + > > + "#thermal-sensor-cells": > > + const: 1 > > + > > + reg: > > + maxItems: 1 > > + description: LVTS instance registers. > > + > > + interrupts: > > + maxItems: 1 > > + description: LVTS instance interrupts. > > + > > + clocks: > > + maxItems: 1 > > + description: LVTS instance clock. > > Skip all these three descriptions. They are obvious. > > > + > > + resets: > > + maxItems: 1 > > + description: | > > + LVTS instance SW reset for HW AP/MCU domain to clean temporary data > > + on HW initialization/resume. > > + > > + nvmem-cells: > > + minItems: 1 > > + maxItems: 2 > > + description: Calibration efuse data for LVTS > > + > > + nvmem-cell-names: > > + minItems: 1 > > + maxItems: 2 > > + description: Calibration efuse cell names for LVTS > > + > > +allOf: > > + - $ref: thermal-sensor.yaml# > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8192-lvts-ap > > + - mediatek,mt8192-lvts-mcu > > + then: > > + properties: > > + nvmem-cells: > > + items: > > + - description: Calibration efuse data for LVTS > > + > > + nvmem-cell-names: > > + items: > > + - const: lvts_calib_data1 > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - mediatek,mt8195-lvts-ap > > + - mediatek,mt8195-lvts-mcu > > + then: > > + properties: > > + nvmem-cells: > > + items: > > + - description: Calibration efuse data 1 for LVTS > > + - description: Calibration efuse data 2 for LVTS > > + > > + nvmem-cell-names: > > + items: > > + - const: lvts_calib_data1 > > + - const: lvts_calib_data2 > > + > > +required: > > + - compatible > > + - '#thermal-sensor-cells' > > Use consistent quotes: either ' or " > > > + - reg > > + - interrupts > > + - clocks > > + - resets > > + - nvmem-cells > > + - nvmem-cell-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/clock/mt8192-clk.h> > > + #include <dt-bindings/reset/mt8192-resets.h> > > + > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + lvts_ap: thermal-sensor@1100b000 { > > + compatible = "mediatek,mt8192-lvts-ap"; > > + #thermal-sensor-cells = <1>; > > + reg = <0 0x1100b000 0 0x1000>; > > Convention is: compatible, then reg, then the rest of properties > > > + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH 0>; > > + clocks = <&infracfg CLK_INFRA_THERM>; > > + resets = <&infracfg MT8192_INFRA_RST0_THERM_CTRL_SWRST>; > > + nvmem-cells = <&lvts_e_data1>; > > + nvmem-cell-names = "lvts_calib_data1"; > > + }; > > + > > + lvts_mcu: thermal-sensor@11278000 { > > + compatible = "mediatek,mt8192-lvts-mcu"; > > + #thermal-sensor-cells = <1>; > > + reg = <0 0x11278000 0 0x1000>; > > + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>; > > + clocks = <&infracfg CLK_INFRA_THERM>; > > + resets = <&infracfg MT8192_INFRA_RST4_THERM_CTRL_MCU_SWRST>; > > + nvmem-cells = <&lvts_e_data1>; > > + nvmem-cell-names = "lvts_calib_data1"; > > + }; > > + }; > > This part is the same as previous, so just skip it or replace with an > example which is different somehow. > > Best regards, > Krzysztof
On 18/08/2022 17:04, Balsam CHIHI wrote: > Hi Krzysztof, > > Thank you for the reviews. > Would you please explain the meaning of "Rebase your patchset on > decent kernel tree. You seem to use something a bit old"? > It is rebased on top of linux-6.0.0-rc1. > Am I missing something? You Cc-ed me based on old maintainers entry, so either you did not use scripts/get_maintainer.pl or you used that tool on some old kernel If you used that tool on decent kernel, you would get different email address. That's why I asked. Best regards, Krzysztof
On Thu, Aug 18, 2022 at 4:08 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 18/08/2022 17:04, Balsam CHIHI wrote: > > Hi Krzysztof, > > > > Thank you for the reviews. > > Would you please explain the meaning of "Rebase your patchset on > > decent kernel tree. You seem to use something a bit old"? > > It is rebased on top of linux-6.0.0-rc1. > > Am I missing something? > > You Cc-ed me based on old maintainers entry, so either you did not use > scripts/get_maintainer.pl or you used that tool on some old kernel If > you used that tool on decent kernel, you would get different email > address. That's why I asked. Thank you for pointing this out. And I will do the requested changes. > > Best regards, > Krzysztof
Il 17/08/22 10:07, bchihi@baylibre.com ha scritto: > From: Alexandre Bailon <abailon@baylibre.com> > > Add dt-binding document for mt8192 and mt8195 LVTS thermal controllers. > > Signed-off-by: Alexandre Bailon <abailon@baylibre.com> > Co-developed-by: Balsam CHIHI <bchihi@baylibre.com> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com> > --- > .../thermal/mediatek,lvts-thermal.yaml | 152 ++++++++++++++++++ > 1 file changed, 152 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > new file mode 100644 > index 000000000000..31d9e220513a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > @@ -0,0 +1,152 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek SoC LVTS thermal controller title: MediaTek SoC Low Voltage Thermal Sensor (LVTS) > + > +maintainers: > + - Yu-Chia Chang <ethan.chang@mediatek.com> > + - Ben Tseng <ben.tseng@mediatek.com> > + > +description: | description: LVTS is a thermal management architecture composed of three subsystems, a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU), a Convertor - Low Voltage Thermal Sensor convertor (LVTS), and a Digital controller (LVTS_CTRL). > + LVTS (Low Voltage Thermal Sensor). > + The architecture will be first used on mt8192 and mt8195. > + > +properties: > + compatible: > + enum: > + - mediatek,mt8192-lvts-ap > + - mediatek,mt8192-lvts-mcu > + - mediatek,mt8195-lvts-ap > + - mediatek,mt8195-lvts-mcu > + > + "#thermal-sensor-cells": > + const: 1 > + > + reg: > + maxItems: 1 > + description: LVTS instance registers. This description looks obvious, as it doesn't really say anything "new"... I would rather drop it. > + > + interrupts: > + maxItems: 1 > + description: LVTS instance interrupts. Same here > + > + clocks: > + maxItems: 1 > + description: LVTS instance clock. and here. > + > + resets: > + maxItems: 1 > + description: | > + LVTS instance SW reset for HW AP/MCU domain to clean temporary data > + on HW initialization/resume. What about something like... resets: items: - description: LVTS reset for clearing temporary data on AP/MCU > + > + nvmem-cells: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse data for LVTS nvmem-cells: minItems: 1 items: - description: Calibration eFuse data for LVTS - description: Additional eFuse data (?) > + > + nvmem-cell-names: > + minItems: 1 > + maxItems: 2 > + description: Calibration efuse cell names for LVTS Actually, maxItems is not really two, but it depends on how many eFuse arrays / nvmem cells we have for each SoC, so I was thinking... ...what about doing something like nvmem-cell-names: minItems: 1 items: pattern: 'lvts-calib-data[0-9]+$' and then, if: properties: compatible: contains: enum: - mediatek,blahblah-something then: properties: nvmem-cell-names: maxItems: 2 (or 3, 4, 5...) P.S.: I haven't tried any binding check on the proposed lines. Krzysztof, any opinions on that? Regards, Angelo
Hi Angelo,
I've got the following errors after implementing these changes :
[...]
nvmem-cells:
minItems: 1
description: Calibration eFuse data for LVTS
nvmem-cell-names:
minItems: 1
items:
pattern: 'lvts-calib-data[0-9]+$'
"#thermal-sensor-cells":
const: 1
allOf:
- $ref: thermal-sensor.yaml#
- if:
properties:
compatible:
contains:
enum:
- mediatek,mt8192-lvts-ap
- mediatek,mt8192-lvts-mcu
then:
properties:
nvmem-cells:
maxItems: 1
nvmem-cell-names:
maxItems: 1
- if:
properties:
compatible:
contains:
enum:
- mediatek,mt8195-lvts-ap
- mediatek,mt8195-lvts-mcu
then:
properties:
nvmem-cells:
maxItems: 2
nvmem-cell-names:
maxItems: 2
[...]
$ make DT_CHECKER_FLAGS=-m dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
/home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
properties:nvmem-cell-names:items: {'pattern':
'lvts-calib-data[0-9]+$'} is not of type 'array'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
SCHEMA Documentation/devicetree/bindings/processed-schema.json
/home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml:
ignoring, error in schema: properties: nvmem-cell-names: items
DTEX Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts
DTC Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
CHECK Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb
Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb:0:0:
/example-0/soc/thermal-sensor@1100b000: failed to match any schema
with compatible: ['mediatek,mt8192-lvts-ap']
am I missing something?
Best regards,
Balsam
On Wed, Sep 14, 2022 at 2:19 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 17/08/22 10:07, bchihi@baylibre.com ha scritto:
> > From: Alexandre Bailon <abailon@baylibre.com>
> >
> > Add dt-binding document for mt8192 and mt8195 LVTS thermal controllers.
> >
> > Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> > Co-developed-by: Balsam CHIHI <bchihi@baylibre.com>
> > Signed-off-by: Balsam CHIHI <bchihi@baylibre.com>
> > ---
> > .../thermal/mediatek,lvts-thermal.yaml | 152 ++++++++++++++++++
> > 1 file changed, 152 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> > new file mode 100644
> > index 000000000000..31d9e220513a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml
> > @@ -0,0 +1,152 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek SoC LVTS thermal controller
>
> title: MediaTek SoC Low Voltage Thermal Sensor (LVTS)
>
> > +
> > +maintainers:
> > + - Yu-Chia Chang <ethan.chang@mediatek.com>
> > + - Ben Tseng <ben.tseng@mediatek.com>
> > +
> > +description: |
>
> description:
> LVTS is a thermal management architecture composed of three subsystems,
> a Sensing device - Thermal Sensing Micro Circuit Unit (TSMCU),
> a Convertor - Low Voltage Thermal Sensor convertor (LVTS), and
> a Digital controller (LVTS_CTRL).
>
> > + LVTS (Low Voltage Thermal Sensor).
> > + The architecture will be first used on mt8192 and mt8195.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt8192-lvts-ap
> > + - mediatek,mt8192-lvts-mcu
> > + - mediatek,mt8195-lvts-ap
> > + - mediatek,mt8195-lvts-mcu
> > +
> > + "#thermal-sensor-cells":
> > + const: 1
> > +
> > + reg:
> > + maxItems: 1
> > + description: LVTS instance registers.
>
> This description looks obvious, as it doesn't really say anything "new"...
> I would rather drop it.
>
> > +
> > + interrupts:
> > + maxItems: 1
> > + description: LVTS instance interrupts.
>
> Same here
>
> > +
> > + clocks:
> > + maxItems: 1
> > + description: LVTS instance clock.
>
> and here.
>
> > +
> > + resets:
> > + maxItems: 1
> > + description: |
> > + LVTS instance SW reset for HW AP/MCU domain to clean temporary data
> > + on HW initialization/resume.
>
> What about something like...
>
> resets:
> items:
> - description: LVTS reset for clearing temporary data on AP/MCU
>
> > +
> > + nvmem-cells:
> > + minItems: 1
> > + maxItems: 2
> > + description: Calibration efuse data for LVTS
>
> nvmem-cells:
> minItems: 1
> items:
> - description: Calibration eFuse data for LVTS
> - description: Additional eFuse data (?)
>
>
> > +
> > + nvmem-cell-names:
> > + minItems: 1
> > + maxItems: 2
> > + description: Calibration efuse cell names for LVTS
>
> Actually, maxItems is not really two, but it depends on how many
> eFuse arrays / nvmem cells we have for each SoC, so I was thinking...
>
> ...what about doing something like
>
> nvmem-cell-names:
> minItems: 1
> items:
> pattern: 'lvts-calib-data[0-9]+$'
>
> and then,
> if:
> properties:
> compatible:
> contains:
> enum:
> - mediatek,blahblah-something
> then:
> properties:
> nvmem-cell-names:
> maxItems: 2 (or 3, 4, 5...)
>
> P.S.: I haven't tried any binding check on the proposed lines.
>
> Krzysztof, any opinions on that?
>
> Regards,
> Angelo
>
>
>
On 14/09/2022 14:19, AngeloGioacchino Del Regno wrote: > >> + >> + nvmem-cell-names: >> + minItems: 1 >> + maxItems: 2 >> + description: Calibration efuse cell names for LVTS > > Actually, maxItems is not really two, but it depends on how many > eFuse arrays / nvmem cells we have for each SoC, so I was thinking... > > ...what about doing something like > > nvmem-cell-names: > minItems: 1 > items: > pattern: 'lvts-calib-data[0-9]+$' > > and then, > if: > properties: > compatible: > contains: > enum: > - mediatek,blahblah-something > then: > properties: > nvmem-cell-names: > maxItems: 2 (or 3, 4, 5...) > > P.S.: I haven't tried any binding check on the proposed lines. > Should work, but does not enforce the order, so I would rather propose something longer: properties: nvmem-cell-names: items: - lvts-calib-data0 - lvts-calib-data1 minItems: 1 and then in allOf:if:then set minItems:2 or maxItems:1 Best regards, Krzysztof
On 14/09/2022 16:01, Balsam CHIHI wrote: > Hi Angelo, > > I've got the following errors after implementing these changes : > [...] > nvmem-cells: > minItems: 1 > description: Calibration eFuse data for LVTS > > nvmem-cell-names: > minItems: 1 > items: > pattern: 'lvts-calib-data[0-9]+$' > > "#thermal-sensor-cells": > const: 1 > > allOf: > - $ref: thermal-sensor.yaml# > > - if: > properties: > compatible: > contains: > enum: > - mediatek,mt8192-lvts-ap > - mediatek,mt8192-lvts-mcu > then: > properties: > nvmem-cells: > maxItems: 1 > > nvmem-cell-names: > maxItems: 1 > > - if: > properties: > compatible: > contains: > enum: > - mediatek,mt8195-lvts-ap > - mediatek,mt8195-lvts-mcu > then: > properties: > nvmem-cells: > maxItems: 2 > > nvmem-cell-names: > maxItems: 2 > [...] > > $ make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml: > properties:nvmem-cell-names:items: {'pattern': > 'lvts-calib-data[0-9]+$'} is not of type 'array' > from schema $id: http://devicetree.org/meta-schemas/string-array.yaml# > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /home/balsam/src/linux-mtk-lvts-newThermalOF/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml: > ignoring, error in schema: properties: nvmem-cell-names: items > DTEX Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dts > DTC Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb > CHECK Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb > Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.example.dtb:0:0: > /example-0/soc/thermal-sensor@1100b000: failed to match any schema > with compatible: ['mediatek,mt8192-lvts-ap'] > > am I missing something? Maybe maxItems: 2 in top-level property? Best regards, Krzysztof
Hi Krzysztof, Angelo,
Thank you for the suggestions.
I tested this (below) and it worked without any problem.
"make DT_CHECKER_FLAGS=-m dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml"
"make dtbs_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml"
Should I keep it like this and submit it in v10?
[...]
nvmem-cells:
minItems: 1
items:
- description: Calibration eFuse data 1 for LVTS
- description: Calibration eFuse data 2 for LVTS
nvmem-cell-names:
minItems: 1
items:
- const: lvts-calib-data-1
- const: lvts-calib-data-2
"#thermal-sensor-cells":
const: 1
allOf:
- $ref: thermal-sensor.yaml#
- if:
properties:
compatible:
contains:
enum:
- mediatek,mt8192-lvts-ap
- mediatek,mt8192-lvts-mcu
then:
properties:
nvmem-cells:
maxItems: 1
nvmem-cell-names:
maxItems: 1
- if:
properties:
compatible:
contains:
enum:
- mediatek,mt8195-lvts-ap
- mediatek,mt8195-lvts-mcu
then:
properties:
nvmem-cells:
maxItems: 2
nvmem-cell-names:
maxItems: 2
[...]
Best regards,
Balsam
diff --git a/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml new file mode 100644 index 000000000000..31d9e220513a --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/mediatek,lvts-thermal.yaml @@ -0,0 +1,152 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/mediatek,lvts-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: MediaTek SoC LVTS thermal controller + +maintainers: + - Yu-Chia Chang <ethan.chang@mediatek.com> + - Ben Tseng <ben.tseng@mediatek.com> + +description: | + LVTS (Low Voltage Thermal Sensor). + The architecture will be first used on mt8192 and mt8195. + +properties: + compatible: + enum: + - mediatek,mt8192-lvts-ap + - mediatek,mt8192-lvts-mcu + - mediatek,mt8195-lvts-ap + - mediatek,mt8195-lvts-mcu + + "#thermal-sensor-cells": + const: 1 + + reg: + maxItems: 1 + description: LVTS instance registers. + + interrupts: + maxItems: 1 + description: LVTS instance interrupts. + + clocks: + maxItems: 1 + description: LVTS instance clock. + + resets: + maxItems: 1 + description: | + LVTS instance SW reset for HW AP/MCU domain to clean temporary data + on HW initialization/resume. + + nvmem-cells: + minItems: 1 + maxItems: 2 + description: Calibration efuse data for LVTS + + nvmem-cell-names: + minItems: 1 + maxItems: 2 + description: Calibration efuse cell names for LVTS + +allOf: + - $ref: thermal-sensor.yaml# + + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt8192-lvts-ap + - mediatek,mt8192-lvts-mcu + then: + properties: + nvmem-cells: + items: + - description: Calibration efuse data for LVTS + + nvmem-cell-names: + items: + - const: lvts_calib_data1 + + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt8195-lvts-ap + - mediatek,mt8195-lvts-mcu + then: + properties: + nvmem-cells: + items: + - description: Calibration efuse data 1 for LVTS + - description: Calibration efuse data 2 for LVTS + + nvmem-cell-names: + items: + - const: lvts_calib_data1 + - const: lvts_calib_data2 + +required: + - compatible + - '#thermal-sensor-cells' + - reg + - interrupts + - clocks + - resets + - nvmem-cells + - nvmem-cell-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/mt8192-clk.h> + #include <dt-bindings/reset/mt8192-resets.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + lvts_ap: thermal-sensor@1100b000 { + compatible = "mediatek,mt8192-lvts-ap"; + #thermal-sensor-cells = <1>; + reg = <0 0x1100b000 0 0x1000>; + interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&infracfg CLK_INFRA_THERM>; + resets = <&infracfg MT8192_INFRA_RST0_THERM_CTRL_SWRST>; + nvmem-cells = <&lvts_e_data1>; + nvmem-cell-names = "lvts_calib_data1"; + }; + + lvts_mcu: thermal-sensor@11278000 { + compatible = "mediatek,mt8192-lvts-mcu"; + #thermal-sensor-cells = <1>; + reg = <0 0x11278000 0 0x1000>; + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&infracfg CLK_INFRA_THERM>; + resets = <&infracfg MT8192_INFRA_RST4_THERM_CTRL_MCU_SWRST>; + nvmem-cells = <&lvts_e_data1>; + nvmem-cell-names = "lvts_calib_data1"; + }; + }; + + thermal_zones: thermal-zones { + cpu0-thermal { + polling-delay = <0>; + polling-delay-passive = <0>; + thermal-sensors = <&lvts_mcu 0>; + }; + + vpu1-thermal { + polling-delay = <0>; + polling-delay-passive = <0>; + thermal-sensors = <&lvts_ap 0>; + }; + };