| Message ID | 20220920084431.196258-1-renzhijie2@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 09431acde35f46ac82fb5230c7479f1edc557c75 |
| Headers | show |
| Series | [-next] usb: typec: anx7411: Fix build error without CONFIG_POWER_SUPPLY | expand |
On Tue, Sep 20, 2022 at 04:44:31PM +0800, Ren Zhijie wrote: > Building without CONFIG_POWER_SUPPLY will fail: > > drivers/usb/typec/anx7411.o: In function `anx7411_detect_power_mode': > anx7411.c:(.text+0x527): undefined reference to `power_supply_changed' > drivers/usb/typec/anx7411.o: In function `anx7411_psy_set_prop': > anx7411.c:(.text+0x90d): undefined reference to `power_supply_get_drvdata' > anx7411.c:(.text+0x930): undefined reference to `power_supply_changed' > drivers/usb/typec/anx7411.o: In function `anx7411_psy_get_prop': > anx7411.c:(.text+0x94d): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/anx7411.o: In function `anx7411_i2c_probe': > anx7411.c:(.text+0x111d): undefined reference to > `devm_power_supply_register' > drivers/usb/typec/anx7411.o: In function `anx7411_work_func': > anx7411.c:(.text+0x167c): undefined reference to `power_supply_changed' > anx7411.c:(.text+0x1b55): undefined reference to `power_supply_changed' > > Add POWER_SUPPLY dependency to Kconfig. > > Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 5defdfead653..831e7049977d 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -56,6 +56,7 @@ config TYPEC_ANX7411 > tristate "Analogix ANX7411 Type-C DRP Port controller driver" > depends on I2C > depends on USB_ROLE_SWITCH > + depends on POWER_SUPPLY > help > Say Y or M here if your system has Analogix ANX7411 Type-C DRP Port > controller driver. > -- > 2.17.1
On Tue, Sep 20, 2022 at 04:44:31PM +0800, Ren Zhijie wrote: > Building without CONFIG_POWER_SUPPLY will fail: > > drivers/usb/typec/anx7411.o: In function `anx7411_detect_power_mode': > anx7411.c:(.text+0x527): undefined reference to `power_supply_changed' > drivers/usb/typec/anx7411.o: In function `anx7411_psy_set_prop': > anx7411.c:(.text+0x90d): undefined reference to `power_supply_get_drvdata' > anx7411.c:(.text+0x930): undefined reference to `power_supply_changed' > drivers/usb/typec/anx7411.o: In function `anx7411_psy_get_prop': > anx7411.c:(.text+0x94d): undefined reference to `power_supply_get_drvdata' > drivers/usb/typec/anx7411.o: In function `anx7411_i2c_probe': > anx7411.c:(.text+0x111d): undefined reference to > `devm_power_supply_register' > drivers/usb/typec/anx7411.o: In function `anx7411_work_func': > anx7411.c:(.text+0x167c): undefined reference to `power_supply_changed' > anx7411.c:(.text+0x1b55): undefined reference to `power_supply_changed' > > Add POWER_SUPPLY dependency to Kconfig. Hi Ren Zhijie, thanks for your patch. Reviewed-by: Xin Ji <xji@analogixsemi.com> > > Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- > drivers/usb/typec/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 5defdfead653..831e7049977d 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -56,6 +56,7 @@ config TYPEC_ANX7411 > tristate "Analogix ANX7411 Type-C DRP Port controller driver" > depends on I2C > depends on USB_ROLE_SWITCH > + depends on POWER_SUPPLY > help > Say Y or M here if your system has Analogix ANX7411 Type-C DRP Port > controller driver. > -- > 2.17.1
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig index 5defdfead653..831e7049977d 100644 --- a/drivers/usb/typec/Kconfig +++ b/drivers/usb/typec/Kconfig @@ -56,6 +56,7 @@ config TYPEC_ANX7411 tristate "Analogix ANX7411 Type-C DRP Port controller driver" depends on I2C depends on USB_ROLE_SWITCH + depends on POWER_SUPPLY help Say Y or M here if your system has Analogix ANX7411 Type-C DRP Port controller driver.
Building without CONFIG_POWER_SUPPLY will fail: drivers/usb/typec/anx7411.o: In function `anx7411_detect_power_mode': anx7411.c:(.text+0x527): undefined reference to `power_supply_changed' drivers/usb/typec/anx7411.o: In function `anx7411_psy_set_prop': anx7411.c:(.text+0x90d): undefined reference to `power_supply_get_drvdata' anx7411.c:(.text+0x930): undefined reference to `power_supply_changed' drivers/usb/typec/anx7411.o: In function `anx7411_psy_get_prop': anx7411.c:(.text+0x94d): undefined reference to `power_supply_get_drvdata' drivers/usb/typec/anx7411.o: In function `anx7411_i2c_probe': anx7411.c:(.text+0x111d): undefined reference to `devm_power_supply_register' drivers/usb/typec/anx7411.o: In function `anx7411_work_func': anx7411.c:(.text+0x167c): undefined reference to `power_supply_changed' anx7411.c:(.text+0x1b55): undefined reference to `power_supply_changed' Add POWER_SUPPLY dependency to Kconfig. Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support") Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> --- drivers/usb/typec/Kconfig | 1 + 1 file changed, 1 insertion(+)