| Message ID | 20220914015147.3071025-3-tan.shaopeng@jp.fujitsu.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/resctrl: Return MBA check result and make it to output message | expand |
Hi Shaopeng, On my side this patch arrived as an unnumbered sixth patch forming part of a five patch series. On 9/13/2022 6:51 PM, Shaopeng Tan wrote: > Since MBA check result is not returned, the MBA test result message > is always output as OK regardless of whether the MBA check result is > true or fail. fail -> false? I think it should be either succeed/fail or true/false. > > Make output message to be "not ok" if MBA check result is failed. > > This patch is based on Linux v6.0-rc5 This should not be part of the changelog but instead be below the "---". > > Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > --- Thank you very much for catching this. The fix looks good, I only have nitpicks about the changelog. Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Reinette
Hi Reinette, Thanks for your advice. > On my side this patch arrived as an unnumbered sixth patch forming part of a > five patch series. In next version, I will add this patch into patch series. > On 9/13/2022 6:51 PM, Shaopeng Tan wrote: > > Since MBA check result is not returned, the MBA test result message is > > always output as OK regardless of whether the MBA check result is true > > or fail. > > fail -> false? It is false. > I think it should be either succeed/fail or true/false. > > > > > Make output message to be "not ok" if MBA check result is failed. > > > > This patch is based on Linux v6.0-rc5 > > This should not be part of the changelog but instead be below the "---". Thanks. > > > > Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > > --- > > Thank you very much for catching this. The fix looks good, I only have nitpicks > about the changelog. > > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> Thanks. Best Regards, Shaopeng
diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 93ffacb416df..e7dfeb697e5e 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -51,7 +51,7 @@ static int mba_setup(int num, ...) return 0; } -static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) +static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) { int allocation, runs; bool failed = false; @@ -97,6 +97,8 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) failed ? "Fail:" : "Pass:"); if (failed) ksft_print_msg("At least one test failed\n"); + + return failed; } static int check_results(void) @@ -132,9 +134,7 @@ static int check_results(void) fclose(fp); - show_mba_info(bw_imc, bw_resc); - - return 0; + return show_mba_info(bw_imc, bw_resc); } void mba_test_cleanup(void)
Since MBA check result is not returned, the MBA test result message is always output as OK regardless of whether the MBA check result is true or fail. Make output message to be "not ok" if MBA check result is failed. This patch is based on Linux v6.0-rc5 Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> --- tools/testing/selftests/resctrl/mba_test.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)