| Message ID | 20210416040924.2882771-1-danielwa@cisco.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | generic command line v4 | expand |
On 4/16/21 12:09 AM, Daniel Walker wrote: > > v4 release changes > > * Updated insert-sys-cert tool to change command line symbols after > compilation. > > This tool is used to release binary kernels internally to companies > and then later insert certificates for each product by consumers of > the binary kernel. Cisco uses this tool for this purpose. > > Cisco has a similar need for the command line to be modified on a > binary released kernels similar to how certificates are setup. > > * Added global symbols to hold append and prepend values. > > These changes follow the system certificate code to allow the > insert-sys-cert tool to be used. > > * Added a test case to confirm functionality. > > Seemed sensible to add this to make sure everything is working. > > * Dropped powerpc changes > > Christophe Leroy has reservations about the features for powerpc. I > don't think his reservations are founded, and these changes should > fully work on powerpc. However, I dropped these changes so Christophe > can have more time to get comfortable with the changes. > > > Enjoy! > > > Daniel Walker (8): > CMDLINE: add generic builtin command line > scripts: insert-sys-cert: add command line insert capability > scripts: insert-sys-cert: change name to insert-symbol > CMDLINE: mips: convert to generic builtin command line > drivers: firmware: efi: libstub: enable generic commandline > CMDLINE: x86: convert to generic builtin command line > of: allow sending a NULL value to early_init_dt_scan_chosen > CMDLINE: arm64: convert to generic builtin command line > > arch/arm64/Kconfig | 33 +-- > arch/arm64/include/asm/setup.h | 2 + > arch/arm64/kernel/idreg-override.c | 9 +- > arch/mips/Kconfig | 4 +- > arch/mips/Kconfig.debug | 44 ---- > arch/mips/configs/ar7_defconfig | 9 +- > arch/mips/configs/bcm47xx_defconfig | 8 +- > arch/mips/configs/bcm63xx_defconfig | 15 +- > arch/mips/configs/bmips_be_defconfig | 11 +- > arch/mips/configs/bmips_stb_defconfig | 11 +- > arch/mips/configs/capcella_defconfig | 11 +- > arch/mips/configs/ci20_defconfig | 10 +- > arch/mips/configs/cu1000-neo_defconfig | 10 +- > arch/mips/configs/cu1830-neo_defconfig | 10 +- > arch/mips/configs/e55_defconfig | 4 +- > arch/mips/configs/generic_defconfig | 6 +- > arch/mips/configs/gpr_defconfig | 18 +- > arch/mips/configs/loongson3_defconfig | 13 +- > arch/mips/configs/mpc30x_defconfig | 7 +- > arch/mips/configs/tb0219_defconfig | 7 +- > arch/mips/configs/tb0226_defconfig | 7 +- > arch/mips/configs/tb0287_defconfig | 7 +- > arch/mips/configs/workpad_defconfig | 11 +- > arch/mips/include/asm/setup.h | 2 + > arch/mips/kernel/relocate.c | 17 +- > arch/mips/kernel/setup.c | 36 +-- > arch/mips/pic32/pic32mzda/early_console.c | 2 +- > arch/mips/pic32/pic32mzda/init.c | 3 +- > arch/x86/Kconfig | 44 +--- > arch/x86/kernel/setup.c | 18 +- > .../firmware/efi/libstub/efi-stub-helper.c | 29 +++ > drivers/firmware/efi/libstub/efi-stub.c | 9 + > drivers/firmware/efi/libstub/efistub.h | 1 + > drivers/firmware/efi/libstub/x86-stub.c | 13 +- > drivers/of/fdt.c | 44 ++-- > include/linux/cmdline.h | 103 ++++++++ > init/Kconfig | 78 ++++++ > lib/Kconfig | 4 + > lib/Makefile | 3 + > lib/generic_cmdline.S | 53 ++++ > lib/test_cmdline1.c | 139 ++++++++++ > scripts/Makefile | 2 +- > .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------ > 43 files changed, 716 insertions(+), 394 deletions(-) > create mode 100644 include/linux/cmdline.h > create mode 100644 lib/generic_cmdline.S > create mode 100644 lib/test_cmdline1.c > rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%) > For an arm64 platform (after rebasing): Tested-by: Sean Anderson <sean.anderson@seco.com>
On Thu, Sep 22, 2022 at 04:45:01PM -0400, Sean Anderson wrote: > > > > For an arm64 platform (after rebasing): > > Tested-by: Sean Anderson <sean.anderson@seco.com> Maybe I'll re-submit it. Daniel
On 9/22/22 4:53 PM, Daniel Walker wrote: > On Thu, Sep 22, 2022 at 04:45:01PM -0400, Sean Anderson wrote: >> >> >> >> For an arm64 platform (after rebasing): >> >> Tested-by: Sean Anderson <sean.anderson@seco.com> > > Maybe I'll re-submit it. > > Daniel > There's still no way to extend the command line on ARM64, since the existing method was removed in anticipation that your series would be added. As recently as last month, someone's patch to add such support was rejected for this reason [1]. --Sean [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/
On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > > > > On 9/22/22 4:53 PM, Daniel Walker wrote: > > On Thu, Sep 22, 2022 at 04:45:01PM -0400, Sean Anderson wrote: > >> > >> > >> > >> For an arm64 platform (after rebasing): > >> > >> Tested-by: Sean Anderson <sean.anderson@seco.com> > > > > Maybe I'll re-submit it. > > > > Daniel > > > > There's still no way to extend the command line on ARM64, since the > existing method was removed in anticipation that your series would be > added. > > As recently as last month, someone's patch to add such support was > rejected for this reason [1]. > > --Sean > > [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/ I had no idea.. Thanks for pointing that out. I guess I will re-submit in that case. Daniel
On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: [snip] > > As recently as last month, someone's patch to add such support was > > rejected for this reason [1]. > > > > --Sean > > > > [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/ > > > I had no idea.. Thanks for pointing that out. I guess I will re-submit in that > case. > > Daniel This has been happening repeatedly since circa 2014, on multiple architectures. It's quite frustrating, really.
On Thu, Sep 22, 2022 at 4:15 PM Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us> wrote: > > On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > [snip] > > > As recently as last month, someone's patch to add such support was > > > rejected for this reason [1]. > > > > > > --Sean > > > > > > [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/ > > > > > > I had no idea.. Thanks for pointing that out. I guess I will re-submit in that > > case. > > > > Daniel > > This has been happening repeatedly since circa 2014, on multiple > architectures. It's quite frustrating, really. It must not be that important. From the last time, IMO Christophe's version was much closer to being merged than this series. This is not how you get things upstream: > * Dropped powerpc changes > Christophe Leroy has reservations about the features for powerpc. I > don't think his reservations are founded, and these changes should > fully work on powerpc. However, I dropped these changes so Christophe > can have more time to get comfortable with the changes. Rob
On Thu, Sep 22, 2022 at 02:15:44PM -0700, Daniel Gimpelevich wrote: > On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > [snip] > > > As recently as last month, someone's patch to add such support was > > > rejected for this reason [1]. > > > > > > --Sean > > > > > > [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/ > > > > > > I had no idea.. Thanks for pointing that out. I guess I will re-submit in that > > case. > > > > Daniel > > This has been happening repeatedly since circa 2014, on multiple > architectures. It's quite frustrating, really. I'm not sure I'm following your comments. What's frustrating exactly ? Daniel
On Mon, Sep 26, 2022 at 05:52:18PM -0500, Rob Herring wrote: > On Thu, Sep 22, 2022 at 4:15 PM Daniel Gimpelevich > <daniel@gimpelevich.san-francisco.ca.us> wrote: > > > > On Thu, 2022-09-22 at 14:10 -0700, Daniel Walker wrote: > > > On Thu, Sep 22, 2022 at 05:03:46PM -0400, Sean Anderson wrote: > > [snip] > > > > As recently as last month, someone's patch to add such support was > > > > rejected for this reason [1]. > > > > > > > > --Sean > > > > > > > > [1] https://lore.kernel.org/linux-arm-kernel/20220812084613.GA3107@willie-the-truck/ > > > > > > > > > I had no idea.. Thanks for pointing that out. I guess I will re-submit in that > > > case. > > > > > > Daniel > > > > This has been happening repeatedly since circa 2014, on multiple > > architectures. It's quite frustrating, really. > > It must not be that important. From the last time, IMO Christophe's > version was much closer to being merged than this series. This is not > how you get things upstream: > > > * Dropped powerpc changes > > Christophe Leroy has reservations about the features for powerpc. I > > don't think his reservations are founded, and these changes should > > fully work on powerpc. However, I dropped these changes so Christophe > > can have more time to get comfortable with the changes. > > Rob I don't submit often enough, that's true. However, I figured maintainers don't want the changes. This is a common occurrence in industry, people may submit once or twice, no traction and they give up. I suppose it's a combination of problems. Christophe's don't have the same features, so they are really totally different but conflicting. Daniel
v4 release changes * Updated insert-sys-cert tool to change command line symbols after compilation. This tool is used to release binary kernels internally to companies and then later insert certificates for each product by consumers of the binary kernel. Cisco uses this tool for this purpose. Cisco has a similar need for the command line to be modified on a binary released kernels similar to how certificates are setup. * Added global symbols to hold append and prepend values. These changes follow the system certificate code to allow the insert-sys-cert tool to be used. * Added a test case to confirm functionality. Seemed sensible to add this to make sure everything is working. * Dropped powerpc changes Christophe Leroy has reservations about the features for powerpc. I don't think his reservations are founded, and these changes should fully work on powerpc. However, I dropped these changes so Christophe can have more time to get comfortable with the changes. Enjoy! Daniel Walker (8): CMDLINE: add generic builtin command line scripts: insert-sys-cert: add command line insert capability scripts: insert-sys-cert: change name to insert-symbol CMDLINE: mips: convert to generic builtin command line drivers: firmware: efi: libstub: enable generic commandline CMDLINE: x86: convert to generic builtin command line of: allow sending a NULL value to early_init_dt_scan_chosen CMDLINE: arm64: convert to generic builtin command line arch/arm64/Kconfig | 33 +-- arch/arm64/include/asm/setup.h | 2 + arch/arm64/kernel/idreg-override.c | 9 +- arch/mips/Kconfig | 4 +- arch/mips/Kconfig.debug | 44 ---- arch/mips/configs/ar7_defconfig | 9 +- arch/mips/configs/bcm47xx_defconfig | 8 +- arch/mips/configs/bcm63xx_defconfig | 15 +- arch/mips/configs/bmips_be_defconfig | 11 +- arch/mips/configs/bmips_stb_defconfig | 11 +- arch/mips/configs/capcella_defconfig | 11 +- arch/mips/configs/ci20_defconfig | 10 +- arch/mips/configs/cu1000-neo_defconfig | 10 +- arch/mips/configs/cu1830-neo_defconfig | 10 +- arch/mips/configs/e55_defconfig | 4 +- arch/mips/configs/generic_defconfig | 6 +- arch/mips/configs/gpr_defconfig | 18 +- arch/mips/configs/loongson3_defconfig | 13 +- arch/mips/configs/mpc30x_defconfig | 7 +- arch/mips/configs/tb0219_defconfig | 7 +- arch/mips/configs/tb0226_defconfig | 7 +- arch/mips/configs/tb0287_defconfig | 7 +- arch/mips/configs/workpad_defconfig | 11 +- arch/mips/include/asm/setup.h | 2 + arch/mips/kernel/relocate.c | 17 +- arch/mips/kernel/setup.c | 36 +-- arch/mips/pic32/pic32mzda/early_console.c | 2 +- arch/mips/pic32/pic32mzda/init.c | 3 +- arch/x86/Kconfig | 44 +--- arch/x86/kernel/setup.c | 18 +- .../firmware/efi/libstub/efi-stub-helper.c | 29 +++ drivers/firmware/efi/libstub/efi-stub.c | 9 + drivers/firmware/efi/libstub/efistub.h | 1 + drivers/firmware/efi/libstub/x86-stub.c | 13 +- drivers/of/fdt.c | 44 ++-- include/linux/cmdline.h | 103 ++++++++ init/Kconfig | 78 ++++++ lib/Kconfig | 4 + lib/Makefile | 3 + lib/generic_cmdline.S | 53 ++++ lib/test_cmdline1.c | 139 ++++++++++ scripts/Makefile | 2 +- .../{insert-sys-cert.c => insert-symbol.c} | 243 ++++++++++++------ 43 files changed, 716 insertions(+), 394 deletions(-) create mode 100644 include/linux/cmdline.h create mode 100644 lib/generic_cmdline.S create mode 100644 lib/test_cmdline1.c rename scripts/{insert-sys-cert.c => insert-symbol.c} (72%)