| Message ID | 20220920130711.1107018-2-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c8fbf8a88fcd4464b0727d646a85793ccba49b03 |
| Headers | show |
| Series | Remove orphan declarations and comments | expand |
On Tue, Sep 20, 2022 at 09:07:10PM +0800, Gaosheng Cui wrote: > All uses of sb1250_time_init() have been removed by > commit d527eef5b7f1 ("[MIPS] Sibyte: Finish conversion to modern > time APIs."), so remove the orphan declaration. > > The comments about sb1250_time_init() is useless in arch_init_irq(), > so remove these comments. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > arch/mips/include/asm/sibyte/sb1250.h | 1 - > arch/mips/sibyte/sb1250/irq.c | 6 ------ > 2 files changed, 7 deletions(-) applied to mips-next. Thomas.
diff --git a/arch/mips/include/asm/sibyte/sb1250.h b/arch/mips/include/asm/sibyte/sb1250.h index dbde5f93f0dd..495b31925ed7 100644 --- a/arch/mips/include/asm/sibyte/sb1250.h +++ b/arch/mips/include/asm/sibyte/sb1250.h @@ -32,7 +32,6 @@ extern unsigned int soc_type; extern unsigned int periph_rev; extern unsigned int zbbus_mhz; -extern void sb1250_time_init(void); extern void sb1250_mask_irq(int cpu, int irq); extern void sb1250_unmask_irq(int cpu, int irq); diff --git a/arch/mips/sibyte/sb1250/irq.c b/arch/mips/sibyte/sb1250/irq.c index 86f49c48fc34..2f08ad267a11 100644 --- a/arch/mips/sibyte/sb1250/irq.c +++ b/arch/mips/sibyte/sb1250/irq.c @@ -262,12 +262,6 @@ void __init arch_init_irq(void) __raw_writeq(tmp, IOADDR(A_IMR_REGISTER(0, R_IMR_INTERRUPT_MASK))); __raw_writeq(tmp, IOADDR(A_IMR_REGISTER(1, R_IMR_INTERRUPT_MASK))); - /* - * Note that the timer interrupts are also mapped, but this is - * done in sb1250_time_init(). Also, the profiling driver - * does its own management of IP7. - */ - /* Enable necessary IPs, disable the rest */ change_c0_status(ST0_IM, imask); }
All uses of sb1250_time_init() have been removed by commit d527eef5b7f1 ("[MIPS] Sibyte: Finish conversion to modern time APIs."), so remove the orphan declaration. The comments about sb1250_time_init() is useless in arch_init_irq(), so remove these comments. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- arch/mips/include/asm/sibyte/sb1250.h | 1 - arch/mips/sibyte/sb1250/irq.c | 6 ------ 2 files changed, 7 deletions(-)