diff mbox series

[v1,1/2] Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG -> peripheral if extcon is present""

Message ID 20220923163051.36288-2-andriy.shevchenko@linux.intel.com (mailing list archive)
State Superseded
Headers show
Series usb: dwc3: revert OTG changes for Intel Merrifield | expand

Commit Message

Andy Shevchenko Sept. 23, 2022, 4:30 p.m. UTC
This reverts commit 8bd6b8c4b1009d7d2662138d6bdc6fe58a9274c5.

Prerequisite revert for the reverting the original patch.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/usb/dwc3/core.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

Comments

Greg KH Sept. 24, 2022, 10:39 a.m. UTC | #1
On Fri, Sep 23, 2022 at 07:30:50PM +0300, Andy Shevchenko wrote:
> This reverts commit 8bd6b8c4b1009d7d2662138d6bdc6fe58a9274c5.
> 
> Prerequisite revert for the reverting the original patch.

What "original patch"?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

What commit does this fix?  Stable trees?

you know better, I can't take this as-is...

thanks,

greg k-h
diff mbox series

Patch

diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 8c8e32651473..b3ae53be2112 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1684,8 +1684,13 @@  static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
 	 * This device property is for kernel internal use only and
 	 * is expected to be set by the glue code.
 	 */
-	if (device_property_read_string(dev, "linux,extcon-name", &name) == 0)
-		return extcon_get_extcon_dev(name);
+	if (device_property_read_string(dev, "linux,extcon-name", &name) == 0) {
+		edev = extcon_get_extcon_dev(name);
+		if (!edev)
+			return ERR_PTR(-EPROBE_DEFER);
+
+		return edev;
+	}
 
 	/*
 	 * Try to get an extcon device from the USB PHY controller's "port"