| Message ID | 20220920130711.1107018-3-cuigaosheng1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Remove orphan declarations and comments | expand |
On Tue, Sep 20, 2022 at 09:07:11PM +0800, Gaosheng Cui wrote: > All uses of allocate_irqno() have been removed by > commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"), > so remove the orphan declaration. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > arch/mips/include/asm/irq.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h > index 57561e0e6e8d..2f47f56fca82 100644 > --- a/arch/mips/include/asm/irq.h > +++ b/arch/mips/include/asm/irq.h > @@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq); > extern void arch_init_irq(void); > extern void spurious_interrupt(void); > > -extern int allocate_irqno(void); > extern void alloc_legacy_irqno(void); > extern void free_irqno(unsigned int irq); > > -- > 2.25.1 applied to mips-next. The patch didn't apply, because you alread removed alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that while applying, but please you latest mips-next branch for creating patches next time. Thomas.
> applied to mips-next. The patch didn't apply, because you alread removed > alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that > while applying, but please you latest mips-next branch for creating > patches next time. Thanks for taking the time to review this patch, I checked my patches,you are right, it is my negligence,Thanks again for reminding me! On 2022/9/24 17:45, Thomas Bogendoerfer wrote: > On Tue, Sep 20, 2022 at 09:07:11PM +0800, Gaosheng Cui wrote: >> All uses of allocate_irqno() have been removed by >> commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"), >> so remove the orphan declaration. >> >> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> >> --- >> arch/mips/include/asm/irq.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h >> index 57561e0e6e8d..2f47f56fca82 100644 >> --- a/arch/mips/include/asm/irq.h >> +++ b/arch/mips/include/asm/irq.h >> @@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq); >> extern void arch_init_irq(void); >> extern void spurious_interrupt(void); >> >> -extern int allocate_irqno(void); >> extern void alloc_legacy_irqno(void); >> extern void free_irqno(unsigned int irq); >> >> -- >> 2.25.1 > applied to mips-next. The patch didn't apply, because you alread removed > alloc_legacy_irqno/free_irqno in your previous patch. I've fixed that > while applying, but please you latest mips-next branch for creating > patches next time. > > Thomas. >
diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h index 57561e0e6e8d..2f47f56fca82 100644 --- a/arch/mips/include/asm/irq.h +++ b/arch/mips/include/asm/irq.h @@ -63,7 +63,6 @@ extern void do_domain_IRQ(struct irq_domain *domain, unsigned int irq); extern void arch_init_irq(void); extern void spurious_interrupt(void); -extern int allocate_irqno(void); extern void alloc_legacy_irqno(void); extern void free_irqno(unsigned int irq);
All uses of allocate_irqno() have been removed by commit 69a07a41d908 ("MIPS: SGI-IP27: rework HUB interrupts"), so remove the orphan declaration. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- arch/mips/include/asm/irq.h | 1 - 1 file changed, 1 deletion(-)